Received-SPF: pass (google.com: domain of linux-kernel+bounces-197434-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e1719623-a42e-4394-b840-2741975ead37@acm.org>
Date: Fri, 31 May 2024 13:13:07 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] block: uapi: Fix compliation warning of using
 IOPRIO_PRIO_DATA
To: Zhiguo Niu <zhiguo.niu@unisoc.com>, axboe@kernel.dk
Cc: dlemoal@kernel.org, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com,
 ke.wang@unisoc.com
References: <1717155071-20409-1-git-send-email-zhiguo.niu@unisoc.com>
Content-Language: en-US
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <1717155071-20409-1-git-send-email-zhiguo.niu@unisoc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 5/31/24 04:31, Zhiguo Niu wrote:
> Generally, the input of IOPRIO_PRIO_DATA has 16 bits. If use format "%d=
"
> to printk IOPRIO_PRIO_DATA, there will be the following warning or erro=
r.
>=20
> fs/f2fs/sysfs.c:348:31: warning: format =E2=80=98%d=E2=80=99 expects ar=
gument of type =E2=80=98int=E2=80=99, but argument 4 has type =E2=80=98lo=
ng unsigned int=E2=80=99 [-Wformat=3D]
>     return sysfs_emit(buf, "%s,%d\n",
>                                ~^
>                                %ld
>=20
> This is because the output of IOPRIO_PRIO_DATA is converted to "UL" fro=
m
> IOPRIO_PRIO_MASK, which is not reasonable. unsigned int is more suitabl=
e.
>=20
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> ---
>   include/uapi/linux/ioprio.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h
> index bee2bdb0..9ead07f 100644
> --- a/include/uapi/linux/ioprio.h
> +++ b/include/uapi/linux/ioprio.h
> @@ -11,7 +11,7 @@
>   #define IOPRIO_CLASS_SHIFT	13
>   #define IOPRIO_NR_CLASSES	8
>   #define IOPRIO_CLASS_MASK	(IOPRIO_NR_CLASSES - 1)
> -#define IOPRIO_PRIO_MASK	((1UL << IOPRIO_CLASS_SHIFT) - 1)
> +#define IOPRIO_PRIO_MASK	((1U << IOPRIO_CLASS_SHIFT) - 1)
>  =20
>   #define IOPRIO_PRIO_CLASS(ioprio)	\
>   	(((ioprio) >> IOPRIO_CLASS_SHIFT) & IOPRIO_CLASS_MASK)

This change is safe even if the mask is applied to an expression with mor=
e bits
than an int because of the integer promotion rules. Hence:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>