Received-SPF: pass (google.com: domain of linux-kernel+bounces-197460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0394faa7-af19-4929-a1e4-00d21d0749aa@linuxfoundation.org>
Date: Fri, 31 May 2024 14:39:41 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/3] selftests/futex: clang-inspired fixes
To: John Hubbard <jhubbard@nvidia.com>, Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Peter Zijlstra <peterz@infradead.org>, Darren Hart <dvhart@infradead.org>,
 Davidlohr Bueso <dave@stgolabs.net>, Edward Liaw <edliaw@google.com>,
 =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>,
 "Nysal Jan K . A" <nysal@linux.ibm.com>, Mark Brown <broonie@kernel.org>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240531200755.128749-1-jhubbard@nvidia.com>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20240531200755.128749-1-jhubbard@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/31/24 14:07, John Hubbard wrote:
> Hi,
> 
> Here's a few fixes that are part of my effort to get all selftests
> building cleanly under clang. Plus one that I noticed by inspection.
> 
> Changes since v2:
> 
> 1) Added a sentence to the .PHONY patch, to show that it is removing
>     duplicate code.
> 
> 2) Added the actual clang warning output to the commit description.
> 
> Changes since the first version:
> 
> 1) Rebased onto Linux 6.10-rc1
> 2) Added Reviewed-by's.
> 
> ...and it turns out that all three patches are still required, on -rc1,
> in order to get a clean clang build.
> 
> Enjoy!
> 
> thanks,
> John Hubbard
> 
> John Hubbard (3):
>    selftests/futex: don't redefine .PHONY targets (all, clean)
>    selftests/futex: don't pass a const char* to asprintf(3)
>    selftests/futex: pass _GNU_SOURCE without a value to the compiler
> 
>   tools/testing/selftests/futex/Makefile                      | 2 --
>   tools/testing/selftests/futex/functional/Makefile           | 2 +-
>   tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 +-
>   3 files changed, 2 insertions(+), 4 deletions(-)
> 
> 
> base-commit: b050496579632f86ee1ef7e7501906db579f3457

Thank you - applied to linux-kselftest fixes branch for next rc.

thanks,
-- Shuah