Received-SPF: pass (google.com: domain of linux-kernel+bounces-197488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 31 May 2024 15:10:45 -0600
From: Keith Busch <kbusch@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>, leit@meta.com,
	"open list:LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)" <MPT-FusionLinux.pdl@broadcom.com>,
	"open list:LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)" <linux-scsi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mpt3sas: Avoid test/set_bit() operating in non-allocated
 memory
Message-ID: <Zlo81SBdvflQ_38O@kbusch-mbp.dhcp.thefacebook.com>
References: <20240531180055.950704-1-leitao@debian.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240531180055.950704-1-leitao@debian.org>

On Fri, May 31, 2024 at 11:00:54AM -0700, Breno Leitao wrote:
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 258647fc6bdd..fe9f4a4175d1 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -8512,6 +8512,12 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc)
>  	ioc->pd_handles_sz = (ioc->facts.MaxDevHandle / 8);
>  	if (ioc->facts.MaxDevHandle % 8)
>  		ioc->pd_handles_sz++;
> +	/* pd_handles_sz should have, at least, the minimal room
> +	 * for set_bit()/test_bit(), otherwise out-of-memory touch
> +	 * may occur
> +	 */
> +	ioc->pd_handles_sz = ALIGN(ioc->pd_handles_sz, sizeof(unsigned long));
> +
>  	ioc->pd_handles = kzalloc(ioc->pd_handles_sz,
>  	    GFP_KERNEL);
>  	if (!ioc->pd_handles) {
> @@ -8529,6 +8535,12 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc)
>  	ioc->pend_os_device_add_sz = (ioc->facts.MaxDevHandle / 8);
>  	if (ioc->facts.MaxDevHandle % 8)
>  		ioc->pend_os_device_add_sz++;
> +
> +	/* pend_os_device_add_sz should have, at least, the minimal room
> +	 * for set_bit()/test_bit(), otherwise out-of-memory may occur
> +	 */
> +	ioc->pend_os_device_add_sz = ALIGN(ioc->pend_os_device_add_sz,
> +					   sizeof(unsigned long));
>  	ioc->pend_os_device_add = kzalloc(ioc->pend_os_device_add_sz,
>  	    GFP_KERNEL);
>  	if (!ioc->pend_os_device_add) {

Do we need similiar ALIGN for _base_check_ioc_facts_changes() too?
Otherwise, yeah, the {test,set,clear}_bit() ops expect an address to
something aligned to 'unsigned long'.