Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp723968lqh; Fri, 31 May 2024 14:47:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVbDsEJABW3LYkwsUg4asO/8FmL276M7b1+Ba27eHPly7mKMInW3CpRqSl8yk0BBLxEfhH21193AbgU0XB7wqvy8uYKESncXnkGCN3X/A== X-Google-Smtp-Source: AGHT+IGTPWayMJ1yp1d/jhy1T2EyrLHzv310msNUQlUgYVaFrOoXUxkFVYgV5rd/bGptKJqboSpe X-Received: by 2002:a05:6a21:329d:b0:1af:5a6f:1c62 with SMTP id adf61e73a8af0-1b26f0e6f24mr3769018637.4.1717192074050; Fri, 31 May 2024 14:47:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717192074; cv=pass; d=google.com; s=arc-20160816; b=KSPQUjmuImVY/KjGuGQxh4iZcUvPMZetJGeeDnpQgfp7Dpd1tpftyzHmZw0IBy7g6j UjD281F2ScW9w/CoYyOPwUjA4KkIDfRK603M8rlPyjrU6uUmYv07Sf7mtaqAFzpBizd2 tnrwWWR9gku5Jef8MKZcdYzTme7tlU0RGvTuqzzc3AtdCAqhzUtUqKNT6n1ny4Snhp6i RaE6ztWScnSkf+pE5PfIeHwiosPcHTZ7Z8vheHYFg3UiQnQWkLh8ho4aV9z3y3D0ypaj Au4XZ6YqHoIPZzN9aGT4LM90qorQU7f6dtpvxy+fjvMglJTl+lLCMJ+LJmlJGqWhQGCu Pnsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=rtHYcIIANaNmP7Pcq8fEZ6w/9yj5+j/VSiFZL5pfXNU=; fh=PRkqPuSu9vmoxEJvzuURoA0smrTJYHqAe9/r4Z1lGkk=; b=vAKgf0q/NELJ8w21jE9sUV5fbXG3JeeMhwnJRiJzvNmishLcdvcmRd2okEoHg5iQj9 TceW5NR7rBgVOQmRTrnPLdnPKd6EDX9LscfdMdr+oj7YYQIpcuKHYQv8Al9dxwOqDE8w Gnqt9/Q0QTQJFyUkKjt9dnLwIk6iGijOA6SQixsG01ITrOmacAT3VNxAHdYUM3lzA38N l9HAZi9pepHRtZkTyW3hTOA8zjuR7KKlNgUL+DigL/06fwCLGVPSOLYscQ2amAl5sejI 1HrXdMCu/kYo3xURONhmX8xcMkiE1Dp4PYh/jz3A3mjQm/IL05LkxWCQ5mTVGy4vCMDi GaBw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PXvx31dm; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-197533-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197533-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c5b8a3e220si1119158a12.900.2024.05.31.14.47.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 14:47:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197533-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PXvx31dm; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-197533-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197533-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2A839288AC0 for ; Fri, 31 May 2024 21:46:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA27780032; Fri, 31 May 2024 21:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PXvx31dm" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1FC57F7EF for ; Fri, 31 May 2024 21:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717191987; cv=none; b=f3RrRr9lw0b5/m0+9blochP7NICZUsjmmoBNosq5S92bvSlJgilmIdU5I6bG04jXaVZhX/GE5+2U2mlEh0oO652x6QkLLyPG83BpZPJqAr7KtJSj0g39MnRY1eeYY/cL9kTqTmON5qx2sXWR17IrDTzTMlno/7RGP2htXwG6Qnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717191987; c=relaxed/simple; bh=l9l3FqC9dknDCtsJMKp0h5MAOYBbJfIqVGQU5aZNZEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YDzFA9chsn7pVzKufxiIWr01D34iXU1cxJkhQYiI8kWJbNdHDl2TZ3qYFPgQBzybJKRZkm6DfbFVokyFrUlc6xo3XFxkHm5GBkLK7ZXDx7QKKpt+vXsE5MVsEnoW/OoyzJP5/4Z+BBrzFgsXKoQ0ksHu+/6pTDf98SWZx6F5aA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PXvx31dm; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717191985; x=1748727985; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=l9l3FqC9dknDCtsJMKp0h5MAOYBbJfIqVGQU5aZNZEg=; b=PXvx31dmchmizR+dLssJtvMY2OHL8wSXZN50yMnbNz+GoYLtuFeU/Gt6 xOk/MOia1ynXz1F0wtInf6VJk4eU+sPyQ9P86gTrq/fHTPwNyF7ua+TWK GPGRD5sbvVoRQxMILwiPdoky78BUuikI+mxFnO0EAYCPyAa9aaaG8tP9x Pda9e7/6okRVOTGMS1Q4eGajf+r4dI3bG2H2qfh/I0TA1avqehlLPRQzu 5wbmDMofJkfdjyNWTSkdw1iXPBtWDSoWljGU5JbgnJTu3A7PfuQKt/f2k ED6cqIaeyEhDXrqS0Jy0pRx7jhEOwVbtbDzBoa4dPF69T8ghLAbSfrTmx g==; X-CSE-ConnectionGUID: keabngv+REORBiiOFPZPag== X-CSE-MsgGUID: a6fhAkGmSzGK+23W5S3yxQ== X-IronPort-AV: E=McAfee;i="6600,9927,11089"; a="25158614" X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="25158614" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 14:46:24 -0700 X-CSE-ConnectionGUID: vQR7QD4/TY2g2Hysghvfjw== X-CSE-MsgGUID: 4IdUVHs4R8G1i4VFHNMhug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="36297654" Received: from uaeoff-desk1.amr.corp.intel.com (HELO [10.125.108.48]) ([10.125.108.48]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 14:46:24 -0700 Message-ID: Date: Fri, 31 May 2024 14:46:23 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 09/12] mm: implement LUF(Lazy Unmap Flush) defering tlb flush when folios get unmapped To: Byungchul Park Cc: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <20240531092001.30428-1-byungchul@sk.com> <20240531092001.30428-10-byungchul@sk.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/31/24 11:04, Byungchul Park wrote: ... > I don't believe you do not agree with the concept itself. Thing is > the current version is not good enough. I will do my best by doing > what I can do. More performance is good. I agree with that. But it has to be weighed against the risk and the complexity. The more I look at this approach, the more I think this is not a good trade off. There's a lot of risk and a lot of complexity and we haven't seen the full complexity picture. The gaps are being fixed by adding complexity in new subsystems (the VFS in this case). There are going to be winners and losers, and this version for example makes file writes lose performance. Just to be crystal clear: I disagree with the concept of leaving stale TLB entries in place in an attempt to gain performance.