Received-SPF: pass (google.com: domain of linux-kernel+bounces-197565-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 31 May 2024 19:33:20 -0300
From: Gustavo Silva <gustavograzs@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, 
	conor+dt@kernel.org, lars@metafoo.de, christophe.jaillet@wanadoo.fr, 
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: iio: chemical: add ENS160 sensor
Message-ID: <xnxbqzcb3qhbyidnlaveghmw6xm2ughhjbl36f2u3eeybyyogf@o7lhi2raw32o>
References: <20240529001504.33648-1-gustavograzs@gmail.com>
 <20240529001504.33648-2-gustavograzs@gmail.com>
 <20240529-upper-brisket-f326418bcfc2@spud>
 <20240529-rule-asparagus-2e7015bdb50d@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240529-rule-asparagus-2e7015bdb50d@spud>

On Wed, May 29, 2024 at 05:37:17PM GMT, Conor Dooley wrote:
> On Wed, May 29, 2024 at 05:36:38PM +0100, Conor Dooley wrote:
> > > +      gas-sensor@0 {
> > > +        compatible = "sciosense,ens160";
> > > +        reg = <0>;
> > > +        spi-max-frequency = <10000000>;
> > 
> > If you want to include this, you need to add an
> > allOf:
> >   - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > above. Otherwise this looks pretty good, so with that added
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> (Please make sure to actually test it next time!)

Hi Conor,

I'll fix it in v3.
I had some trouble running the dt_binding_check target, but I got it
working now. I'll remember to run it in the future.
Thanks.