Received-SPF: pass (google.com: domain of linux-kernel+bounces-197627-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 1 Jun 2024 03:28:49 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>, 
	Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>, =?utf-8?B?UmVuw6k=?= Rebe <rene@exactcode.de>
Subject: Re: [PATCH v3 2/4] hwmon: Add support for SPD5118 compliant
 temperature sensors
Message-ID: <uvikiflwuoz3szchmvke7p3ymqvcngkydehk6cctdv24cxsh6r@7d5vxcvdca6l>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>, 
	Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>, =?utf-8?B?UmVuw6k=?= Rebe <rene@exactcode.de>
References: <20240531230556.1409532-1-linux@roeck-us.net>
 <20240531230556.1409532-3-linux@roeck-us.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yq7qukcenpm3ibk2"
Content-Disposition: inline
In-Reply-To: <20240531230556.1409532-3-linux@roeck-us.net>


--yq7qukcenpm3ibk2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> +/* Return 0 if detection is successful, -ENODEV otherwise */
> +static int spd5118_detect(struct i2c_client *client, struct i2c_board_info *info)
> +{
> +	struct i2c_adapter *adapter = client->adapter;
> +	int regval;
> +
> +	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
> +				     I2C_FUNC_SMBUS_WORD_DATA))
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_word_swapped(client, SPD5118_REG_TYPE);
> +	if (regval != 0x5118)
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_word_data(client, SPD5118_REG_VENDOR);
> +	if (regval < 0 || !spd5118_vendor_valid(regval & 0xff, regval >> 8))
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_byte_data(client, SPD5118_REG_CAPABILITY);
> +	if (regval < 0)
> +		return -ENODEV;
> +	if (!(regval & SPD5118_CAP_TS_SUPPORT) || (regval & 0xfc))
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_byte_data(client, SPD5118_REG_TEMP_CLR);
> +	if (regval)
> +		return -ENODEV;
> +	regval = i2c_smbus_read_byte_data(client, SPD5118_REG_ERROR_CLR);
> +	if (regval)
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_byte_data(client, SPD5118_REG_REVISION);
> +	if (regval < 0 || (regval & 0xc1))
> +		return -ENODEV;
> +
> +	regval = i2c_smbus_read_byte_data(client, SPD5118_REG_TEMP_CONFIG);
> +	if (regval < 0)
> +		return -ENODEV;
> +	if (regval & ~SPD5118_TS_DISABLE)
> +		return -ENODEV;
> +
> +	strscpy(info->type, "spd5118", I2C_NAME_SIZE);
> +	return 0;
> +}

What about adding DDR5 to i2c_register_spd() and dropping this function?


--yq7qukcenpm3ibk2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmZaeVEACgkQFA3kzBSg
KbbgyxAAqE+ScpBLU96XG/G/fwdHnYzmRzPSIDh3hS3WrGTiKbiADyZdKDv0QzI2
ay8NiTS5Qbrhsmwym+FIlTSEGHbUeOy3tfiwHCpEb46NdWKWkVFec8KjZh03S7JW
Krkv/V5iiyGTugcrxtzLkBQUTBZQZxped1RcfbDBX9+CjGnzNHWe3CskTU0Zk9br
m1Xb6BRg+rEzpiaGdDbOecQJeGwgAj6x7TEo5r5qeFA6gqJzPekcfrNayrnMPDL0
VQSpaaL73YCZwytnSroDx2qunLhbL+6QTvzNZ/1760oe+m95V7Cc2wPXbFS5X11c
sikHnP7ZZMoKZ5ZzCceNkJdBxJqTlZTIZ3MLqtn9jZ0E5KT9yStvBdsdhE0T3t4Z
wv4hLRzPW3NgANZu2AKki4G+ync/k4vku1kr0tPeuHCQA8OiuGQG0x3MRCst+8Uo
odfRZwMtWJtuSEVBXfvD2QSxP9E1AYqRDt1lJQtD4zFaul/w78w9ng/uYgiyhzuY
SS0OcpayaeobWd/rxviy3yKO3ZHwcTlr43sxiqaiOtA2Touq50cpMCa971zFkWOp
0XrwfYbSCsUus8RDb5z7TliJA1zVhNy547ao7/uRPj+BUT1/2MCd+4bZ1j7eTami
p01vZXUSy1Tk2LedVl4012X8LGTy0olO6ingqNsMVfOkW91Lbv4=
=+2io
-----END PGP SIGNATURE-----

--yq7qukcenpm3ibk2--