Received-SPF: pass (google.com: domain of linux-kernel+bounces-197643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	=?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Christian Brauner <brauner@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Alexey Gladkov <legion@kernel.org>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v2 2/2] selftests/fchmodat2: fix clang build failure due to -static-libasan
Date: Fri, 31 May 2024 18:45:34 -0700
Message-ID: <20240601014534.268360-3-jhubbard@nvidia.com>
In-Reply-To: <20240601014534.268360-1-jhubbard@nvidia.com>
References: <20240601014534.268360-1-jhubbard@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WrUx7RSxmOPzHK/+ZgaZrZZbueHsFEbfHaK+j7kI1W78KeArUg7ffDwnIA9b?=
 =?us-ascii?Q?Mcz4OmwOwEfnVgybEdKekPXJoF4SnX6BOYulMHXsNQoV10rFl2pg20oxtM8K?=
 =?us-ascii?Q?glzk7gGwzpkfBiAfrh2wfhwAAIBeMigkIYKiGBxPqGld1cZz0ghPYkNO0gp9?=
 =?us-ascii?Q?5/cUEky3VNJZueQTY/s5T5SgYXI0gXIXOyY6WoQPp3KMVICFXW7yJrTvrSLZ?=
 =?us-ascii?Q?Qtwa3C/LrNUvRzYdxoXkIw9Qp3Ro/WUK+b7N1+1mYL47VUuft8O0KFGGKy6P?=
 =?us-ascii?Q?im/XBJ5z3bcMg3wMVDmnEJGmk27d995wQGjWYvpqEAIkDc5vXFWFNbM/8gex?=
 =?us-ascii?Q?3Fm9gEwoqmQ0tv9T0q2XhOKf74HLvuYC+z2LK/l0z7cSbT0hmoeGCp+zPToK?=
 =?us-ascii?Q?ZwXs0Wk5tX8WsAW3rVFOV87vdPrfhRkSmMSfA/hIV4Tf1tXdTFIW19SxZTMh?=
 =?us-ascii?Q?l3gVrxL3rcIIKfcvXPnkWFpNLv0cGOKiye/kWZ0+BjNGUmr1GSqICGun5UfZ?=
 =?us-ascii?Q?HM8ZRjG7deaMNvEV5BCIO8PkAPIQ1KYnkxmFK9+fnTJ7YVCfRWjKGD4E+pb4?=
 =?us-ascii?Q?Y6Zv8zY1uZTJRhCJI3SH/WwR0hq15eweObZvZp4Du8YAzVkI1FsdZmMTASaC?=
 =?us-ascii?Q?qKAMUqVq0g2rotE/1ADHZpDCwUyMc2iQ3vuXWTc94r8o3FDkz+8CA2KS5GG1?=
 =?us-ascii?Q?Nz/nqJuaFRSuiyuQFMIztKualgvGd+pUt4bQSbrh8UiGnx5+lwW9jL8N5s+B?=
 =?us-ascii?Q?wZGD7VuEnNNDpVfLA2dsVxVvUeBwyXI5efdsrIZ+Vi+jet/270dfl0LsqqVS?=
 =?us-ascii?Q?kWVOXjnNhIOFik8T2j/ovDB8jhwLomo6gv/z00CdH8URlLS3JuR1Sx5FigAl?=
 =?us-ascii?Q?YELrw3EbDk2NwwnYWmHtcf5dfFQpMIqWIbq5zrsVikXluTiM/RCjIKqEmG1W?=
 =?us-ascii?Q?7lS5IaA76mbzezwrszOcuPQfHvuWfH5B7ItC2EHpQ1qAvLoEO0AmSOnbw34d?=
 =?us-ascii?Q?6dbpQzViKmGGGMvHdEoRp4n2MYB2pnlwTrQ45fNGDC5Hmguo1VWDle654T9s?=
 =?us-ascii?Q?HqGRsMV1Sjqei1QI6XsXk7CcRQfBK/zNclhqPjzlGfUJs18kd0GcEzVVwQJ4?=
 =?us-ascii?Q?VJ2gSQM5hGPvH/cYiZDOibBVDOuOBnICRQybHeT09oPZMU8pN2zB1DbAJMi3?=
 =?us-ascii?Q?fO/Bot0j/ch07ZgSz+PmeNHOSgDuLHsXyM/sA4jXrrUYeUaP1kd2sqQK39Jn?=
 =?us-ascii?Q?lSuu0MBnvjMyKA8UD9EjmetW5/RNF1ctn95SkFfhE2CSGuiaFQFUvvppDT3C?=
 =?us-ascii?Q?Sm8jJrWKHIEWioYwmaCbw9LN/Szym29PAMOB397fZnbYFe8RaDUsKpdC1XjU?=
 =?us-ascii?Q?aBdOzvdrcM64ucEEOP+bRp650ZiymWtAjhru6z6okt3W0KBZh8ulSUFOLzH4?=
 =?us-ascii?Q?LhhoNj/qiqMDQtaNOcSJJTf5HL8rE7gFEhKp0fTmdHTwX4p9+XbVtQTxkznP?=
 =?us-ascii?Q?Ow9UP6djQCnKzj9S/i57m6jbljt1r11wgjLYXrhozpUTJG5lPR/Z2FSziO7U?=
 =?us-ascii?Q?Fmg8pzqsLquV/gADbnMIdzGSp8PHlThXAsrqePxy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d6bced3-57fa-4a00-e4d8-08dc81dc8941
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2024 01:45:37.6058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B1bpij5keAzFKN9qQVJZ9KOcV/W+TSYirA64O0pQYLgDDe8nuLuSenhmvV1tzWckn3c1hbkmkheoAzpvUrdxLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5931

gcc requires -static-libasan in order to ensure that Address Sanitizer's
library is the first one loaded. However, this leads to build failures
on clang, when building via:

    make LLVM=1 -C tools/testing/selftests

However, clang already does the right thing by default: it statically
links the Address Sanitizer if -fsanitize is specified. Therefore,
simply omit -static-libasan for clang builds. And leave behind a
comment, because the whole reason for static linking might not be
obvious.

Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/fchmodat2/Makefile | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/fchmodat2/Makefile b/tools/testing/selftests/fchmodat2/Makefile
index 71ec34bf1501..4373cea79b79 100644
--- a/tools/testing/selftests/fchmodat2/Makefile
+++ b/tools/testing/selftests/fchmodat2/Makefile
@@ -1,6 +1,15 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined -static-libasan $(KHDR_INCLUDES)
+CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined $(KHDR_INCLUDES)
+
+# gcc requires -static-libasan in order to ensure that Address Sanitizer's
+# library is the first one loaded. However, clang already statically links the
+# Address Sanitizer if -fsanitize is specified. Therefore, simply omit
+# -static-libasan for clang builds.
+ifeq ($(LLVM),)
+    CFLAGS += -static-libasan
+endif
+
 TEST_GEN_PROGS := fchmodat2_test
 
 include ../lib.mk
-- 
2.45.1