Received-SPF: pass (google.com: domain of linux-kernel+bounces-197665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 31 May 2024 20:08:49 -0700
From: Yury Norov <yury.norov@gmail.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros
Message-ID: <ZlqQwbOVxw9an-qZ@yury-ThinkPad>
References: <20240531-lib-bitmap-v1-1-45a782cf3686@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240531-lib-bitmap-v1-1-45a782cf3686@quicinc.com>

On Fri, May 31, 2024 at 09:03:11AM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> This is the subset of "missing MODULE_DESCRIPTION()" which fall under
> the scope of the BITMAP API entry in the MAINTAINERS file.
> ---
>  lib/cpumask_kunit.c      | 1 +
>  lib/find_bit_benchmark.c | 1 +
>  lib/test_bitmap.c        | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
> index a105e6369efc..6b62a6bdd50e 100644
> --- a/lib/cpumask_kunit.c
> +++ b/lib/cpumask_kunit.c
> @@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
>  };
>  kunit_test_suite(test_cpumask_suite);
>  
> +MODULE_DESCRIPTION("KUnit tests for cpumask");
>  MODULE_LICENSE("GPL");
> diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
> index d3fb09e6eff1..402e160e7186 100644
> --- a/lib/find_bit_benchmark.c
> +++ b/lib/find_bit_benchmark.c
> @@ -194,4 +194,5 @@ static int __init find_bit_test(void)
>  }
>  module_init(find_bit_test);
>  
> +MODULE_DESCRIPTION("Test for find_*_bit functions");
>  MODULE_LICENSE("GPL");
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 6dfb8d46a4ff..65a75d58ed9e 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -1486,4 +1486,5 @@ static void __init selftest(void)
>  
>  KSTM_MODULE_LOADERS(test_bitmap);
>  MODULE_AUTHOR("david decotigny <david.decotigny@googlers.com>");
> +MODULE_DESCRIPTION("Test cases for bitmap API");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240531-lib-bitmap-7ce67db2d173

Applied in bitmap-for-next.

Thansk,
Yury