Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp865172lqh; Fri, 31 May 2024 22:47:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWVl7CZ2zEmdbVlvcZiNwP0rzOJtmwQWnq6hqpNf80NPamv8TpV8/wgd7JGZZW1DjQaQ5RyFrGbO0mklfMnQPfeL23Y3iP6QQK739XxVw== X-Google-Smtp-Source: AGHT+IFttzmM1+X165yJIL/LmHD6PLsfEzggkGtbgLX8lM7mgf7uo7mPK4opQHu+ESzeKncuiJcf X-Received: by 2002:a05:6214:5247:b0:6ae:d9a9:90de with SMTP id 6a1803df08f44-6aed9a993d7mr35343776d6.47.1717220843316; Fri, 31 May 2024 22:47:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717220843; cv=pass; d=google.com; s=arc-20160816; b=uUwunRwqyUrJ7gRKPTMaPTLFW3D7NsjsVLKABuN19SMWtmvwWVE+R4qYM0VFsE9+i4 yucnXz/2c2h9UK6NJOD3pjPizm4fT7n5qDDjvvfwriLG0C/KVg20LltreG7tpy9SO20W 9WRJV8ECwVi/XeXx7zGVYaQBRFPcXl0BiFmR1vpfXTOBAXwGwYJaF134yVNUQGtbZXXc VIGwjtGZq1owsYS2/3JOsfSYnq8S2HDtB0PT1HjkJIeJZwKZ8QQKq3k7yDszEbapglYG BCm45avYRfPzMIzpm85Rbrem5chV9u7nQAQKYNPYEQgLsrr17RHM8mRXug9r+hBIq4CQ i9Og== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=FDfev2XRL1yXC5cfA4G95FQrsHO1upVV9pZfbw8Ys+Q=; fh=daubiDCVCULyx1cNYwX2xi9XO1xqQg1QDzhQruJQwds=; b=fipzJa0JNWM2/Lu3B8YfpEquB70xI41UsLJxHAK6qXZ/Chke7xgXr8OkECqjLyfkdt 2RQRqpRK9PJDZz894cbUfNu01yt/Nw7/yA7V8pCY+DWM6IgV6wTXY6FKEgTBFMKheHw3 aKbwTGL6al+Fibyw5SsC0iNqqoBpDyJbcMyHL65vSRUQBpU0OYoXXQjUZe0sLI8BGZdK WaxDchYFcCijsoKZe/WvfO3qY7kRRMzaPydRDF3YXtzbfNtLz0JbZXgou+dKbAGcUMse n+0NQwwtpTYP5ExFntbL8urA6tSjvLhHAiR9urzHfFd4oE5LCYNHEflhmp9rxX8fKHCF Fl0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-197695-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197695-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6ae4b42c273si37740546d6.524.2024.05.31.22.47.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 22:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197695-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-197695-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197695-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 07AAE1C21890 for ; Sat, 1 Jun 2024 05:47:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BA5D125DE; Sat, 1 Jun 2024 05:47:11 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F57E37E; Sat, 1 Jun 2024 05:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717220831; cv=none; b=KEWOAvj/uqQL36C9KB+3uTtXy0zBeTRjltxDx4B5K98zSXkF4TRPLJnsYCa5/NPFmWI+5ScF0ohSgkeR+i76T/whaOr50a/vIm/Lc/vsCnjA7wm6UB2GIwR5wUnyO6dHDJx/l4YUw+EQzTPXg/oQkiCDDAqCjwck8DCB8GPA7dQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717220831; c=relaxed/simple; bh=CJ+CsOuKaOOry5C1Al6fTmEmJSHrJIOhjAx91ykVv6Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rnM6560gc0T4NVsojO8pJyN1TPisXJ0g5cXI5w/YSUergzkAhIrKfzxDBcwYLM9rm/L3r5R916y9wGnMaL8oC7BmaPKeuULl9e1bkEIOQ7GJXP3PjHUO02yLGxRmjJOFgX3YvcxYhM0wyA2vuqDah2lFnKPpSJIt20mSUk/HHwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 3EE1068D17; Sat, 1 Jun 2024 07:47:02 +0200 (CEST) Date: Sat, 1 Jun 2024 07:47:01 +0200 From: Christoph Hellwig To: Nitesh Shetty Cc: Jens Axboe , Jonathan Corbet , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Keith Busch , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , Jan Kara , martin.petersen@oracle.com, bvanassche@acm.org, david@fromorbit.com, hare@suse.de, damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v20 00/12] Implement copy offload support Message-ID: <20240601054701.GA5613@lst.de> References: <20240520102033.9361-1-nj.shetty@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240520102033.9361-1-nj.shetty@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, May 20, 2024 at 03:50:13PM +0530, Nitesh Shetty wrote: > So copy offload works only for request based storage drivers. I don't think that is actually true. It just requires a fair amount of code in a bio based driver to match the bios up. I'm missing any kind of information on what this patch set as-is actually helps with. What operations are sped up, for what operations does it reduce resource usage? Part of that might be that the included use case of offloading copy_file_range doesn't seem particularly useful - on any advance file system that would be done using reflinks anyway. Have you considered hooking into dm-kcopyd which would be an instant win instead? Or into garbage collection in zoned or other log structured file systems? Those would probably really like multiple source bios, though.