Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp880024lqh; Fri, 31 May 2024 23:34:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWYtjsdfBQd7RgRC4+CqIFW0mwVbWcHyg6HeFK2HUNO/98m32bI7oCGrUXRUqAiPssjxQZuVQ/2J8/iFTqIRH1oCi1A5sAaf3eVYp2NvQ== X-Google-Smtp-Source: AGHT+IHcEoaLGCoeqJ5ry2HCEcjkNJBzDf7up+Ste9o/APPOQ4/aKYR6KFRpB6/WadZGVv7YotGb X-Received: by 2002:a05:6214:4588:b0:6ab:8cab:213 with SMTP id 6a1803df08f44-6aecd6f0907mr44005916d6.42.1717223642574; Fri, 31 May 2024 23:34:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717223642; cv=pass; d=google.com; s=arc-20160816; b=cgJWfc/8323d7l5hdzrnizBt+LOyHF0HJKFEIC80vDq+h6w6fzO9lVq0E8Drwng2GY wk12AflldaoZr3mvkx4cZppZ7bOwNs6aRUGhTrIA8AIfYbwpnHBhFs1+wTqJcH+Rt9gm f6Qduc+MyA0xPxUGtsmIOM0st0K1fFyPxQ+KuWz+wKW9P8E6oLkd0KfnXyXbumYK/Mbh S2iIOe2OgbfYmJYWvVMvCjhS1+du70UXSfryM4eqFcfVJTFsnvWz1ixNavCt0T83aMUf tUY5LJ/Mjoi0ONuHHR24w3EwtUkXZf5z7f9u3E+CXgyijgwekDbwrJ/Lei5dIY3R/t/A Ov0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EsG6D93BOxWJChAFk9t6t87YMq7GqVbu/s/KkXeOw6w=; fh=V6GbPCat9tMLabJCBxD7jX0Vrhw7hVwYdPayKl4sW6w=; b=Ld22+r1xtCatE3ddBW2SHYrw6nT7Jej3OKvvWBmnxlYJTwJohpUdLjB+P1btMY0Q2l OEi0FAieb01QDWtYc0Ohn9MHIqBXG84Be8H4MM93m8DBoj0iocMH73Sbdakhrq3OAxFt 9xRySPQsAo1+4kJVHukOhR21Fgh21T62//lfuL7rtr5ViPeFvuOcK38OtBGXdDwJBRk8 ptShj2D7OMJnERN3ZgpsMYW25dhZpNCH6us3y+WrJNeBAAwYow0bfunG1ENUV3Inef1X qdvGrhktqUHXj2d6NQtZbFKHXB6F+AjwnzaYusbl3kmBBuXTwaS79YT52/1d0SzgGxn4 CRZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ll8GEtyK; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197726-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ae4b403db5si38517926d6.212.2024.05.31.23.34.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 23:34:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ll8GEtyK; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197726-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 414E91C20FEF for ; Sat, 1 Jun 2024 06:34:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A280612E78; Sat, 1 Jun 2024 06:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ll8GEtyK" Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA07E28EA for ; Sat, 1 Jun 2024 06:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717223635; cv=none; b=MCAzHQ4EL3qyfSA5DEsEadlGPTrakG3mZi3L986aCGaBm0mUD9z1yA3tJg1wG4ffWoXZjPk2403JKmSBQ6D59LLzHeOJqspl1w53mxyvtXW0t3NsXibkLNnjYIV5yIjG25E7X7Qj6ZDOTGPzuTDUEV+97+gzzU4e7UMDSBFh1v0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717223635; c=relaxed/simple; bh=2QF/nnbydiwBbBgg3EMekE3jzL8UxdQ2DQZh+XfISW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ByBKhlS4s7W+zinOOepy/5yNRH+ndZqgkHRcRZ6MOuxQcfQFQmj/4VT3QDaO8PtoldYN2MjTv13fKxgh8vTD6fy1xiPIDJpiB9/ulIClpTAkmwFxAB0n4oitH1M+IEsYzDXUckUlzWkNzVhby6M0SdCP1Hl0fRsZJoTLdXT15tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ll8GEtyK; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717223631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EsG6D93BOxWJChAFk9t6t87YMq7GqVbu/s/KkXeOw6w=; b=ll8GEtyK/oRSIyPppRwO1dXJnpsrjRl+DuOu446eDo1KWJIn0df3nhUQKRnZDfTGOnwrkK fV5OEvdQzGHb9jTFv0j3DY1Q3yg7qLBMQ3fS5SAFzvNITLxmCYlm4otGFiRssOiMnB5YzR 7QVxtcxg/5zfgAs2EAmYGyEorrqkfTk= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:33:46 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 06/14] mm: memcg: move legacy memcg event code into memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-7-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-7-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 01:20:58PM GMT, Roman Gushchin wrote: > Cgroup v1's memory controller contains a pretty complicated > event notifications mechanism which is not used on cgroup v2. > Let's move the corresponding code into memcontrol-v1.c. > > Please, note, that mem_cgroup_event_ratelimit() remains in > memcontrol.c, otherwise it would require exporting too many > details on memcg stats outside of memcontrol.c. In the followup work, we should decouple v1 only fields from v2 fields and then we should be able to move mem_cgroup_event_ratelimit() to the memcontrol-v1.c file.