Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp882766lqh; Fri, 31 May 2024 23:43:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUD82YcHML5+TI5f7B/Vm8kDNmN2LAqQISsu2Bq0ZbcWj11wPqBgZcUcBc7AYpCd6/yrujYxaZ0fjyNu16+E9BPOm1fe+8SkqRuilLjOg== X-Google-Smtp-Source: AGHT+IFZVwrZF52Q/f5yqKx+7rcBVwVfTXRcFjEeqsrpw8KScn+Q4GgoYQCDEgZ7rBkuI2JIQMrY X-Received: by 2002:a05:6808:2393:b0:3d1:e004:192b with SMTP id 5614622812f47-3d1e3475527mr5028501b6e.8.1717224192308; Fri, 31 May 2024 23:43:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717224192; cv=pass; d=google.com; s=arc-20160816; b=bSHhOj73XsS5LksQr81unr+2od7Lu6/OGaekZLVivCNdl/sbyELAF7n+InVxDeW7eO JCPLxfO4lmgtBWACTJbkflkL0hu0DpW9+9UtL/C4oSMKbLJprV+AxzJgji0ca+08gkAQ Gm2S3H8lbe/z/E8oGfzA1+Dx6wFIIFuG1Bq3PvIwvHqVE9E5TUGH+MuNEO+eTN8OqTjY IZARwo1kp1a8e9vdDb76vvBYvFphXi0xo8UWmAytTajhjGzZ/owrxq/C2I/6NJPMLP/U naALkpfwmv1IMquxRYcBYEUz82XuhYEneCBmXTNFA0y5sumXYixYijJD8uJsiSd9I33j yixQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6g/m2Vo4ckbmL7s3SgPNBlQnNOpuP29aYJPD6t4ximg=; fh=V6GbPCat9tMLabJCBxD7jX0Vrhw7hVwYdPayKl4sW6w=; b=k2CjPdhoq8ORc3jIBIW7JUb27T9jDpjLHvoshYnkbUMiBsi+2/kBQpDJD8cfVxboT8 zwYXsLhzimJ6/2hBMcn2M6XyqNc/dZQtzrr7idGUgnjQFHv6OiHBLtITSc3rDUnqhT92 diQ+0GAInsGkhjEBqXSwrK1DH5H66aLuoMwa3BHS4U89UnQomEUzB1yh2ZW1/8OOkjOh EaUBqyccihO+OOevmwRhgIK5CMeEE2Gl2Zyleoj6Zq4IEDY8raNtMvWl8I7U4p9g7vdU N9BKYuWgNWKPZYdnN/SVB3U1BSlFEgRz64KOYUM6BOfqzfBXV0FBdf0cqt5OnCyTYeDF Bflg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JhwTnnh1; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197730-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ae4a732b21si37532816d6.16.2024.05.31.23.43.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 23:43:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JhwTnnh1; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197730-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 070991C20E9A for ; Sat, 1 Jun 2024 06:43:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 85C99134BC; Sat, 1 Jun 2024 06:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JhwTnnh1" Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09096DDB8 for ; Sat, 1 Jun 2024 06:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224185; cv=none; b=mjeijLqzgUDKuSHnDLg3Mlvg80mnSDvElMNCc57Uua7O/Z82adHKaWlPSGWMO4QhEooTfthq38jb/zI8yBBh/pi15kUXHQaY+Uq8rZlrQtS1SleWq9tP31hnkR1RpDC2JEiW6ThZn7j6ycBzVcVJ82t3/jm72KGXxw4zbjNQzOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224185; c=relaxed/simple; bh=vb+qajOZY9DeMHN/EmkGOf0ZAQEEiqV2HlJSQg1sc+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mWqLhENjZSyvzAWNrUI0szVilwhmCYtmHQeaW68psbi2WdGzlvTiH0sJHS/UQQx7/+ntiuC8dTaKGcK3PFaFe4wSdWGfIkgSre57X0sjF4BZID6JEpEsYEOCvZoIBOV0TLSaOyCllXfZnE4+K8ZbkrIZ+bDm7+lsPCkfHPG5qNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JhwTnnh1; arc=none smtp.client-ip=91.218.175.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6g/m2Vo4ckbmL7s3SgPNBlQnNOpuP29aYJPD6t4ximg=; b=JhwTnnh1lqUzylBqkmbluW8TtdLppzH+OLMF3UnhBhc89uoOJ4FoB1XwXyRjTUIFovDeEA oR1VeeSkLb8HzsnUNOI/1tazE40iwXvaqnmWGuRnYNbpUwiPruV41EhHPKNnrDvQL4WY0Q 4WVV8sPX8eUKjOxBPtKLlrJ9dOj8kg0= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:42:55 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 02/14] mm: memcg: move soft limit reclaim code to memcontrol-v1.c Message-ID: <2tvwb3io7tynt32wwauyupbpq7kvmpkywm2e2z6v2npwmj2f7z@fydgwb7rsa6h> References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-3-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-3-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 01:20:54PM GMT, Roman Gushchin wrote: > Soft limits are cgroup v1-specific and are not supported by cgroup v2, > so let's move the corresponding code into memcontrol-v1.c. > > Aside from simple moving the code, this commits introduces a trivial > memcg1_soft_limit_reset() function to reset soft limits and also > moves the global soft limit tree initialization code into a new > memcg1_init() function. > > It also moves corresponding declarations shared between memcontrol.c > and memcontrol-v1.c into mm/memcontrol-v1.h. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt