Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp885748lqh; Fri, 31 May 2024 23:54:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUyJG0kr1xmRalxvwWJiGgZI22OJByObODgRXFbub9FV+KlKdwMipBV/+Er9sjgXEM6WazZtu8x9TsjJ7vvcK5NqXgg8j04DpgL9RDvkQ== X-Google-Smtp-Source: AGHT+IF0nZCkeAfPQZqTs1PX/AzVWrFeF7aLOIxcJ/nouLlLITFiBLp6+FefCpq+pU7XzAp1Wlij X-Received: by 2002:a50:d65a:0:b0:57a:339c:c8d7 with SMTP id 4fb4d7f45d1cf-57a363c6e96mr2417752a12.20.1717224847536; Fri, 31 May 2024 23:54:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717224847; cv=pass; d=google.com; s=arc-20160816; b=NfUivOk2I7AX/K8EkmfCp6faqBPTWnCItRYauhwH2XAGoV5rIoUOJhHUxrhXVdIirI EyocfYN0BTcLn3Hr3FUbze+YjBRbU/4RF/bR+9lTQbbfv+s5zPEs4/dYQQDPYaTBl+1m x6+h9cGxKhuyN3dlxVzrkyNeX3pYE9buz4IXv0vHmy9q19UNjx+93/zIG3fp1xcMBN0Y Yo2nVbHE3qumsCWJwC4p+ACgNuE+2NLwQzqqXyt7Mr8JAVJxX54rE6CKveCBJFKLnfzj shgZUyxRkK738YbO1gQ0TKX5lL8hdCnOh+Y7nVUP1LQOmBG4AC8k13xuc+X848QSsRcY fEXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+VIg2mNBQDjdMf0q35Z+ZSPuRtiXctWkRo8tF9MZYgY=; fh=V6GbPCat9tMLabJCBxD7jX0Vrhw7hVwYdPayKl4sW6w=; b=JPPR3Dlm2j4uQAkP+hAM8j8W71jGyyyv8I58hcXYU4ZiKIAHlbCcWU0tHVFIHtm/Q/ SlkH4u3J1pMHINOQPDhW+DzavfJ2j6S9Exx+du5/fvfy2GlueSPXEquIMmv+L1CJNhUz 7hmvte89+4X7+fB8M9R/gk42Mej2s2W/FEb2P1X++X7Pu62yFUxFDB78YDypAmt5uZ1G baia5XavNYyDjrJLBtCNFlogr0G7EFc//yENVx34lmENPC9oMGddsp88MGQRC95Agad2 QAnp2JRXzqAOQieM+cHBaj5lLUZfuiPEXKxGeckk3eoRAEQGUXcK+J9DbsCNlDO3zXxd SzUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JnrmL+Cu; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197732-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31ba79d3si1713014a12.166.2024.05.31.23.54.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 23:54:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JnrmL+Cu; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197732-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3D62D1F26121 for ; Sat, 1 Jun 2024 06:44:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86732134A8; Sat, 1 Jun 2024 06:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JnrmL+Cu" Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A0213ACC for ; Sat, 1 Jun 2024 06:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224248; cv=none; b=mJDIe79F41ere9Y+dq27YgV1s8j+hnAFixRs7RvVLjgfF92y80aH5CcogkiSK+Wvhl07g1qjKVgibFoZM2qwLQTbBSYx8MCsGwTxblUYRxjK/hkZjImC6E2fjo5Xx2e3y4vgeeHa2awsakUeRhF7SdmtbY8iPDUUYkpkZwuqDX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224248; c=relaxed/simple; bh=ovDwxi3tcz3pJoMynXB6B3gNsYX0DbhrzvDG3ymZAQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=apgtbFasi1j9Xfq1DHkfDwjhpnz4nUTw00R7vu3FB3DqobUxZLv5hKitojJoh1WwpfOGrYk3RPJPrT1aRyYU12CkIyjOE/tctLEkgINH7zepakKJ3eXJQfjheFdtXbHmoikjjWNFLTa54wNtKlIJqLJHvv5PiAOgYXERki/K5Nc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JnrmL+Cu; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+VIg2mNBQDjdMf0q35Z+ZSPuRtiXctWkRo8tF9MZYgY=; b=JnrmL+CuFdYq514T7WX6OQe2nXZR3DRfBmrOvqv5tszp4fDPFmzQETUg1HzLWpDNzD7knp MB53gtoVapBsrFQtWNirdAWi+NDzUUp3E8D9/eJR0UZH/gUZCugxekY3nRtB4IUgbm7Cf5 ct2YELDI5KIT7gxwIPi8u0fJnA1vZ18= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:44:01 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 04/14] mm: memcg: move charge migration code to memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-5-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-5-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 01:20:56PM GMT, Roman Gushchin wrote: > Unlike the legacy cgroup v1 memory controller, cgroup v2 memory > controller doesn't support moving charged pages between cgroups. > > It's a fairly large and complicated code which created a number > of problems in the past. Let's move this code into memcontrol-v1.c. > It shaves off 1k lines from memcontrol.c. It's also another step > towards making the legacy memory controller code optionally compiled. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt