Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp891532lqh; Sat, 1 Jun 2024 00:10:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXX1aU1dcebTdQt4w8G7CUi+J9yj1CLenpFtnfRP7lBDKk92+JpusS7TlxsPYV+HVrB5KNPso1M47ZFLo2y6TQU68rjGQPFpWeW18W4Fg== X-Google-Smtp-Source: AGHT+IFi7rSeoD/6DkOS99hcRNt+RoKkc7At4PbzKQ1YUftC/r6Y0t//rSJ7AfknG79DtQXO7Fe9 X-Received: by 2002:a05:6870:c184:b0:24f:d57f:86ac with SMTP id 586e51a60fabf-2508bbc8869mr4402058fac.46.1717225836673; Sat, 01 Jun 2024 00:10:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717225836; cv=pass; d=google.com; s=arc-20160816; b=xEiebh8sf0AxVep8H8ZBrCCVor+SRsKMoQeQgoszKyXKSyF9dCUqnimLA1g7VL8AtV JOzuJEE1o4HhFQpNbySLMeB2t2RfaqfBmuFgSn0i52I1rg/VMc1bRf6Cw5EACxpi0Rw6 8gNciL5mg+iU9NM/M4ET14ifE0GgK4IEU89z00/O4cUNpt4eiZdFEY3Byv+fuGLKQHgL gQnftmIOOPN9RDcOZ2Y4VGdEyKizymlRB95v7d2UugPYgm44WoCVq+KNLn3WfXRNcnHx G45krAbNeA6pdb85yJhzsjImOEL4Wupta+RInLRpTTeeIAhwUnOmC9hGU0GOOzVoHC9b 10LA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; fh=V6GbPCat9tMLabJCBxD7jX0Vrhw7hVwYdPayKl4sW6w=; b=xWW4RcSJExLgeRUYP4CLneXCjQQ73e89zV3yBRwXRfshoG5vVRoaxKTKBhtP/blYuR kt5sfHtzP0hQwzAliJfzaohywSwQMjHfDsuj45+gbEKuP0phTg55Rm8DE0ODggDBglbi rrPjrSOd8wxmmzUjwS1hLesRdqmRXWtcdb2NMCXiyitB+40ck4JK1HjWoiZ7zR+SBsgJ c5g79rMaz2ocd5PqPeypU2gTosi8LZhuK0LGXrm7Nk+KhxijrPUBtLA3ZUJPRM70fk2r ZnKU76/4p60DUu78+rRvNK+NzT8H1KeDgkCCKXb92IFrqwKZnZjY45dpAJNmD6Mhyl+F 4EGw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Tpq11TBP; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197737-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35d59d911si2910905a12.810.2024.06.01.00.10.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 00:10:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Tpq11TBP; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197737-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C94B6B25DBF for ; Sat, 1 Jun 2024 06:46:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B859D14267; Sat, 1 Jun 2024 06:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Tpq11TBP" Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82567134A8 for ; Sat, 1 Jun 2024 06:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224410; cv=none; b=mX2narXYYUD1Q2YE4tkD5BWcscb9r6mnH4IQonh5ngNTtm0rW0vOXRhNo4FyiCcHBK6BmQIV29RAv6gEbB2KYFYGLjwqqHyMmBh3IfA24fyheYbFrEhAycAukEPDJxUAzyZbwmo9AqlOlUJoqvgA06H7wE4VlQhfinSIqI9WzgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224410; c=relaxed/simple; bh=yD1y4aLy8D5qV53IkWkU03ouCcVezpWTp2WbHU8jqRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rhX6bsr0dlkh4kUNNS3K2gOg0YL88+zdINvfdoXMHYf5xJDY4s7hbhH+OZHJGwVXFpTRGt5nytjQOrPyE0YLZwn3msLOPhwhXblkGOJdSoIyhM84panxjohbl2H55hnmF4afJACWG3wjgRnwnUyLWUKsUoY6xhfLDL2yvvXs5b4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Tpq11TBP; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=Tpq11TBPzvCXFAe+S4KdI4ASzj2MnffMgdB+YBmPKZXNVUgNGAsz0nJIdkonmlmSRBflwj pvMHYWk6wPbKsifnfkYPY1oCs8FB7zYUNCay4esXuhFOeaL6j+ZzGmGBWIq5uu0gj5by9D +zUBny/uXuH/ztNkMD1V9G1k2YIreOA= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:46:43 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 08/14] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-9-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-9-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 01:21:00PM GMT, Roman Gushchin wrote: > Cgroup v1 supports a complicated OOM handling in userspace mechanism, > which is not supported by cgroup v2. Let's move the corresponding code > into memcontrol-v1.c. > > Aside from mechanical code movement this patch introduces two new > functions: memcg1_oom_prepare() and memcg1_oom_finish(). > Those are implementing cgroup v1-specific parts of the common memcg > OOM handling path. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt