Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp891591lqh; Sat, 1 Jun 2024 00:10:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOHNEajfdUslFqc6D63TRt/xND4igrFLR2bYdSR2kvD6csmw438C2hGE2uS8w9Qm1s4SPGGdj9S18n6ZVSdoBtz89dmjgbcbgv1Vr0KA== X-Google-Smtp-Source: AGHT+IElYC5Tgeo1AT82XqlcF5nwapt/u1mjJxWVP16lp3g879qiN1i1Wwx1oabWeCGZW8cdxrQB X-Received: by 2002:a17:90a:4383:b0:2c0:29d5:3515 with SMTP id 98e67ed59e1d1-2c1dc56dae0mr3403065a91.3.1717225848829; Sat, 01 Jun 2024 00:10:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717225848; cv=pass; d=google.com; s=arc-20160816; b=iQxWJ02EnvFuFKhS+vDTtBR1JKJV+gv7rVeDCsNz09kFs6BRgI2rxo/bRSXE+4yqnm N6glonzw9gk7WA4X3uA5gpIjAlPYlWO/b76bbaf7GEZSepIfy//2B/lI/mNf3XvkNkqR nfIWPKW6HIP/j0vKvDfocm0qRQE8Auk64yYUdj3u1SYqsXvuRdaEFwcuwu/0ViVqofpN ntRzl2Q0IUzvV9DVaqg61cxsTGN5/G9RM4GY+Hr/zlU7m2YZyKYXrVRg/X4bgK2xigjq LRCNvnanDe5dbYKs39NqtHeCgnuRh2xVAZf+o04rdresKL3m/zBo0BvReHe1wd1cTIMC vgSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; fh=V6GbPCat9tMLabJCBxD7jX0Vrhw7hVwYdPayKl4sW6w=; b=RSzbtG8mGun6pDai491m/Ss16sFCHD/75qr/l0vdbzifioZViW01HV59WFzhvuYOnS U+Vn4Qgi7gJf2/TjNQaCzYji93KGfI3DjRn/+42nfeeezH9MqfClp78wlm7lvbCE05ZJ I1YV1wL/H3zfovDXn/0y5vgPSyiKXslkrOIprQA5BLTbexkombrl8mMAe2ZlJZATDMHy tDNwaBxZTQF/gyayd/FCdvn9aZrKPEvv9hl5gBLOgYCNLNyOyt1KfEYOnZsX3jv391vR 8oNcXmp2EfiEfy8RjC2qxx4AcwA/CbnDQwvpWjRZB0wJndXWvLdq6Cj9WRdJOrfVHWb0 8CZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=SnMlZvS7; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197738-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197738-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f63235f43dsi28995225ad.134.2024.06.01.00.10.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 00:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197738-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=SnMlZvS7; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-197738-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197738-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9BC72B25EFB for ; Sat, 1 Jun 2024 06:47:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E3C013AF9; Sat, 1 Jun 2024 06:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SnMlZvS7" Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127E017BD9 for ; Sat, 1 Jun 2024 06:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224473; cv=none; b=oIVUrJsmp965PLMA9gIg15lTuLVNlOw2ZGqisoMyukETDmepbvHgec/Bdgm9xtZpTwmw1qenwoH0w3ibBx4OJrB/c08lZ2yshA5k1LY2WDB8lvJbOKX6Z/AheKV29oLnhsPK+Mo6hGIZ5tnfy/rNm7SdUyr5G3f/NCH03ITUKmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717224473; c=relaxed/simple; bh=yD1y4aLy8D5qV53IkWkU03ouCcVezpWTp2WbHU8jqRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JcgkxR1JErIXK77x8O1mSIAuIdNArfThgKF5bpW/KJPjDzQB77SGZfAiNFO1FnM9Ta/WUZlINiLW1zs2B1gafFz5JwD6wv06DlgNKefaRLw9GXwCTSdcBHzZV4cFr4jTafRsZ4IvI5NzV+bbjUInsktOsWfPujTkwfrzMOVaYxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SnMlZvS7; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sjLZZRzBZcTCQY3kC3rZ1Hok+tlDm5Px6KNoO2+Q8ls=; b=SnMlZvS7KOj0xhhJCHn+El31RwcaODxWUU61//d2H0RnO5zEf9Rr+PlMnX0X+904K+YKmD zHENlx9nL4F1M0jXyshhqT9bVFzX3OW+KNrPt9SoiylPJcOcVnanGG/MvHVmvYfyd5uny0 DRPEpwoxKj8nHoMt35aL3o1778gm39M= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:47:45 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 08/14] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c Message-ID: <73dfsckpotrrgmq3zsatinqwkfwpbid3eniegigonbsnz4ewl7@ywuahcwkcl3r> References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-9-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-9-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT On Tue, May 28, 2024 at 01:21:00PM GMT, Roman Gushchin wrote: > Cgroup v1 supports a complicated OOM handling in userspace mechanism, > which is not supported by cgroup v2. Let's move the corresponding code > into memcontrol-v1.c. > > Aside from mechanical code movement this patch introduces two new > functions: memcg1_oom_prepare() and memcg1_oom_finish(). > Those are implementing cgroup v1-specific parts of the common memcg > OOM handling path. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt