Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp900417lqh; Sat, 1 Jun 2024 00:38:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUoAbJeQcSXG8qHqJ/Wsf08SYOCVp6Z6tPx9ct3mSLmUrCR2yYneHX33/cb1j5en2ifXaY5SYlu5NIl5eBBxtdoorn9QWcrFdYvBRjn4A== X-Google-Smtp-Source: AGHT+IE2mBjniKNdh7mNvPpKokCc2ZE1VdiMT43dJC9lqHiNLNlZTz01Ky2OkE6XEj3e5F40ESRn X-Received: by 2002:a17:90b:245:b0:2c1:dc60:d933 with SMTP id 98e67ed59e1d1-2c1dc60dc49mr5668201a91.19.1717227537590; Sat, 01 Jun 2024 00:38:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717227537; cv=pass; d=google.com; s=arc-20160816; b=EVPKrseIwp8oItyEHGN/bOsOf9Nht0zc3FyquCXrj4mfkoyqDc4eW3O2Q6owx1R34q V9RyCXBSmbdmB81p1I8pS0zhL7cqU9ebvpE1Ojvod8B62Kb7Nx1p5FtP9kn29hFPE9PV +c8XfP1dq5NbpD+mktdVtoRKCkmEQYGlBuU1EE6hiUUPFL9ZaUCZesCHM3EDz8COIonQ EiGtaiSXpgi7un1Pk35xy2TVq2oqLUCvfIWzLEnS4/Z8O4dswLufkuBZE5yzDykJ+jio IkVMDAcdLxbhNksQaoPg+SdI60N3zJKZBU6A9399pCwep26TXKRAymwMC1QB68FKeqGF PA0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject; bh=s6+hjobg2DgR5DmKb58zZtf6JS18fm5IRuVXnMRhnKc=; fh=L3PQw/sDNVqL7+Dk7hdPqK3pZ11REqGLfT6DRoUjXwU=; b=Cx4OaJQtmaCfF96B0Wxth2AxwW1twvbMhoKMmLiwaLEr4yzy2iK8YC5TMIge0SmGKr N849h3y2Zc+mSuKLH5QoEVF3dbF1Y0byAtdPGRHIfkUmBihtj8gwFRUc4JIWJMnC0gwj k+ZRFNUXILaDueyLb4JXXAZ5JLNO4eyEz99S7vAdg6YF8PpBJAEhWRxVcR18kkdEdFQL suXDw9yy8DU59PIQIWFSXM7I1tXcZcKtPAt97oV1Rtx/YsH4sf5OqMJXfDyjLYL013Gi 7jQRcEvlwFRQRul/d10Hmn7P3kO96R+Y51gaXDm086hHaL8wD4N3YHTmttgGJDcG8ult BMWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-197753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197753-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1e4c3d7a7si2361062a91.49.2024.06.01.00.38.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 00:38:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-197753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197753-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 35722288121 for ; Sat, 1 Jun 2024 07:38:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DA5971946F; Sat, 1 Jun 2024 07:38:46 +0000 (UTC) Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D379CD304; Sat, 1 Jun 2024 07:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717227526; cv=none; b=p23zENO05dlfWaACoINKBhirvpzbtu70O24nYAK2BbtADNVC7wWtG4x7E0ViHfBkj18YI3VFNUjAEHrt4qLk4C04wk/+11B7hFxR8ZUnkpLybt2qGVNkSaaBfFYDVPmwWmyxogF+D++wMey+dDE2SIS0q+lJGOeBg5aE3IgXCuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717227526; c=relaxed/simple; bh=TGhn62G3kHUo4+xm8IQf/8vUBogZ4sWXSEQEar1FMI4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Ea63JVrUnvuVyaMpSE7JM08r+dFnvdu01579mQErx4A+ySq1speLxduA1Td7tdrM3Wdc/9HPAv7P94LXqKkI53w5vFq52j0wwOV05iUx6bTE8lvR0J+SMkqxrOP8Y+ZJzL3OG/jiBeGdcopXgwBrP2YTnMHILWlVh275JhXqYx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VrsKw5MhNz4f3n5j; Sat, 1 Jun 2024 15:38:28 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id AB0DC1A016E; Sat, 1 Jun 2024 15:38:39 +0800 (CST) Received: from [10.174.179.80] (unknown [10.174.179.80]) by APP2 (Coremail) with SMTP id Syh0CgAXPA_9z1pmSDx2Og--.13740S3; Sat, 01 Jun 2024 15:38:39 +0800 (CST) Subject: Re: [RFC PATCH v4 0/8] iomap/xfs: fix stale data exposure when truncating realtime inodes To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandanbabu@kernel.org, jack@suse.cz, willy@infradead.org, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com References: <20240529095206.2568162-1-yi.zhang@huaweicloud.com> From: Zhang Yi Message-ID: Date: Sat, 1 Jun 2024 15:38:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgAXPA_9z1pmSDx2Og--.13740S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYI7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7 xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40E FcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr 0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY 04v7Mxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIx AIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0D MIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCT nIWIevJa73UjIFyTuYvjxUrR6zUUUUU X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ On 2024/5/31 20:26, Christoph Hellwig wrote: > Procedural question before I get into the actual review: given we > are close to -rc3 and there is no user of the iomap change yet, > should we revert that for 6.10 and instead try again in 6.11 when > the XFS bits are sorted out? > Okay, fine, it looks we still need some time to fix this issue. I will send out a patch to revert the commit '943bc0882ceb ("iomap: don't increase i_size if it's not a write operation")' soon, other commits in my previous series looks harmless, so I think we can keep them. Thanks, Yi.