Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp914162lqh; Sat, 1 Jun 2024 01:22:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVrFULw2udp74OqpkS47fk9tKJ2YQZ9uQsUxK9/0EGtN+ENJcsPjaBG99e13ZzPqKBbx56MAlylGaro9bTJHRDc2b0wHlqbtkxJA21TYA== X-Google-Smtp-Source: AGHT+IGbFYz2Zc3fIplpPElum0qUBrA5ThZOhPc4Cfwr0sVMc6KiRBJTuLAps5IcU0ds45JMcB+a X-Received: by 2002:a05:6808:23d0:b0:3c9:9517:e0ab with SMTP id 5614622812f47-3d1e35ad398mr4685660b6e.32.1717230179718; Sat, 01 Jun 2024 01:22:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717230179; cv=pass; d=google.com; s=arc-20160816; b=wk/8HwgxkNGRWyMmVIgPpSHN2U6fHViZOc3G6Kbwy5bb1OD2zqsu0AD21kNkiKSdDj 7iUIGZ2tOx/Q8t/6MywubxymI+CDTZO1y1kYEKvAlIUxEqA7H/OT8gyS5e9oBXfiZys9 IuRPBzT6UCksJeXixMGkrUTyfQ7gKC5gJL0Vyfq5diBSI3ZjkJTNfW9TmLnwJEq0k9Mq gSpiSUdilOCfeKzLUcZTMmeUThmtst6LIoMDermHHxp7tsNmdxVbKGBNHe+z6PtIOIhM gstazxMRmvF2FAOls7Z8jNfuSLkAczcrGqxSxGEL0Dt0odQw8U5A+i3xPhUkF1iZUfvM zvBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jS1REURsJwdpdN5qZlAkMeb3M46ky2o7iPE7GdwDXpU=; fh=svGeVQJdzHeb5yuWtZEDCgDf3L17oEPRb1S1Nt+DIvM=; b=d1IhZnOhq3ZRuLfb2pZjFmjYKsV6yB0+czyDoxA18G2RZ2znBa2yJSrMHXtoQiGGIQ YGsPh/9Z4G8mK7dDC79BdnR2psKm+sI3cr4T8ystPHP2+UUA5QbCPVaqZ5Q1IJ6xgmAQ tbu/pwiB/jNc787uOO2KYrLOLKUDMNqFbz8JaafzQXUW/FspTVVvpaj7WDCRGCpc+Ds5 kPS15iNuGa9sV3v5xXFK3zqaWQvvJ9wPPtKzME7pMddU8VntvP8bccbhaO1MkCYOvi87 7DntNdJ4etGRbRql2WU+QNHCEfOj2kS7pNuANftqBrlndS2nZb/Sx6UlCWOjOHEVk1M6 46eg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ovsoJpri; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-197765-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197765-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-70242c2747asi2923106b3a.232.2024.06.01.01.22.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 01:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-197765-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ovsoJpri; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-197765-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-197765-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 03AAA2860B3 for ; Sat, 1 Jun 2024 08:22:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 740BD22F08; Sat, 1 Jun 2024 08:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ovsoJpri" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED0E208C4; Sat, 1 Jun 2024 08:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717230158; cv=none; b=mrPbpaek6j7cH9YUXWEkmUkU2zn1ZJeyEOIZGl6mHOEZrKcihJJ2ET5NY7j0ReAsmcqGYFYZ6kg+HSPIszp+wT6EMJYcAITCeNWU+yWUSkQXH9NrBVvsYXYKH1PBptTsznNVAZtPLoh+9eDyP3hbbV6ekUTK0xxe8iUjTfYDAOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717230158; c=relaxed/simple; bh=JLVzQUB0aSZj9RaOqI41nLym0rfT53TOTj5bWG0vSNw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R9Ucri+IRs2MPepP2sb+GjspFRyfxInC7lZ3eCYq/BDGId3dfNxdMBh2bgSua0ASLNIyg5qkFTS7saaFneRs1/7HcL5/8Dr7adumvRpnkgRnVKWxx0Uah0f0URhs7J3yYEY5EpaMlAcKhy8hfdLf74P6r//u28OpsJYIpi2hhK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ovsoJpri; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BD07C116B1; Sat, 1 Jun 2024 08:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717230158; bh=JLVzQUB0aSZj9RaOqI41nLym0rfT53TOTj5bWG0vSNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ovsoJpri7gU/jksFE4nBfQJPMM9cquPrHOK4BrW+iOeh4K4BfiASUijafHNOFrTT2 pzd2LwHNqWAD3h+H4QPjVPGGarGS0EccXBgL2/qXatcpzikdwLlD0lhQMA1PCaD5Ax rmfeOVxUzzAGlEk7SElpYJxH9ajoSPY+SpbxLyP+AXB+tq9t/sTX6hCVm+b70b4Vsw AKbhN34DS0eOyclUdPdvI8C5f2wIZR4zBLtHuQ5zz6LWdARTgHCgzTEbstEkTI1UBo qysivvmVgwVucs+Ss9ZrGTMzrd/5aj5UeV7H3cSD3kOMhXVwIfMEVUBKDin1Rb6iMv G19ibKu13KA2Q== Date: Sat, 1 Jun 2024 09:22:33 +0100 From: Simon Horman To: Julian Anastasov Cc: Ismael Luceno , linux-kernel@vger.kernel.org, Pablo Neira Ayuso , Michal =?utf-8?Q?Kube=C4=8Dek?= , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] ipvs: Avoid unnecessary calls to skb_is_gso_sctp Message-ID: <20240601082233.GW491852@kernel.org> References: <20240523165445.24016-1-iluceno@suse.de> <16cacbcd-2f4c-1dc1-ecf7-8c081c84c6aa@ssi.bg> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16cacbcd-2f4c-1dc1-ecf7-8c081c84c6aa@ssi.bg> On Mon, May 27, 2024 at 08:59:37PM +0300, Julian Anastasov wrote: > > Hello, > > On Thu, 23 May 2024, Ismael Luceno wrote: > > > In the context of the SCTP SNAT/DNAT handler, these calls can only > > return true. > > > > Ref: e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets") > > checkpatch.pl prefers to see the "commit" word: > > Ref: commit e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets") > > > Signed-off-by: Ismael Luceno > > Looks good to me for nf-next, thanks! > > Acked-by: Julian Anastasov Likewise, looks good to me. Acked-by: Simon Horman ...