Received-SPF: pass (google.com: domain of linux-kernel+bounces-196874-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\))
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature
 sensors
From: =?utf-8?Q?Ren=C3=A9_Rebe?= <rene@exactcode.de>
In-Reply-To: <ea135424-841c-4a5a-b881-a3295d87b64a@roeck-us.net>
Date: Fri, 31 May 2024 15:20:38 +0200
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
 =?utf-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>,
 linux-hwmon@vger.kernel.org,
 Hristo Venev <hristo@venev.name>,
 Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,
 devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Radu Sabau <radu.sabau@analog.com>,
 Paul Menzel <pmenzel@molgen.mpg.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <151934EE-F826-4655-BEF1-2199B1AAAD5C@exactcode.de>
References: <20240529205204.81208-1-linux@roeck-us.net>
 <20240529205204.81208-3-linux@roeck-us.net>
 <34a4292e-c4db-4b40-822e-b892e1444045@t-8ch.de>
 <16e448f1-cfc9-4e88-b3f1-55e1856d1405@roeck-us.net>
 <0a2ed64d-06d9-45e8-a054-4ded4429f952@t-8ch.de>
 <ffd72953-ecd2-405a-ad6d-236143b26946@roeck-us.net>
 <20240531093154.rna2vwbfx7csu2sj@ninjato>
 <BA0B79E0-6582-45EA-8EA9-35E278B8CC42@exactcode.de>
 <ea135424-841c-4a5a-b881-a3295d87b64a@roeck-us.net>
To: Guenter Roeck <linux@roeck-us.net>

Hi,

> On May 31, 2024, at 15:14, Guenter Roeck <linux@roeck-us.net> wrote:
>=20
> Hi Ren=C3=A9,
>=20
> On 5/31/24 03:01, Ren=C3=A9 Rebe wrote:
>> Hi,
>> On May 31, 2024, at 11:31, Wolfram Sang =
<wsa+renesas@sang-engineering.com> wrote:
>>>=20
>>> Hi all,
>>>=20
>>>>> Wolfgang seems to think it's important:
>>>=20
>>> Wolfram, please.
>>>=20
>>>>> =
https://lore.kernel.org/lkml/tdia472d4pow2osabef24y2ujkkquplfajxmmtk5pnxll=
sdxsz@wxzynz7llasr/
>>>>>=20
>>>>=20
>>>> Ok, but that doesn't explain the reason. Wolfram, Paul, why do you
>>>> think this is needed ? Note that I am not opposed to adding spd
>>>> eeprom support, but I'd like to know why I am doing it before
>>>> I spend time on it.
>>>=20
>>> A working eeprom driver is needed to get 'decode-dimms' from the
>>> i2c-tools package working. Jean reported that EEPROM access for DDR5 =
is
>>> different from DDR4, so it needs a separate driver. And
>>> i2c_register_spd() then needs to be updated to use the new driver =
for
>>> DDR5.
>> Well my original downstream driver already had eeprom access:
>> https://svn.exactcode.de/t2/trunk/package/kernel/linux/spd-5118.patch
>=20
> Yes, but you didn't send it upstream, so I took it, fixed a couple of =
bugs,

And I appreciate that!

> dropped eeprom support since that is secondary for my use case as well =
as the

I only said the original code had this implemented if someone wants to =
re-add it
to save them some time not having to re-write it from scratch ;-)

> out-of-tree parity code, and submitted it. I'd be more than happy to =
let you
> take over if you like.

I=E2=80=99m mostly out of time, so I appreciate you starting the =
upstream process.

Thank you so much,
	Ren=C3=A9

--=20
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com