Received-SPF: pass (google.com: domain of linux-kernel+bounces-197883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 1 Jun 2024 16:02:25 +0200
From: Erick Archer <erick.archer@outlook.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Xin Long <lucien.xin@gmail.com>, Kees Cook <keescook@chromium.org>,
	"Gustavo A. R.  Silva" <gustavoars@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>
Cc: Erick Archer <erick.archer@outlook.com>, linux-sctp@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] sctp: annotate struct sctp_assoc_ids with __counted_by()
Message-ID:
 <AS8PR02MB72376F105A5EBEE013FCAB1C8BFD2@AS8PR02MB7237.eurprd02.prod.outlook.com>
References: <AS8PR02MB723728DA244A82D97342D6498B192@AS8PR02MB7237.eurprd02.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS8PR02MB723728DA244A82D97342D6498B192@AS8PR02MB7237.eurprd02.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8PR02MB7237:EE_|PAVPR02MB9158:EE_
X-MS-Office365-Filtering-Correlation-Id: 33adef7b-4d43-4997-6561-08dc82437f57
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|3412199016|440099019|1710799017;
X-Microsoft-Antispam-Message-Info:
	XDkVQfbp2eyrep/R5nahPH/JIlEN7h3EYzd4UKlXFRAa0HVdm/1YMWJhGFLNlJhzOiHv2Y+Eikff9GwvwMgb3h11C8WbOHJqKm87On85+H/SLxI8NPASdLQyhIKCiR3xvjx3dSrS0cChW5zfqONmFFGG5dtIuPesxPKBWcnPz3EnkXysGAopzdmR/y0cfiDlnl5VqnfqJfWRUnf38vzq7riEMR/5xXRbXUwkLyaCwxrOcrMMNB6HR04aj2fPtUxhyC4SIPIiYPGbx2c2WE4JRcLbmJRZIWrvvBqdC5YjVEsqgrhz+YpCuekU7cgsc0NIX7SjzvchlHHCkIs3LGFbMmpKmnvvVqjb/7E9xGf/UCeN5LEVebyM44kBxBZ5DQcC6cGDvjPGp0qSDRf9l/5QtWtCSylgSP85gInRUkRnjb/HTJ/awNCAgajNca3eeTuIIpxTwkk+KL7NHlBW8zgiWW5e0TuT5tKccgcg9DlbR929vyW37ILxL8RtceQcQQrVYDJtWnqG40w50y0SjwAzLiEPDGHGdhPzCDd4MtuCqZw0coouKB29B+jwWVhyVGguiKBb1exAMxAI1zQsnAcTlI22kj+WBcKgrc+HL0P10mC3Zm48d7pEtS1Fgtq0BrO0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SEjIsGJQ16OVSzMYgaYxJ9MBJzSTDJsUHjA7TDKcxA2iPEFAjUY+JKWjkqQo?=
 =?us-ascii?Q?KfLSTGYxw8OtRfmRr0a+vu1qvD1DaUpdSVzEyJD2eQpha/PzM32I43IoWR/O?=
 =?us-ascii?Q?D5lYJ0pu2tzZL9s/WMsyuWtt2PU9hlIsdba462tks6PljQ7ShR45WeKQ6ch+?=
 =?us-ascii?Q?4bOxVA3M4Q6dQ6dA9+nz8Gx+3/VBuKO4t0Q8BAJi8cdAz0e8a+j9anf9jgXM?=
 =?us-ascii?Q?ihkZSbdthPpEeo4GVRAA6w2Kkxnn8suSwzu5F9kbELiqB8Xo1GwmvqTCymWe?=
 =?us-ascii?Q?K+XVji62pLdN6WYk3qNq9cNW9HjtV4Xt7ZEEPG8L1/QHT3vKB1+VgCSsRTB2?=
 =?us-ascii?Q?fjioUVXOFw7nkQfY9RZsJQeNQUUj5sgIz2mLZxhvZ7eLXv/WC4+1vqd5sP7q?=
 =?us-ascii?Q?lGSX9DihZ2rnzXw/qhCaBl4PZ87WYYBJlxTr6NAT/xwxyJmgcKlwR3OuLPcc?=
 =?us-ascii?Q?oo17cvFxyPwNLmNItNZHug5m4M/E7Un6f31neYSAOM/esm1f6toxmFLPcUKD?=
 =?us-ascii?Q?d1lPT23HFcKhkhhoeHL0MB0EY98lFqmSwNH3xM28fEDDJ+1W9CfR9oE6NP0t?=
 =?us-ascii?Q?6iwPdeAETJuGSEdQ/FG2pJsaGLMXReq4qpn/tEXT7jXnz+NBSW/O1tx7WCse?=
 =?us-ascii?Q?BnxFFfSoDR9Vlqyvj/AUwVDuims5oorfgxVVhtQ73mK3Zai48v+WOspypHZS?=
 =?us-ascii?Q?LPdSLl44L55QKnojlbKF1KKqOvr2ajcgUwaXCvbXcGMzvA2KXBdhNuBRoBQ2?=
 =?us-ascii?Q?OZLZANvjdraw/HHcinTOiYkNC1OIO7brSHW5+qvKGuQ8KEZ05Z5Qc/S7Fh4F?=
 =?us-ascii?Q?hm1T/dyfX1H5DqeAOEKOqf8FXRpcuUE1U8BC+/PF4D3Os0MXTxFk8z7oGacU?=
 =?us-ascii?Q?q4R+Xq5ZMNN3AzCtP2NAK2VLFBMKZenCZ/qospGqED6vsrL6HFOiJzRs7Yi7?=
 =?us-ascii?Q?+cDtdwftYQnWeWNMEvnPWlqE1rf3vwvwoeX3o4h6gEGFnHZApD+X2hk9HPxv?=
 =?us-ascii?Q?62UuRZf86eA6xcNT1nBrauQJgqx7sadHwyGr65tti+O2W7lKefTz0fwOLlSi?=
 =?us-ascii?Q?bU0cMo1+HHvnLeiyEU12zmsHOLDcm5YwTSQcJ0/cd5DqlpQe3NJi6Diwmi+R?=
 =?us-ascii?Q?CbDfDX7PRhA6oekJM6rdkBL32rYE8F0kGmHcMI7y6Wa/6QfygpLTjUmYrxU4?=
 =?us-ascii?Q?uOYeUxPQu+a29fsKhJgz6d7G4Hp94GhcmKXARGpEunpnkfjJ0uo0ABZ6jwkP?=
 =?us-ascii?Q?lwHbkxoNHuRrgu4gQt3Y?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33adef7b-4d43-4997-6561-08dc82437f57
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB7237.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2024 14:02:39.3152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB9158

Hi,

On Wed, May 01, 2024 at 07:01:22PM +0200, Erick Archer wrote:
> Prepare for the coming implementation by GCC and Clang of the
> __counted_by attribute. Flexible array members annotated with
> __counted_by can have their accesses bounds-checked at run-time via
> CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE
> (for strcpy/memcpy-family functions).
> 
> Suggested-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Erick Archer <erick.archer@outlook.com>
> ---
>  include/uapi/linux/sctp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h
> index b7d91d4cf0db..836173e73401 100644
> --- a/include/uapi/linux/sctp.h
> +++ b/include/uapi/linux/sctp.h
> @@ -1007,7 +1007,7 @@ enum sctp_sstat_state {
>   */
>  struct sctp_assoc_ids {
>  	__u32		gaids_number_of_ids;
> -	sctp_assoc_t	gaids_assoc_id[];
> +	sctp_assoc_t	gaids_assoc_id[] __counted_by(gaids_number_of_ids);
>  };
>  
>  /*

Friendly ping: who can take this, please?

Regards,
Erick