Received-SPF: pass (google.com: domain of linux-kernel+bounces-197896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Sat, 1 Jun 2024 16:45:10 +0200
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: ast@kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] bpf: plug a warn about bpf_session_cookie without
 CONFIG_FPROBE
Message-ID: <Zlsz9pTiT2Ad04i6@krava>
References: <20240601133224.674784-1-mjguzik@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240601133224.674784-1-mjguzik@gmail.com>

On Sat, Jun 01, 2024 at 03:32:23PM +0200, Mateusz Guzik wrote:
> Building a kernel without said option results in:
> WARN: resolve_btfids: unresolved symbol bpf_session_cookie
> 
> This is a bare-minimum patch to sort it out.
> 
> There are other uses of the bpf_session_cookie thing spread out
> thorought the file, they don't seem to break anything though.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
> ---
> 
> I don't care how this gets addressed, I just want the warning gone.
> So I am not going to fight any ideas how to do it, as long as it gets
> done.

it's fixed by:
  https://lore.kernel.org/bpf/20240531194500.2967187-1-jolsa@kernel.org/

thanks,
jirka

> 
>  kernel/bpf/verifier.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 48f3a9acdef3..b081bdd6f477 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -11128,7 +11128,9 @@ BTF_ID(func, bpf_iter_css_task_new)
>  #else
>  BTF_ID_UNUSED
>  #endif
> +#ifdef CONFIG_FPROBES
>  BTF_ID(func, bpf_session_cookie)
> +#endif
>  
>  static bool is_kfunc_ret_null(struct bpf_kfunc_call_arg_meta *meta)
>  {
> -- 
> 2.39.2
> 
>