Received-SPF: pass (google.com: domain of linux-kernel+bounces-197985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sat, 1 Jun 2024 19:51:22 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Dumitru Ceclan via B4 Relay
 <devnull+dumitru.ceclan.analog.com@kernel.org>
Cc: dumitru.ceclan@analog.com, Lars-Peter Clausen <lars@metafoo.de>, Michael
 Hennerich <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, David Lechner <dlechner@baylibre.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Dumitru Ceclan <mitrutzceclan@gmail.com>,
 Nuno Sa <nuno.sa@analog.com>
Subject: Re: [PATCH v4 4/6] iio: adc: ad7173: add support for special inputs
Message-ID: <20240601195122.5e6ffeba@jic23-huawei>
In-Reply-To: <20240531-ad4111-v4-4-64607301c057@analog.com>
References: <20240531-ad4111-v4-0-64607301c057@analog.com>
	<20240531-ad4111-v4-4-64607301c057@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 31 May 2024 22:42:30 +0300
Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org> =
wrote:

> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
>  Add support for selecting REF+ and REF- inputs on all models.
>  Add support for selecting ((AVDD1 =E2=88=92 AVSS)/5) inputs
>   on supported models.
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
Random passing comment inline. This looks fine to me.
> ---
>  drivers/iio/adc/ad7173.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index a20831d99aa5..ebfd2d5f9632 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -66,6 +66,10 @@
>  	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
>  #define AD7173_AIN_TEMP_POS	17
>  #define AD7173_AIN_TEMP_NEG	18
> +#define AD7173_AIN_COM_IN_POS	19
> +#define AD7173_AIN_COM_IN_NEG	20
> +#define AD7173_AIN_REF_POS	21
> +#define AD7173_AIN_REF_NEG	22
> =20
>  #define AD7172_2_ID			0x00d0
>  #define AD7175_ID			0x0cd0
> @@ -146,6 +150,8 @@ struct ad7173_device_info {
>  	unsigned int id;
>  	char *name;
>  	bool has_temp;
> +	/* ((AVDD1 =E2=88=92 AVSS)/5) */
> +	bool has_common_input;
>  	bool has_input_buf;
>  	bool has_int_ref;
>  	bool has_ref2;
> @@ -216,6 +222,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {
>  		.has_temp =3D true,
>  		.has_input_buf =3D true,
>  		.has_int_ref =3D true,
> +		.has_common_input =3D true,

This is another good reason for breaking up this array (as suggested in v3 =
review
but perhaps a job for another patch set!)
If you break it up we can see which entry each of these actually is in the =
diff
rather than having to use line count to figure it out!

>  		.clock =3D 2 * HZ_PER_MHZ,
>  		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
>  		.num_sinc5_data_rates =3D ARRAY_SIZE(ad7173_sinc5_data_rates),
> @@ -230,6 +237,7 @@ static const struct ad7173_device_info ad7173_device_=
info[] =3D {