Received-SPF: pass (google.com: domain of linux-kernel+bounces-197988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <542eb99a-8299-4673-be52-d9632b923c33@gmx.de>
Date: Sat, 1 Jun 2024 21:17:41 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFT v3 3/4] hwmon: (spd5118) Add suspend/resume support
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, linux-kernel@vger.kernel.org,
 =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 =?UTF-8?Q?Ren=C3=A9_Rebe?= <rene@exactcode.de>,
 Wolfram Sang <wsa+renesas@sang-engineering.com>
References: <20240531230556.1409532-1-linux@roeck-us.net>
 <20240531230556.1409532-4-linux@roeck-us.net>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240531230556.1409532-4-linux@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:8WRd7BSGgbE=;bCpJDtj7FFVFSV4S8yUjiu/Qsp6
 GQyj85n45817/RU5Oj4FRTBKrXWABEUyK5ynY/EnOrAj3QWDPCDzanOYIdgMlq/DXMte4/9cO
 H/iggENSoRxJ15ltZhG5L6OOnNo8hTQ+l1UkLnuE5LcX5iM03hwLcRfThRyo9y+A8TKdAREVh
 ZfKeqXRbq/tbTnUZ1bwFUlG1svc3k0mMZfwqzCTGbE5v8SiMcgMu46WR2pjS6cSpSxmOkF7Qe
 2mN75gjICisJdoWMN1qvVajFyyxQJw4vWQM49UpBa/zV2B0zrx3Kao9U23KQYgNZ5qZ5VBTZV
 f6XCS0LkO9CIS+CIzqQTOz64Zvy9/cEMakDXHGrGuOi6Br63VaksSErZWOnGRteDV4bqALXBB
 7SuuJlbrKcEyAVOfaP6FC4SDi/7CIdivDrvdlw5YGYarI+p7sxC6mgRjpOWMNsS5TWyWsI/7Q
 G4dcipnZIgFGMGYjOI+6nLlFyK1KGFButkeVY2QeHxgAfRjhk2ELRCLb8eyIBnEUBhIwLiUeQ
 7niWzWhvOo5Qq65AC3n4qUPl+hlD8WgrSmS9d9sqZQr2fQShZoi+6gmEV12oJ0hlQmme/cunG
 +Cmy88lqlkRF7ZkO/OoRc7mt57Ur75YvEXS8sxprUtl8HsLCxcIFVkWxFRPc89zAKSs9j8Yf9
 s4a4ttCHj85TZLrDCF4oiZPydScOYoXxOINtNmJpUlsRdozqXPW7i1qCYRvGq7P/hqRVIt055
 qQLK2hqYY0YJpoCOwrhanwDDcBpN0j+MRfQ7YZu+2zX6vwZ3wbe/ysOqCP6PH7sK0h3y2CVaA
 UoNuGppIC8VovAndGCUWOeY5+ZINiog7uMSNd60gcPvZ0=

Am 01.06.24 um 01:05 schrieb Guenter Roeck:

> Add suspend/resume support to ensure that limit and configuration
> registers are updated and synchronized after a suspend/resume cycle.

Hi,

it seems that 6.10.0-rc1 cannot suspend/resume on my machine. Kernel 6.9.1=
 however
can successfully enter and leave S3 and S4, so i tested the driver on this=
 kernel
version.

In both cases, the driver was successfully preserving the settings, so:

Tested-by: Armin Wolf <W_Armin@gmx.de>

> Cc: Armin Wolf <W_Armin@gmx.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v3: No change
>
> v2: New patch
>
> RFT: I tested the patch through a suspend/resume cycle, and it seems
>       to work, but I am not sure if that had any effect because,
>       after all, the memory is still active during suspend/resume.
>       I was unable to test a hibernation cycle with my system.
>
>   drivers/hwmon/spd5118.c | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
>
> diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
> index d3fc0ae17743..baa315172298 100644
> --- a/drivers/hwmon/spd5118.c
> +++ b/drivers/hwmon/spd5118.c
> @@ -20,6 +20,7 @@
>   #include <linux/i2c.h>
>   #include <linux/hwmon.h>
>   #include <linux/module.h>
> +#include <linux/pm.h>
>   #include <linux/regmap.h>
>   #include <linux/units.h>
>
> @@ -432,6 +433,8 @@ static int spd5118_probe(struct i2c_client *client)
>   	if (!spd5118_vendor_valid(bank, vendor))
>   		return -ENODEV;
>
> +	dev_set_drvdata(dev, regmap);
> +
>   	hwmon_dev =3D devm_hwmon_device_register_with_info(dev, "spd5118",
>   							 regmap, &spd5118_chip_info,
>   							 NULL);
> @@ -449,6 +452,31 @@ static int spd5118_probe(struct i2c_client *client)
>   	return 0;
>   }
>
> +static int spd5118_suspend(struct device *dev)
> +{
> +	struct regmap *regmap =3D dev_get_drvdata(dev);
> +
> +	regcache_cache_bypass(regmap, true);
> +	regmap_update_bits(regmap, SPD5118_REG_TEMP_CONFIG, SPD5118_TS_DISABLE=
,
> +			   SPD5118_TS_DISABLE);
> +	regcache_cache_bypass(regmap, false);
> +
> +	regcache_cache_only(regmap, true);
> +	regcache_mark_dirty(regmap);
> +
> +	return 0;
> +}
> +
> +static int spd5118_resume(struct device *dev)
> +{
> +	struct regmap *regmap =3D dev_get_drvdata(dev);
> +
> +	regcache_cache_only(regmap, false);
> +	return regcache_sync(regmap);
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(spd5118_pm_ops, spd5118_suspend, spd511=
8_resume);
> +
>   static const struct i2c_device_id spd5118_id[] =3D {
>   	{ "spd5118", 0 },
>   	{ }
> @@ -466,6 +494,7 @@ static struct i2c_driver spd5118_driver =3D {
>   	.driver =3D {
>   		.name	=3D "spd5118",
>   		.of_match_table =3D spd5118_of_ids,
> +		.pm =3D pm_sleep_ptr(&spd5118_pm_ops),
>   	},
>   	.probe		=3D spd5118_probe,
>   	.id_table	=3D spd5118_id,