Received-SPF: pass (google.com: domain of linux-kernel+bounces-198015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 1 Jun 2024 22:59:29 +0100
From: Phillip Potter <phil@philpotter.co.uk>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Phillip Potter <phil@philpotter.co.uk>, Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] cdrom: Add missing MODULE_DESCRIPTION()
Message-ID: <ZluYQbvrJkRlhnJC@KernelVM>
References: <20240530-cdrom-v1-1-51579c5c240a@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240530-cdrom-v1-1-51579c5c240a@quicinc.com>

On Thu, May 30, 2024 at 08:23:34PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
> 
> Add the missing MODULE_DESCRIPTION() macro invocation.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/cdrom/cdrom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 20c90ebb3a3f..b6ee9ae36653 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
>  
>  module_init(cdrom_init);
>  module_exit(cdrom_exit);
> +MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-cdrom-543cdcf21da4
> 

Hi Jeff,

Thank you for the patch, looks good to me. I will send on for inclusion.

Reviewed-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil