Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp212731lqj; Sat, 1 Jun 2024 15:42:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVOfr8KvfvImuH+r/n4wwkpfH2bFh/cYIuiWb4UL34rk6OQ/GtSvg2kiNqBr1jNhWR8mK6tkOTnYjcXxeuZ/HVXHkH0k6V9Ju+flLigAw== X-Google-Smtp-Source: AGHT+IEokoNjcOkRK5b7NC6aTS4zm3BQuwZhI+S9NWp3AZS7l2c4050L9xmEru0gXpNxiiKsm3de X-Received: by 2002:a17:906:585b:b0:a5a:15b6:413d with SMTP id a640c23a62f3a-a6822348380mr400471066b.69.1717281745452; Sat, 01 Jun 2024 15:42:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717281745; cv=pass; d=google.com; s=arc-20160816; b=NC6DrMa2+M97h4gZOJuiFieLRX0gOgqCFPajeRkUk8Wt/xk7Q694jwGzCSWahHRxpl d2oHRKBYw13m1t096CzKk/YjL8n3hRPT8Ior0G63rHitxtqJFzUBNW0CS/rRArigLt2P Ddu4c0RoRgZUrKBAeJbrQWQMLioXIA1eQXHyIIG8idOavjN/sY/6u9BFuryjOKiNPkmg kHTeiBjUoLTCmEysx5uJD7njuN8oTK+EkCy+dJg9t1kgfv56/luzJcYazONzFivdwpdM DGGGA4LcptFT9iZjhi/omKNywj9fXl66acdI0SFBm3RmL+Tem571PVepT6Bx6eDytHZh h9Gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=BFoud8CqOjmO58Mxnq1h0r8rL7akdxghE8ALcOZ9ENQ=; fh=KTkeaxP9G7hoepwW5uAO5Jlux7eVS5TwSc933QBFHx0=; b=0vvnUAfpESXFSLLoiT0PyPTpj7yioGBsgwqBsrIDJ+VbsN7nOIXO+vx2xo7WWYQHcB tUHRRX5oupOl7rwNfYdiF7ertLgwLm7Upk/GSCs/gLWAQnzDSvSuxuaayJLbc/tmAns5 xeZ2jvsiF9iddrXyOPU3wQJXW5JhErV1hw0jDVGhrLkJfGYrtmK58BXGLVy6hlqH6cGW eGbPZNR0iJE5VswKnEoA2F1lahrPZJsJUgKMbA1SmP9iiOgJPIrB18CIDes77DhoU/mO dmx1kop1hf8VVp03SZcdldZc10ThTBR+5y6hSSxVqGE0owFbT7olAjHr9u/KOaPFOQxo YQqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dwjxzfg4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a67eaf65116si248712066b.860.2024.06.01.15.42.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 15:42:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dwjxzfg4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 306991F219C7 for ; Sat, 1 Jun 2024 22:42:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB3E3364A4; Sat, 1 Jun 2024 22:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dwjxzfg4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CE09B657; Sat, 1 Jun 2024 22:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717281736; cv=none; b=acewAfsUp4khCDQZMGx6VHRfuY/wAIozSpe+o+gQqEogS5hK9BvJkzMxMX+aU0Lq8YB47qAaHTk+wVL5avJeqe3WT/ggvd2tPIwbJ01whTnUeHwaiZZ7u4sfq+z1iY04TZiGexICYiI6txzY4HbwIyGrfh5ljJ1Ov2UFaMnHeD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717281736; c=relaxed/simple; bh=VXcYJY/8RPuKEhVc9Wqew0vicKGpKsnPJEECmXGSwdY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HL31j6BT8j4zr9SkuD6qdwLxEVszaRNIRY89l0LkfllLFGm4+wvLRXvzbtMeCwbn2mCutwWT1HUpQaBENQ1PSKS4HiC91mPPD1fe0EBvkjtwObHmi92RAOZTKaI4uK/PKJLAtFyfQ2RwxS4FRXd5oMj7nz3AruWhFJzygNlPpuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dwjxzfg4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9148C116B1; Sat, 1 Jun 2024 22:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717281735; bh=VXcYJY/8RPuKEhVc9Wqew0vicKGpKsnPJEECmXGSwdY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dwjxzfg4ZbT0Wh+4UG3lMf80ORi9fffALl2kgiT3nsz5geBq+OqkZ81Oiyhi0hK1c iduohA9e/lJx69kwzZEKFmlBYWxh4PU0NnESJ8vx1fF0WlNFEky7utfsDY07UnaKIp Hj7ewf3LRpkjXm+PgcR4UirM1EMsdNO4FQx+q+CqhXpJJ5IPJ9bKc2MXJUWuT5cICh mSYY81dR35NWLxxi2NjR3bAzTpmNnMRsPIaJOGOMz8xM/Gf0SPGGZ+ocG1bFxy9QwO PxwxwpksCIRrUmI3IgXG4xN/S+rrknaw4dIJr1k283I7N+k3gsmdAzJulwO+DgVDdP XTNDLetTycaaQ== Date: Sat, 1 Jun 2024 15:42:13 -0700 From: Jakub Kicinski To: Simon Horman Cc: Thorsten Blum , Nicolas Pitre , "David S. Miller" , Eric Dumazet , Paolo Abeni , Breno Leitao , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , John Paul Adrian Glaubitz , Andrew Lunn , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: smc91x: Refactor SMC_* macros Message-ID: <20240601154213.7274767f@kernel.org> In-Reply-To: <20240601165342.GS491852@kernel.org> References: <20240531120103.565490-2-thorsten.blum@toblux.com> <20240601165342.GS491852@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 1 Jun 2024 17:53:42 +0100 Simon Horman wrote: > > drivers/net/ethernet/smsc/smc91x.c | 132 +++++++++++-------------- > > drivers/net/ethernet/smsc/smc91x.h | 152 ++++++++++++++--------------- > > 2 files changed, 131 insertions(+), 153 deletions(-) > > This is a large and repetitive patch, which makes it hard to spot any errors > (I couldn't see any :) +1 While the spirit of the patch is right, I don't think we should encouraging refactoring of ancient drivers. It's not a great use of anyone's time.