Received-SPF: pass (google.com: domain of linux-kernel+bounces-198040-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240518114051.18125-3-shresthprasad7@gmail.com>
In-Reply-To: <20240518114051.18125-3-shresthprasad7@gmail.com>
From: Shresth Prasad <shresthprasad7@gmail.com>
Date: Sun, 2 Jun 2024 04:53:28 +0530
Message-ID: <CAE8VWiLT-bdRfs0DExVOxjG-tNRSBnkZ7KbDX+5bT_d9bkr9hg@mail.gmail.com>
Subject: Re: [PATCH v3][next] tty: sunsu: Simplify device_node cleanup by
 using __free
To: davem@davemloft.net, gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-serial@vger.kernel.org, Julia Lawall <julia.lawall@inria.fr>, 
	Javier Carrasco <javier.carrasco.cruz@gmail.com>, Shuah Khan <skhan@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 18, 2024 at 5:11=E2=80=AFPM Shresth Prasad <shresthprasad7@gmai=
l.com> wrote:
>
> Add `__free` function attribute to `ap` and `match` pointer
> initialisations which ensure that the pointers are freed as soon as they
> go out of scope, thus removing the need to manually free them using
> `of_node_put`.
>
> This also removes the need for the `goto` statement and the `rc`
> variable.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> ---
> Changes in v3:
>     - Remove incorrect testing statement
>
> I've tested the patch by cross compiling it for sparc systems and
> booting the produced `image` file in `qemu-system-sparc`.
>
> ---
>  drivers/tty/serial/sunsu.c | 37 +++++++++++--------------------------
>  1 file changed, 11 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/tty/serial/sunsu.c b/drivers/tty/serial/sunsu.c
> index 67a5fc70bb4b..0f463da5e7ce 100644
> --- a/drivers/tty/serial/sunsu.c
> +++ b/drivers/tty/serial/sunsu.c
> @@ -1382,44 +1382,29 @@ static inline struct console *SUNSU_CONSOLE(void)
>
>  static enum su_type su_get_type(struct device_node *dp)
>  {
> -       struct device_node *ap =3D of_find_node_by_path("/aliases");
> -       enum su_type rc =3D SU_PORT_PORT;
> +       struct device_node *ap __free(device_node) =3D
> +                           of_find_node_by_path("/aliases");
>
>         if (ap) {
>                 const char *keyb =3D of_get_property(ap, "keyboard", NULL=
);
>                 const char *ms =3D of_get_property(ap, "mouse", NULL);
> -               struct device_node *match;
>
>                 if (keyb) {
> -                       match =3D of_find_node_by_path(keyb);
> +                       struct device_node *match __free(device_node) =3D
> +                                           of_find_node_by_path(keyb);
>
> -                       /*
> -                        * The pointer is used as an identifier not
> -                        * as a pointer, we can drop the refcount on
> -                        * the of__node immediately after getting it.
> -                        */
> -                       of_node_put(match);
> -
> -                       if (dp =3D=3D match) {
> -                               rc =3D SU_PORT_KBD;
> -                               goto out;
> -                       }
> +                       if (dp =3D=3D match)
> +                               return SU_PORT_KBD;
>                 }
>                 if (ms) {
> -                       match =3D of_find_node_by_path(ms);
> +                       struct device_node *match __free(device_node) =3D
> +                                           of_find_node_by_path(ms);
>
> -                       of_node_put(match);
> -
> -                       if (dp =3D=3D match) {
> -                               rc =3D SU_PORT_MS;
> -                               goto out;
> -                       }
> +                       if (dp =3D=3D match)
> +                               return SU_PORT_MS;
>                 }
>         }
> -
> -out:
> -       of_node_put(ap);
> -       return rc;
> +       return SU_PORT_PORT;
>  }
>
>  static int su_probe(struct platform_device *op)
> --
> 2.44.0
>

Hi,

Any updates on this patch?

Regards,
Shresth