Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp275856lqj; Sat, 1 Jun 2024 20:01:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUQOSv4EZTAtZAYXU7K1KjCc6gOm3WrHen0t+gugMbfwVCVUTQnxiXZ/HTACzz5F1buO6wjaNUGkVCp9APANEOgyLGSa85PaokECxbEQ== X-Google-Smtp-Source: AGHT+IH+eJ2gyS1O+fVKXn4qpsmU2+G9lru5+sKwvSqRthIEVlYJNlDiYjk6epOb+g96e0TTSw7z X-Received: by 2002:a50:d65a:0:b0:57a:339c:c8d7 with SMTP id 4fb4d7f45d1cf-57a363c6e96mr3559003a12.20.1717297303835; Sat, 01 Jun 2024 20:01:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717297303; cv=pass; d=google.com; s=arc-20160816; b=qMSr0tejws/bamrsF5Jdbb67RIF2Gia3x3Oj/SWTb1cUplBJKj/nNNYGikWySDWovV zIC5qN+yfyoi/FtmJWar/x+VwJ6HPqkf0NWkN5ucOKFnLydPMxCAiDaos4oaYV3TnaXk oTTSE9+A7ys79pSVgpnfgRXhFRftjm0PjCy+zFBrdi7NDcs8+r+C3N89C9jpTE+cLfrO F3PHaaybA4EdnOA7oCJlfBmFqXnUplXR9FZQQA/0pVE7jT1lPDk+JNe0fpTGdPSKKPwP YWBV6wNrvqHHrIwQJRZb6s5gUUhFjmkMCo6QLR71Ob80SB9ROL4MwTrPGg8mb4d6odt8 6BkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=7zSGgmamTAB4j+FdSc7RiyJbKJf0nTPjLs9eK7aIMiA=; fh=kUR2JFxqpLiIDjk0qpQVDArsAHwg2Fv/6FyyqKXV1m0=; b=pKOJsRXtyc3ufNVU3As60IPfvt+QFF9fdcqJTmiRkCKVo36/jd/QHLsEvdy/OiiToO /lXVdB013rmW5BHU3kpvxKE+h4qvTzgVWEnoZ7Qce9qK55/MnqnmT1YzGdvIvrdsBYZM MIclDLO6a5n3bOiG+XoZEkZ+pUn0pTbLx3WKRFzYzneMtqyhjeUkgGHrtJdrKJpRVFGB vR3Jl3VGPfZvItdO6yq4s97y9+0AKgBXKQDgpU4BVgwpeAacRlDfxOTMWuiVZTbcSbEu QFGMaXkiH5ZewMBsXj7GnfnJv4nMzySuTe4go/gU1lODCpA1ShAFv/40AqWccu+yIxla uStA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a5FFX5TN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31c629b5si2627220a12.226.2024.06.01.20.01.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 20:01:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a5FFX5TN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198075-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 89F1A1F21532 for ; Sun, 2 Jun 2024 03:01:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44AC89445; Sun, 2 Jun 2024 03:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a5FFX5TN" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66D3028E3; Sun, 2 Jun 2024 03:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717297293; cv=none; b=uywjucs5ojkkktEiAdS2Rv39HH2JVO89SWLUhs8Zf48ei2aeAOc+nq3qvuU1QsMfIAsfwjvAy6rKzmlNT1QDjBbA6f/gvwUJftngcImF9erGNAu2ZUcIY0wi3ujjOWlNacU0ieQLpTPiW3juoPNwPqoj8wYTDZhgYl9OhNb60qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717297293; c=relaxed/simple; bh=JdO1pla7RFG+6UHfAeQ916BDviLKRzz6j8TGIcyMfZM=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=i+EgZXbfRJL4jyFvd1UO8smI484UAOLmXHdGVjnJnZsB4b5MsjU4LG2NNwQCkCzXSKopLAWdeSY0P8NG1AxYSbd1IdBWxRO13JqVySLTpjy5mhn77tVyldbP6u68n2Yli2dyvKcB+llqAqPgiUz+tkq57qRdsBjBp9y/4z0kkIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a5FFX5TN; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D261C3277B; Sun, 2 Jun 2024 03:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717297292; bh=JdO1pla7RFG+6UHfAeQ916BDviLKRzz6j8TGIcyMfZM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a5FFX5TNC2FhkIDarq92cTIX2ri7hHaT0ONJHUJYOePg3zFsOHgDvb4HbRvRaRUnP IzlSeY5xswSEltgPTdKymaesNJ5aflLRtTP60evxbCAHSTVYk+qXpRyHzInrPlm0Hy rytVtWBUbarh/3dJUc9YoZDxbuxKzmGAS5voa8Ui0dy2CYO8tAM9095fX7w7oNZO1i HqX0t4QoDEcbJoa4KGHjKcq+yLBN8WmSaDqOrfnfRS++jRrrUMvTUt5MvV+SJZBBMg RrL7/vooAQTszcN26E1JoT++g5hbjuh7uufyH1v4FRBlV7beeAVlR2wO2s4Fn0RFxc NNJtgMc0PmiVw== Date: Sun, 2 Jun 2024 12:01:26 +0900 From: Masami Hiramatsu (Google) To: Jeff Johnson Cc: Andrew Morton , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , , , Subject: Re: [PATCH] KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko Message-Id: <20240602120126.bdf79b0a209ad016f8a91a73@kernel.org> In-Reply-To: <20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com> References: <20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 1 Jun 2024 15:19:39 -0700 Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports for lib/test_*.ko: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_user_copy.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson > --- [...] > diff --git a/lib/test_kprobes.c b/lib/test_kprobes.c > index 0648f7154f5c..e707f7b3a366 100644 > --- a/lib/test_kprobes.c > +++ b/lib/test_kprobes.c > @@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = { > > kunit_test_suites(&kprobes_test_suite); > > +MODULE_DESCRIPTION("simple sanity test for *probes"); nit: Could you make it "simple sanity test for k*probes" ? because there is test_fprobe.c. Thank you, -- Masami Hiramatsu (Google)