Received-SPF: pass (google.com: domain of linux-kernel+bounces-198124-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6d5ee74605bd9574baa5ed111cb54e959414437a.camel@linux.intel.com>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update
 global.turbo_disabled after initialization
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Xi Ruoyao <xry111@xry111.site>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
  Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Date: Sat, 01 Jun 2024 21:03:18 -0700
In-Reply-To: <bf3ebf1571a4788e97daf861eb493c12d42639a3.camel@xry111.site>
References: <13494237.uLZWGnKmhe@kreacher> <8366982.T7Z3S40VBb@kreacher>
	 <bf3ebf1571a4788e97daf861eb493c12d42639a3.camel@xry111.site>
Content-Type: multipart/mixed; boundary="=-3gzlBN4siQgWAYD7n7Rk"
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

--=-3gzlBN4siQgWAYD7n7Rk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Xi,

On Sun, 2024-06-02 at 11:21 +0800, Xi Ruoyao wrote:
> On Mon, 2024-03-25 at 18:02 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >=20
> > The global.turbo_disabled is updated quite often, especially in the
> > passive mode in which case it is updated every time the scheduler
> > calls
> > into the driver.=C2=A0 However, this is generally not necessary and it
> > adds
> > MSR read overhead to scheduler code paths (and that particular MSR
> > is
> > slow to read).
> >=20
> > For this reason, make the driver read
> > MSR_IA32_MISC_ENABLE_TURBO_DISABLE
> > just once at the cpufreq driver registration time and remove all of
> > the
> > in-flight updates of global.turbo_disabled.
>=20
> Hi Rafael and Srinivas,
>=20
> Thanks for the clean up, but unfortunately on one of my laptops
> (based
> on i5-11300H) MSR_IA32_MISC_ENABLE_TURBO_DISABLE is mysteriously
> changing from 1 to 0 in about one minute after system boot.=C2=A0 I've no
> idea why this is happening (firmware is doing some stupid thing?)
>=20
> I've noticed the issue before and "hacked it around"
> (https://bugzilla.kernel.org/show_bug.cgi?id=3D218702). But after this
> change I can no longer hack it around and the system is much slower.
>=20
> Is it possible to hack it around again?
>=20
Please try the attached diff and build kernel and try.

git apply update_max_freq.diff

Then build kernel and install.

Thanks,
Srinivas

--=-3gzlBN4siQgWAYD7n7Rk
Content-Disposition: attachment; filename="update_max_freq.diff"
Content-Type: text/x-patch; name="update_max_freq.diff"; charset="UTF-8"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvY3B1ZnJlcS9pbnRlbF9wc3RhdGUuYyBiL2RyaXZlcnMvY3B1
ZnJlcS9pbnRlbF9wc3RhdGUuYwppbmRleCA0Yjk4NmMwNDQ3NDEuLmRlYWI5NmQ4ZDRiZiAxMDA2
NDQKLS0tIGEvZHJpdmVycy9jcHVmcmVxL2ludGVsX3BzdGF0ZS5jCisrKyBiL2RyaXZlcnMvY3B1
ZnJlcS9pbnRlbF9wc3RhdGUuYwpAQCAtMTE2OCw2ICsxMTY4LDEyIEBAIHN0YXRpYyB2b2lkIGlu
dGVsX3BzdGF0ZV91cGRhdGVfbGltaXRzKHVuc2lnbmVkIGludCBjcHUpCiAJaWYgKCFwb2xpY3kp
CiAJCXJldHVybjsKIAorCXByX2luZm8oIiVzIGNwdTolZFxuIiwgX19mdW5jX18sIGNwdSk7CisK
KwlnbG9iYWwudHVyYm9fZGlzYWJsZWQgPSB0dXJib19pc19kaXNhYmxlZCgpOworCWdsb2JhbC5u
b190dXJibyA9IGdsb2JhbC50dXJib19kaXNhYmxlZDsKKwlhcmNoX3NldF9tYXhfZnJlcV9yYXRp
byhnbG9iYWwudHVyYm9fZGlzYWJsZWQpOworCiAJX19pbnRlbF9wc3RhdGVfdXBkYXRlX21heF9m
cmVxKGFsbF9jcHVfZGF0YVtjcHVdLCBwb2xpY3kpOwogCiAJY3B1ZnJlcV9jcHVfcmVsZWFzZShw
b2xpY3kpOwo=


--=-3gzlBN4siQgWAYD7n7Rk--