Received-SPF: pass (google.com: domain of linux-kernel+bounces-198177-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 02 Jun 2024 10:25:01 +0100
Message-ID: <86o78jlms2.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: "harry.yu185" <harry.yu185@gmail.com>
Cc: corbet@lwn.net,
	catalin.marinas@arm.com,
	will@kernel.org,
	tglx@linutronix.de,
	linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip/gic-v3: Add Allwinner sunxi001 erratum workaround
In-Reply-To: <20240602071058.6405-1-harry.yu185@gmail.com>
References: <20240602071058.6405-1-harry.yu185@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Sun, 02 Jun 2024 08:10:58 +0100,
"harry.yu185" <harry.yu185@gmail.com> wrote:
> 
> Allwinner A523 GIC600 integration does not support the
> sharability feature. So assigned Erratum ID #sunxi001 for this
> issue.
> 
> That the 0x0201643b ID is not Allwinner specific and thus
> there is an extra of_machine_is_compatible() check.
> 
> Note, because more than one soc may have this problem, the 'sunxi'
> name is used instead of a fixed soc name like A523.
> 
> Signed-off-by: harry.yu185 <harry.yu185@gmail.com>

No, this is all already handled by the driver already (since 6.6).

Please fix your DT to include the "dma-noncoherent" property in the
GIC and ITS nodes, which should paper over the integration bug.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.