Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp373540lqj; Sun, 2 Jun 2024 02:27:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX+KMQQ/71PBbWHRp67Bjm9CLEn0itI6196DFPgsZF/1gdYtbKZFsxp7LZstKYEZ4Gu8H6vvks+/J6Og2JlZRFcZqpVp11niJrFmtgxUQ== X-Google-Smtp-Source: AGHT+IG2i0zwUhU2n0g/LwXtinh9DDGFUUCqx07trEkcOwoSOGckgRoLid54c08U+BsqIJj7rCki X-Received: by 2002:a05:6870:528:b0:250:7032:5633 with SMTP id 586e51a60fabf-2508b9b1aeamr6456251fac.14.1717320470016; Sun, 02 Jun 2024 02:27:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717320469; cv=pass; d=google.com; s=arc-20160816; b=VwjPd6km5s0psvOzejJZrhDHczqt/CcOsd9tCXBVDVz5+EVcWesU4ID1/INNqL/7vE cC3v4tvFa3ezF4OxyBnNGZ4ot3eWAN0ErnxmcDgcDB+5L288tnxAnZFa2HTq7+g3dGGO Cr2fXvs0TxCAieOslqhrJ1AmW2Jz1O/2MKHIoPdv+lpKu9Bkri9xmjZr+CAJ2I21Q+M1 pzb0rZddYpaozbokzEKZ+IamVJi48j7YGv9lnLqiPDls0PxF0V2Xacbt2dMgzVeis+Ay NCrYaNiwLlIONVp7uWhzJsPiHhnL/5Qwl7RLDK4Pw41snu4d9OKfQXB70POMAGr3zU+H zapA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=0Cy9LzvKPM2+5HVubj0oOInScmAhaoF/+D+Z2jxcef4=; fh=PeXr6QPNG2+Sw4i+fHdT/xT9k+zjK2to6GtabHVpFWk=; b=CF9IzW67hiLomF9o6QZEt5XkpUrEuZCCdWZ9JCr13bW0tOVkLDzk+AyHsqOpJLjf62 W6qNsBXVD3FMDbONB7QJOm1hey4zZAn+aUdnGTLrY9YjtyqaYl9/o2nfMWygRQmB7Q0h 05QioQjeMrHnJhxI0tBLtLfSjW7YzMflNzVhYGAmjSfvJupBgbcKAjpR9JM9CnNk3vt0 EWT6q3agZva/hzk8DMSVdeYErgONJwvrmpUP4QCdvl0l4hIiOQo14JxVq5IYNtB13EBw f0wA3gTpx3nTmT0r83QsGMTbWGbowTFOt24pggzbrmbCAVukqYqQ5+HVM1QD2Fm1OpCU jjeg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="HkHyF/+H"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-70242e67298si4549372b3a.402.2024.06.02.02.27.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 02:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="HkHyF/+H"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A80DAB21311 for ; Sun, 2 Jun 2024 09:27:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69B212D638; Sun, 2 Jun 2024 09:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkHyF/+H" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91920200C3; Sun, 2 Jun 2024 09:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717320457; cv=none; b=iXwMmdioP1izYXHi3noi4LJMt2TVqPACKro95zqNmlcJonWdDBEOf85zNGzq835U5U4e2zsN5WM5MXaXfa0pvSc8q/ZEjbabqBy3ZDIz1daL9sqRZ+XpcePHUODwXJQTgNgMQe2Rb/Sjv/Cc2oA3YWK4G1Fvq1P0ZK5PQTEn4tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717320457; c=relaxed/simple; bh=2afbsLR6VJ4RY556N27atcCW5rYmUOB/9oegyq9ivmU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bPMSDkgel8EfXvbD4ydB/QbysQWM98IcjaVp6na4oxiCrYKMg286KKWk7HAE9rA6qdOzJWZFX7EfmQmulLe8GGN/2KMuyF2TYkwXLgMWov4E2UJUZhqOukiZKktu88XmXb5y7KrGiy+/lQ2Q8WeWdqUH473AUwiNvWxQx/U4ASw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HkHyF/+H; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BD50C2BBFC; Sun, 2 Jun 2024 09:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717320457; bh=2afbsLR6VJ4RY556N27atcCW5rYmUOB/9oegyq9ivmU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HkHyF/+HhMi33iSykuQNWc5FsfkTs+xZJs8ZhTHD2fHh7biLfLYNTVBG0OYF0OyeR 0bFSlK519qRh8eK4anM5dcch/K/6qp4d9Rf//aFsvH/RAsbR7/DofAG3qUDmEaXW7b oIoU+5wYrM9/v1hH7vhM21ACGICvCM8k7GwN1OJ7aEParKJAliRQEutOTPVDjv2VtW vAKDW2K6ZyJOcntLNer6J4RHr6Csy/F+1uPmHGQ+6zy6exlKpoz/AaezP8stNFmDHw cMypK3cbD9XEiYmiCZeLmRqw97o8qKSNVmB7UeboGjXKwX1NaLsRvyh6KEHjK1UHgj pIW7rTV6FHQyQ== Date: Sun, 2 Jun 2024 10:27:26 +0100 From: Jonathan Cameron To: David Lechner Cc: Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Julien Stephan , Esteban Blanc , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/5] iio: add support for multiple scan types Message-ID: <20240602102726.35120347@jic23-huawei> In-Reply-To: <20240602102517.438b51b8@jic23-huawei> References: <20240530-iio-add-support-for-multiple-scan-types-v3-0-cbc4acea2cfa@baylibre.com> <20240602102517.438b51b8@jic23-huawei> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.42; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 2 Jun 2024 10:25:17 +0100 Jonathan Cameron wrote: > On Thu, 30 May 2024 10:14:07 -0500 > David Lechner wrote: > > > Up to now, the IIO subsystem has only supported a single scan type per > > channel. This scan type determines the binary format of the data in the > > buffer when doing buffered reads. > > > > For simple devices, there is only one scan type and all is well. But > > for more complex devices, there may be multiple scan types. For example, > > ADCs with a resolution boost feature that adds more bits to the raw > > sample data. Traditionally, for slow devices, we've just always used the > > highest resolution mode, but for high performance ADCs, this may not be > > always practical. Manipulating data after every read can hurt performance > > and in the case of hardware buffers, it may not be possible to change the > > format of the data in the buffer at all. There are also ADCs where > > enabling the higher resolution can only be done if oversampling is also > > enabled which may not be desireable. > > > > To allow for more flexibility, we would like to add support for multiple > > scan types per channel. > > > > To avoid having to touch every driver, we implemented this in a way that > > preserves the existing scan_type field. See the "iio: add support for > > multiple scan types per channel" the details. The first couple of patches > > are just preparation for this. > > > > [1]: https://lore.kernel.org/linux-iio/CAMknhBHOXaff__QyU-wFSNNENvs23vDX5n_ddH-Dw3s6-sQ9sg@mail.gmail.com/ > > Nice series. Applied to the togreg branch of iio.git and pushed out as > testing for 0-day to poke at it. > > Obviously this v3 hasn't been on list that long, but there is still time > as I doubt I'll push out a non rebasing tree for a week or so. > This week is looking too busy! oops. Goes to show I'm not keeping track of things very well today. I haven't applied the driver this updates yet. I'll look at that now and hopefully I can pick them both up. Jonathan > > Thanks, > > Jonathan > > >