Received-SPF: pass (google.com: domain of linux-kernel+bounces-198225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 2 Jun 2024 13:14:08 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
 Lars-Peter Clausen <lars@metafoo.de>, Nuno =?UTF-8?B?U8Oh?=
 <nuno.sa@analog.com>, Dragos Bogdan <dragos.bogdan@analog.com>, Anshul
 Dalal <anshulusr@gmail.com>, Andrea Collamati <andrea.collamati@gmail.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option
Message-ID: <20240602131408.08fb15d8@jic23-huawei>
In-Reply-To: <73d7ba0e54a93696aa2c8cab3e6599038bddf533.camel@gmail.com>
References: <20240528121304.3695252-1-arnd@kernel.org>
	<539a815398a3c991c1bc1a53967fbcba282dfe3b.camel@gmail.com>
	<81ec1d1a-d8de-47e4-a5d4-eeaaf1e806a2@app.fastmail.com>
	<73d7ba0e54a93696aa2c8cab3e6599038bddf533.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 29 May 2024 10:09:28 +0200
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> > On Wed, May 29, 2024, at 09:20, Nuno S=C3=A1 wrote: =20
> > > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote: =20
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >=20
> > > > Build testing without SPI results in a warning:
> > > >=20
> > > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > > > =C2=A0 Depends on [n]: SPI [=3Dn]
> > > > =C2=A0 Selected by [m]:
> > > > =C2=A0 - AD9739A [=3Dm] && IIO [=3Dm] && (SPI [=3Dn] || COMPILE_TES=
T [=3Dy])
> > > >=20
> > > > There is no need for this particular COMPILE_TEST option, as allmod=
config
> > > > and randconfig testing can just assume that SPI is enabled separate=
ly.
> > > >=20
> > > > Drop it to avoid the warning.
> > > >=20
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > --- =20
> > >=20
> > > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > >=20
> > > Only for my understanding. When does COMPILE_TEST makes sense to add?=
 =20
> >=20
> > The most common use is to enable building a driver
> > that is platform specific on x86 allmodconfig
> > or on randconfig, e.g.
> >=20
> > config LPC18XX_DAC
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tristate "NXP LPC18xx DAC dr=
iver"
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on ARCH_LPC18XX || C=
OMPILE_TEST
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on HAS_IOMEM
> >=20
> > Since ARCH_LPC18XX is only visible on arch/arm, the
> > driver would never be build tested on anything else
> > without the ||COMPILE_TEST. =20
>=20
> Makes sense... Thanks!
>=20
> - Nuno S=C3=A1
>=20

Applied. Thanks