Received-SPF: pass (google.com: domain of linux-kernel+bounces-198229-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 2 Jun 2024 13:22:04 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Dumitru Ceclan via B4 Relay
 <devnull+dumitru.ceclan.analog.com@kernel.org>
Cc: dumitru.ceclan@analog.com, Lars-Peter Clausen <lars@metafoo.de>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>
Subject: Re: [PATCH v3 5/5] iio: adc: ad7173: Fix sampling frequency setting
Message-ID: <20240602132204.385d689a@jic23-huawei>
In-Reply-To: <20240530-ad7173-fixes-v3-5-b85f33079e18@analog.com>
References: <20240530-ad7173-fixes-v3-0-b85f33079e18@analog.com>
	<20240530-ad7173-fixes-v3-5-b85f33079e18@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 30 May 2024 15:07:53 +0300
Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:

> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> 
> This patch fixes two issues regarding the sampling frequency setting:
> -The attribute was set as per device, not per channel. As such, when
>  setting the sampling frequency, the configuration was always done for
>  the slot 0, and the correct configuration was applied on the next
>  channel configuration call by the LRU mechanism.
> -The LRU implementation does not take into account external settings of
>  the slot registers. When setting the sampling frequency directly to a
>  slot register in write_raw(), there is no guarantee that other channels
>  were not also using that slot and now incorrectly retain their config
>  as live.
> 
> Set the sampling frequency attribute as separate in the channel templates.
> Do not set the sampling directly to the slot register in write_raw(),
> just mark the config as not live and let the LRU mechanism handle it.
> As the reg variable is no longer used, remove it.
> 
> Fixes: 8eb903272f75 ("iio: adc: ad7173: add AD7173 driver")
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan