Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp443289lqj; Sun, 2 Jun 2024 05:59:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV028cBjw/YwToKqZYlCmKSzeWs8j3eR1oJ1fBpEh602KEH3JlhN+jvRU9/QSLxWFQhXrUhQxOzZszvEDsJB3kWrfDXew9aaNFj84Cadw== X-Google-Smtp-Source: AGHT+IHkCBD4p4L8pZbboR5CwELL757M3/XODIrdGP0GLtBtSvnwbq/GWA3C4oWq3EBVVgQk5AIY X-Received: by 2002:a05:6a20:72a8:b0:1b0:1d0d:98f2 with SMTP id adf61e73a8af0-1b26f2b10f0mr6513703637.52.1717333170144; Sun, 02 Jun 2024 05:59:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717333170; cv=pass; d=google.com; s=arc-20160816; b=L2RjnGvmcG/d21fsPmxGbCEU4zeR9+R/AIfM9k12vQ+2bXRFf7IDE1wLBA+bjTMHM0 II4TT7SwcbezSRF+9/X5xLqTGAJ/2k2VJp2SLFAn4diM+KcD6z+UWzhRnDIGpd8hUk+x y96xVbEWYVsOjaHiHjd1Vd8hSRNOpz85fGqb2fJhELtCbVV5okJPUsNFU905QWEQl3BW slWLbk8y8XptmMAGL0TgFq6U5C0Q3ffulGbmYKMit7/VilQ2ZE4e7iu5pYkxS49z7Dui v77CXmB5Uw8a0fl7wRMUd8arB/mc+7inn76jfTiK+Tp6FGFoi3U46lL72mNSZvI/6B6Q kchw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=FuHaHtbR3sVFglKqiF3W2co4E1WuRwrFqUkuYIef86c=; fh=xjsdCYuomEJyS1EkfNUc5fKtF34cXQ1mOBn36d3R9dU=; b=SWd+kO7TlsAQTnaT0KrXqC92Bn1/aEocD6iU8f1iYJB/44pcaBhCIh6ZhToT6OuO6f RMOR8A4l9iV89VBUNpO4tA8p2OTKm12dJZ8xObpVSCabdKyVfh6zz+vJhr5UEm4PDeDZ GJvMD18xooPInlaWXelRQJ9/9h9OyBMvbVika1fHFGEZPevESv3CrpNkYPVv305E0G25 Gfv/tBkLFvPH5ooBXp66v3b/2h7LNQKi88mBOOASU44u8vqGQNgoJJmLER9ZbqwoGx4o 7yYm0IDrYV7Q4ChEGAFFqNMVWdV7rv0/MhgAn+8fy5R3JDc/yLk1qb1a9WiGDx8fobHt 6r6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NJtRp7kE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198245-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1f632416b00si48056305ad.552.2024.06.02.05.59.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:59:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NJtRp7kE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-198245-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198245-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B92E5B21A36 for ; Sun, 2 Jun 2024 12:59:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5BAFD3BB24; Sun, 2 Jun 2024 12:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NJtRp7kE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73826328DB; Sun, 2 Jun 2024 12:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717333159; cv=none; b=SGAdbWiI5u3+ETfe+onQGWUpNRODHqj6vg1j+jQ78BAJJ13pW3eoJO0Y4zJex8kCkdcoRWu5cr+gZlUi56zG8lSrVxbByeDe4Mggq0tTUpU7SONs6VopjB+wgWdte+BOLIKC2XM2EkWS09aZXvNVWt6z8hTJ+fSplwyyIxi49SI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717333159; c=relaxed/simple; bh=YViQqRewT4rh/cNeS6fZyLZzXxHkfxYtefPXiS+rd4o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fauZ4qaFi7+syumoUnODGrOYM9XzWUV1X+iNfDK171fDsdWUrX80gh3RSViLdS/QYYF6KMNsSBgbIas0zLDxNRbuKAb/tz7awhsI1oIdQXvpv+G0WQKQKYUJJGibMmSGwpypRmi1u9RqrvQCVyXrVpmWZnJqe/mvqfP/0nBnLM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NJtRp7kE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAAB5C2BBFC; Sun, 2 Jun 2024 12:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717333159; bh=YViQqRewT4rh/cNeS6fZyLZzXxHkfxYtefPXiS+rd4o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NJtRp7kE/2dLjZKtnpUPXlVdL4pR4Zmh2SZkjWs/SdppzdVM9iU8axjDciriswqLU T5SI/jt5oIB4WUZCFMwrwHe3G01PKq4rJH+GpuXOlkUA2fkpMBSoi+RAAjahiUkU8z DUEMv0nt76Dls+OXaTykCCPMJ29k52ryzASyrDG2/4pSRaqO/ksPJTCCoMxE3lgRjG sIAnGdeIwtOk6Q5MsQQq6/bM2nhO+Z8oL6qr9fBIYGXDeMeCchLMX/HT8crSm2NVaF zxtC5Xw55hXm3M+QXbBwWBxn5WuLF9xnyp5cZah4kxm+Zevr5uPgUuXHuMiUjQ+NTZ VL6plWeNEAA0Q== Date: Sun, 2 Jun 2024 13:59:08 +0100 From: Jonathan Cameron To: Vasileios Amoiridis Cc: lars@metafoo.de, himanshujha199640@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 13/17] iio: chemical: bme680: Add read buffers in DMA safe region Message-ID: <20240602135908.7e4183a2@jic23-huawei> In-Reply-To: <20240527183805.311501-14-vassilisamir@gmail.com> References: <20240527183805.311501-1-vassilisamir@gmail.com> <20240527183805.311501-14-vassilisamir@gmail.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.42; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 27 May 2024 20:38:01 +0200 Vasileios Amoiridis wrote: > Move the buffers that are used in order to read data from the > device in a DMA-safe region. Also create defines for the number > of bytes that are being read from the device and don't use > magic numbers. > > Signed-off-by: Vasileios Amoiridis Same response as previous. I don't think it's necessary because of the custom regmap implementation. My first instinct was the same as yours though! Jonathan