Received-SPF: pass (google.com: domain of linux-kernel+bounces-198248-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240520153932.116731-1-grygorii.tertychnyi@leica-geosystems.com>
In-Reply-To: <20240520153932.116731-1-grygorii.tertychnyi@leica-geosystems.com>
From: grygorii tertychnyi <grembeter@gmail.com>
Date: Sun, 2 Jun 2024 15:07:11 +0200
Message-ID: <CAGFuAux2BRy8SS=OqU=e4vryTnNLm0oKD6OCbEecy4ZoPO1yqA@mail.gmail.com>
Subject: Re: [PATCH v2] i2c: ocores: set IACK bit after core is enabled
To: Peter Korsgaard <peter@korsgaard.com>, Andrew Lunn <andrew@lunn.ch>, 
	Thomas Gleixner <tglx@linutronix.de>, linux-i2c@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Cc: Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>, 
	bsp-development.geo@leica-geosystems.com, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

just a gentle ping...  Is there anything missing?

regards

On Mon, May 20, 2024 at 5:40=E2=80=AFPM Grygorii Tertychnyi <grembeter@gmai=
l.com> wrote:
>
> Setting IACK bit when core is disabled does not clear the "Interrupt Flag=
"
> bit in the status register, and the interrupt remains pending.
>
> Sometimes it causes failure for the very first message transfer, that is
> usually a device probe.
>
> Hence, set IACK bit after core is enabled to clear pending interrupt.
>
> Fixes: 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C c=
ontroller")
> Signed-off-by: Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.=
com>
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
> Cc: stable@vger.kernel.org
> ---
> V1 -> V2: Added "Acked-by:", "Fixes:" and "Cc:" tags
>
>  drivers/i2c/busses/i2c-ocores.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-oco=
res.c
> index e106af83cef4..350ccfbe8634 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -442,8 +442,8 @@ static int ocores_init(struct device *dev, struct oco=
res_i2c *i2c)
>         oc_setreg(i2c, OCI2C_PREHIGH, prescale >> 8);
>
>         /* Init the device */
> -       oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
>         oc_setreg(i2c, OCI2C_CONTROL, ctrl | OCI2C_CTRL_EN);
> +       oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
>
>         return 0;
>  }
> --
> 2.43.0
>