Received-SPF: pass (google.com: domain of linux-kernel+bounces-198258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240602071058.6405-1-harry.yu185@gmail.com> <86o78jlms2.wl-maz@kernel.org>
In-Reply-To: <86o78jlms2.wl-maz@kernel.org>
From: yu harry <harry.yu185@gmail.com>
Date: Sun, 2 Jun 2024 21:23:43 +0800
Message-ID: <CAAmx-DzLh7TYub-PDSX+A7h6KuPYAr9WeBFmhknPjxAr2dPBnA@mail.gmail.com>
Subject: Re: [PATCH] irqchip/gic-v3: Add Allwinner sunxi001 erratum workaround
To: Marc Zyngier <maz@kernel.org>
Cc: corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, 
	tglx@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 2, 2024 at 5:25=E2=80=AFPM Marc Zyngier <maz@kernel.org> wrote:
>
> On Sun, 02 Jun 2024 08:10:58 +0100,
> "harry.yu185" <harry.yu185@gmail.com> wrote:
> >
> > Allwinner A523 GIC600 integration does not support the
> > sharability feature. So assigned Erratum ID #sunxi001 for this
> > issue.
> >
> > That the 0x0201643b ID is not Allwinner specific and thus
> > there is an extra of_machine_is_compatible() check.
> >
> > Note, because more than one soc may have this problem, the 'sunxi'
> > name is used instead of a fixed soc name like A523.
> >
> > Signed-off-by: harry.yu185 <harry.yu185@gmail.com>
>
> No, this is all already handled by the driver already (since 6.6).
>
> Please fix your DT to include the "dma-noncoherent" property in the
> GIC and ITS nodes, which should paper over the integration bug.
>
> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.

Thank you for your reply,
the method you said may not be suitable, because this SOC
also needs RDIST_FLAGS_FORCE_NON_SHAREABLE,
just like RK3588, but it is different from the RK3588 version.