Received-SPF: pass (google.com: domain of linux-kernel+bounces-198373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Erick Archer <erick.archer@outlook.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Julian Squires <julian@cipht.net>,
	Hans de Goede <hdegoede@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Justin Stitt <justinstitt@google.com>
Cc: Erick Archer <erick.archer@outlook.com>,
	linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] Input: tablet - use sizeof(*pointer) instead of sizeof(type)
Date: Sun,  2 Jun 2024 19:10:47 +0200
Message-ID:
 <AS8PR02MB7237B05083487507CFAF96B08BFE2@AS8PR02MB7237.eurprd02.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8PR02MB7237:EE_|PAWPR02MB9709:EE_
X-MS-Office365-Filtering-Correlation-Id: 4c890169-e3ad-433a-43c7-08dc8326fc75
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|3412199016|440099019|1710799017;
X-Microsoft-Antispam-Message-Info:
	tmOcuAzJMBnieYN0Ss56eEOkxnuqfqMoylxXBq1viln0GLnPCFCrbK0h8DqPUMzOxjEyC+Zuc8DmdtR99jtfCMF/yhKnWQ4z2Hjil1dasNH7BK0ijIOnEDKq/1JNQ8YvPFGJlcyw4udjFjuA9InQVf7hs3KG4OUCOOH8j7k2jt6sD9Yk+9Is0gDz/a0ul11000kb1h9CCIKEW25vksu2BRYbnVSgjyGQK8Ql4lARmOk3RpWOoSNDgfqCoiXzsVb28Tj+t+OiaOSyZaVrblX3Faj5ETUoatqaowGYNK204MXrcvbj0+uQiEd/adicwDQawBJuuFvbqBtyHy7VQyGQjuBqhBuBw1XjjwMDSQ19pxmXsovuDpdUIcBDYtiJSdrq1Asb+jj/JfYYxJf2Hjg/pZC6lYUebdY+ptKwazbw4AzojCkIiW/AFxQDZ1cfcLcLGh8VF4+EToOUEGVmiCljuhN4QiIUkuKwiF9PqkDLBsBe2PQdWyseoa9qxSJt8LGwTL32Iw1PUrMQGwI/ULSjb9sNmAnVI3OvzQYV3tXE9NzA4zGOW1Ih9YQAR0BPgkuNm5f+AQ0S3DK/hSRAiNnF+op3ZVVWasPpM7XIDTqBO4mg8hRF+zR0U3Maq8lrpyaf
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IzondYzEPjmhmQ/EEGdHqFE2P34z2EflCXsRkf3iasIyQ0+/qneYpD2a44/m?=
 =?us-ascii?Q?PdTn5m817gGxgH8+CWXm0AfU/tzj60aY5KfLDokw1W+7Pve2b2t4+EmaLqsC?=
 =?us-ascii?Q?8oEUEsSViaNJoPztmvVIZKtFB8mMY7pyWx3U1B6zhJMsfjfcXJBUMeW1do2Q?=
 =?us-ascii?Q?WtjYD0FJEDga5m8Yzq3BYLCbmcXauAdx7WUNSHb7ocqfahkJJusqIkwI593N?=
 =?us-ascii?Q?YANnkL6KRiWqsVnzzOs3TwwwYo1feoBFklW3E62Nzqsp78cA+kXqolYjGVn4?=
 =?us-ascii?Q?KBRrk5oTDHgdst2f62gNG02jVgJegTwSOywktMjT1pGH+/W6fHEmTQtSw8UF?=
 =?us-ascii?Q?Oc58GLOC5HAtWuj86Yvy+hPdce1XRKoY8t92khrDLQGyi6amWlXsuTDum6z6?=
 =?us-ascii?Q?KSyQPvGy8bqlzEt5jK9gR8jy/+pMX/P8Z88piJj+GKea7de10VMP/AjkBN/w?=
 =?us-ascii?Q?GbFResZNHFjc9HKxjBtaKnU59bbfUMipn9pZX2MWoG1mJxCDvQwv9XvU+TzA?=
 =?us-ascii?Q?XfPAxo5OYXFR2OR4TN8/F6ltDVRLiPwCp9oK+shzcZz+SHP03ppstLclxIme?=
 =?us-ascii?Q?cyS25uC8rUrfiEuvbTkMBuZvzSYMi6DdQDX8rho2ferV1860VmCf1ecyjzTr?=
 =?us-ascii?Q?bDmNUKXjIJob29t31BMjjD3sFg4MsW/u4hfVDNpqw5VUoocOmdOH6LsOX7qO?=
 =?us-ascii?Q?o/7IsSEBpiaknlokCjy4ieEQEIshQlSVbR9X12Kx2uY2r4iAXsd3eFaDwuZn?=
 =?us-ascii?Q?5Li3albOQOXh9XaiGKGKCKV5OVJSoenvD1aLp+tFhRqOuY+E+dbp/8+1Rexn?=
 =?us-ascii?Q?+p8L3vocpLKxMXtZDFt7hhXlGj0Bgdnq9eHQQ5vGS3puJ50heDkFf/IdMrlM?=
 =?us-ascii?Q?KnKSl6BNYV9ZgggJtjGzcFcF5nwfgSzbl1bU0G2fVfsoPuYsDUsaj0qipI29?=
 =?us-ascii?Q?dzY/K/xAGGJvbm9Me5G258g4EVuaRYIuns75QWaV8cog0IFF6feAiN9duwRJ?=
 =?us-ascii?Q?xII2YPIrASBqscOTLXcwF/a3tWwggK74XxvRfG7ZIx1vZ8Cb+JQVCBitUTbp?=
 =?us-ascii?Q?VLWFGza/XxpoZYy74eqhMSNMkZi+rrH3iyQ4PxzPOD7vQ6/+2U/P7NeWEuq0?=
 =?us-ascii?Q?fYPcW4jQ+CM6tz5OMCDUN4QdjIo+2b6EiqngjnXEWQeVze9ESYAHrLvvmdiK?=
 =?us-ascii?Q?3N0K4pFmfpfYpgTrc4xJFJHJ9ZQjZgaEnQFS7Mzg72Uh3uwWwLIbk+5ncCsC?=
 =?us-ascii?Q?ZU4RMddpkwQpmuJTvjCw?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c890169-e3ad-433a-43c7-08dc8326fc75
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB7237.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2024 17:11:04.8631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR02MB9709

It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
---
 drivers/input/tablet/acecad.c        | 2 +-
 drivers/input/tablet/aiptek.c        | 2 +-
 drivers/input/tablet/hanwang.c       | 2 +-
 drivers/input/tablet/kbtab.c         | 2 +-
 drivers/input/tablet/wacom_serial4.c | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
index b20e5a1afbcc..0ac16f32b31f 100644
--- a/drivers/input/tablet/acecad.c
+++ b/drivers/input/tablet/acecad.c
@@ -129,7 +129,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
 	pipe = usb_rcvintpipe(dev, endpoint->bEndpointAddress);
 	maxp = usb_maxpacket(dev, pipe);
 
-	acecad = kzalloc(sizeof(struct usb_acecad), GFP_KERNEL);
+	acecad = kzalloc(sizeof(*acecad), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!acecad || !input_dev) {
 		err = -ENOMEM;
diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
index baabc51547b8..2d176fbab251 100644
--- a/drivers/input/tablet/aiptek.c
+++ b/drivers/input/tablet/aiptek.c
@@ -1673,7 +1673,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
 	 */
 	speeds[0] = programmableDelay;
 
-	aiptek = kzalloc(sizeof(struct aiptek), GFP_KERNEL);
+	aiptek = kzalloc(sizeof(*aiptek), GFP_KERNEL);
 	inputdev = input_allocate_device();
 	if (!aiptek || !inputdev) {
 		dev_warn(&intf->dev,
diff --git a/drivers/input/tablet/hanwang.c b/drivers/input/tablet/hanwang.c
index 9bc631518b92..42c1e5eaddd5 100644
--- a/drivers/input/tablet/hanwang.c
+++ b/drivers/input/tablet/hanwang.c
@@ -322,7 +322,7 @@ static int hanwang_probe(struct usb_interface *intf, const struct usb_device_id
 	if (intf->cur_altsetting->desc.bNumEndpoints < 1)
 		return -ENODEV;
 
-	hanwang = kzalloc(sizeof(struct hanwang), GFP_KERNEL);
+	hanwang = kzalloc(sizeof(*hanwang), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!hanwang || !input_dev) {
 		error = -ENOMEM;
diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c
index aa577898e952..38d36d25f6f4 100644
--- a/drivers/input/tablet/kbtab.c
+++ b/drivers/input/tablet/kbtab.c
@@ -121,7 +121,7 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i
 	if (!usb_endpoint_is_int_in(endpoint))
 		return -ENODEV;
 
-	kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL);
+	kbtab = kzalloc(sizeof(*kbtab), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!kbtab || !input_dev)
 		goto fail1;
diff --git a/drivers/input/tablet/wacom_serial4.c b/drivers/input/tablet/wacom_serial4.c
index 1cedb45ba497..cf7cea77dabc 100644
--- a/drivers/input/tablet/wacom_serial4.c
+++ b/drivers/input/tablet/wacom_serial4.c
@@ -521,7 +521,7 @@ static int wacom_connect(struct serio *serio, struct serio_driver *drv)
 	struct input_dev *input_dev;
 	int err = -ENOMEM;
 
-	wacom = kzalloc(sizeof(struct wacom), GFP_KERNEL);
+	wacom = kzalloc(sizeof(*wacom), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	if (!wacom || !input_dev)
 		goto free_device;
-- 
2.25.1