Received-SPF: pass (google.com: domain of linux-kernel+bounces-198398-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Vasileios Amoiridis <vassilisamir@gmail.com>
Date: Sun, 2 Jun 2024 21:53:17 +0200
To: Jonathan Cameron <jic23@kernel.org>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>, lars@metafoo.de,
	himanshujha199640@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 17/17] iio: chemical: bme680: Refactorize reading
 functions
Message-ID: <20240602195317.GG387181@vamoiridPC>
References: <20240527183805.311501-1-vassilisamir@gmail.com>
 <20240527183805.311501-18-vassilisamir@gmail.com>
 <20240602140405.7d6a71d0@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240602140405.7d6a71d0@jic23-huawei>

On Sun, Jun 02, 2024 at 02:04:05PM +0100, Jonathan Cameron wrote:
> On Mon, 27 May 2024 20:38:05 +0200
> Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> 
> > The reading of the pressure and humidity value, requires an update
> > of the t_fine variable which happens by reading the temperature
> > value.
> > 
> > So the bme680_read_{press/humid}() functions of the above sensors
> > are internally calling the equivalent bme680_read_temp() function
> > in order to update the t_fine value. By just looking at the code
> > this relation is a bit hidden and is not easy to understand why
> > those channels are not independent.
> > 
> > This commit tries to clear these thing a bit by splitting the
> > bme680_{read/compensate}_{temp/press/humid}() to the following:
> > 
> > i. bme680_read_{temp/press/humid}_adc(): read the raw value from
> > the sensor.
> > 
> > ii. bme680_calc_t_fine(): calculate the t_fine variable.
> > 
> > iii. bme680_get_t_fine(): get the t_fine variable.
> > 
> > iv. bme680_compensate_{temp/press/humid}(): compensate the adc
> > values and return the calculated value.
> > 
> > v. bme680_read_{temp/press/humid}(): combine calls of the
> > aforementioned functions to return the requested value.
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> This and patches I didn't comment on (1-3, 6-9, 12, 15-17)
> all look good to me. 
> 
> Thanks,
> 
> Jonathan

Hi Jonathan,

Thank you very much for the quick and thorough review, it is
always extremely helpful. I will check a bit more on the
alignment thing internally in the I2C and SPI busses and I
will wait for your answer as well.

Cheers,
Vasilis