Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp607333lqj; Sun, 2 Jun 2024 13:28:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXBqzvvY9navxrw/Pyg4vxo4IAp6P9bOSzEevDFQ9GJTv27Uh7wE9aO9iDxlV48BwKG+vyEegu0kPkZMhSacr2F+j29XmK0MnZOnkJl3g== X-Google-Smtp-Source: AGHT+IGoDVTRxRIacg8cMe3p/6JC4ReNz2T6Hi4bw35nylDrTdU73Tr4I18G9Fgdbsvvzs1drAE5 X-Received: by 2002:a05:6214:3215:b0:6af:29f2:85ed with SMTP id 6a1803df08f44-6af29f2878fmr55686996d6.28.1717360085990; Sun, 02 Jun 2024 13:28:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717360085; cv=pass; d=google.com; s=arc-20160816; b=O35p/bYBeb0aRrvpAsI/2kLdMO4mXXRw11eTI0LWt4EU2gJQF6+3gAX2nmQ2WJtKRu mBHEUml3Zvtxj4JKtxAAojh8FPr6x5JK2yybg8LeXGGw72JRVTGpz6urZkMwGNHxrvOI 0VyeV7sgE8Hi7Wdvf7ZClJsDdKep/UZy+mOnRIHhjoQFyzdMUbJHJr67tblCw0rfzLan sxbVElP17jMpbf+UvtwIyntXOqXg5ea6qWJb6ZE5X5iWY089yxK/YL9jmHV5mt+str9G UH6Wvzm5cMIUkkC2geYq0FmMBiD0HZc/YVvVB59X3zjudSRMAW0BVyELXsQ83tWcQO9T UTmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=cGenqqyPt/Fp5kIA6u0AGK6xiTKXiqyafdjUpgpFSv0=; fh=ng0FUFwPgHHqIHtWcUlLUSBs0e7fHIUGeuUhfcQSRgA=; b=oet6mmQkOESLFcXI/hmeT+e5YVjV0jiTK1vjgMQkDHSOJMLOqHoj3Q+jPmVeu7/ynM /jPFpZYUonUGWJOhBSGrHGB2PxV2NlueZeyFlTPzY/FlFvr5BR806sryioxaz3FhtGPy HUSldOBVY12EHyxbUk8IqDLpcNOvEY8H0pkNQAJV65wlZFbQkB03VApipzR8dHYdVJPk orCZNDko+bJH9r+wgkobjP2qGFAdPeW2Mg3BRumKCSBNLrq+KW75iw1zro+SDHDnc7C0 xNy59NgKF81oP4B9kYJyKyLvX0cr+yMlT/4VvSv1lwWELC9nbQ2OOVwQKpa6Fym275G4 hO8A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=BwA9PPuR; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-198409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198409-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ae4a732ad3si69864766d6.64.2024.06.02.13.28.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 13:28:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-198409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=BwA9PPuR; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-198409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-198409-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 81B811C219B1 for ; Sun, 2 Jun 2024 20:21:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 230C382490; Sun, 2 Jun 2024 20:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="BwA9PPuR" Received: from mail-108-mta246.mxroute.com (mail-108-mta246.mxroute.com [136.175.108.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED75981AC9 for ; Sun, 2 Jun 2024 20:19:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717359580; cv=none; b=pXvKr/6bHCjHW8Uw04YTHeivxZSaVM1XprQOZ1IXixP9SRSOZFEDnDfBlMlsbtliUuFH75fUinzruzoBLoRX871QLNPwZgCRG/tGxd1LKC21vgT0KPPFglB3ndtO6Pob3v1ciZiObT/AmIrieKm4ZCjtyBqaGAw9topPNYi6BnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717359580; c=relaxed/simple; bh=pWHVLRfYub4vLHZQ82uqXL9w4o6X1xxrAcCbjuVxJt8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fo0TkIxFJnVNhUaMkwTGvBtLPDzNlQmpyRHqsrhIYf79qHF5bFenMWEIQx4a4LS2eu9iFQrBCg4T0bVh+TPTBi4fW3vVMvf7USv9i7ygL+ac7Ify5nLnaCERjH5xmFnu6AdI3aUVFR2S8z9xxkd6qBejoSONZrYk+LowL0nQz+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=BwA9PPuR; arc=none smtp.client-ip=136.175.108.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta246.mxroute.com (ZoneMTA) with ESMTPSA id 18fda966845000e2b6.010 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 02 Jun 2024 20:14:01 +0000 X-Zone-Loop: bdbda436d18093a30854b1db4d7c830b21750a5490c1 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cGenqqyPt/Fp5kIA6u0AGK6xiTKXiqyafdjUpgpFSv0=; b=BwA9PPuRMb1ER7LUAlxNZSnpPK yHUt4kBJ36mX+jJtAxXO0qh8FySnsDydayabotG3SFwotIiTpSDdZRJIw5M3iMWLP8Uk4xlCOnqrn BbQXPVd6motXl6IhZM7wSGbbZ8yP6+dalcjIl7rV6eLbhiH+vGilXBhTMxW+KM3yYJ5Y0Y/peOsPh 4eAQHgGjfI+AhFAZU9zxku6l1fahOkkhoj9FsjFLNiICYrgL/x77+axiVpT64cd9SDkPIuDFXIQzK 6/g/pTQszXjt3obAG31lyu1P9CUwR8cOP+sFB7I2QJTUu79TLLwGVj4/AtVHj57spN8yoIq5M/4Sb 4uWwiOoA==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Luis Garcia Subject: [PATCH v6 04/23] media: i2c: imx258: Remove redundant I2C writes. Date: Sun, 2 Jun 2024 14:13:26 -0600 Message-ID: <20240602201345.328737-5-git@luigi311.com> In-Reply-To: <20240602201345.328737-1-git@luigi311.com> References: <20240602201345.328737-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com From: Dave Stevenson Registers 0x0202 and 0x0203 are written via the control handler for V4L2_CID_EXPOSURE, so are not needed from the mode lists. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Luis Garcia Reviewed-by: Pavel Machek --- drivers/media/i2c/imx258.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 0ae4371940ca..df7ed4716762 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -237,8 +237,6 @@ static const struct imx258_reg mode_4208x3120_regs[] = { { 0x034E, 0x0C }, { 0x034F, 0x30 }, { 0x0350, 0x01 }, - { 0x0202, 0x0C }, - { 0x0203, 0x46 }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, @@ -356,8 +354,6 @@ static const struct imx258_reg mode_2104_1560_regs[] = { { 0x034E, 0x06 }, { 0x034F, 0x18 }, { 0x0350, 0x01 }, - { 0x0202, 0x06 }, - { 0x0203, 0x2E }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, @@ -475,8 +471,6 @@ static const struct imx258_reg mode_1048_780_regs[] = { { 0x034E, 0x03 }, { 0x034F, 0x0C }, { 0x0350, 0x01 }, - { 0x0202, 0x03 }, - { 0x0203, 0x42 }, { 0x0204, 0x00 }, { 0x0205, 0x00 }, { 0x020E, 0x01 }, -- 2.44.0