Received-SPF: pass (google.com: domain of linux-kernel+bounces-198429-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 2 Jun 2024 22:38:42 +0200
From: "Steinar H. Gunderson" <sesse@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, irogers@google.com
Subject: Re: [PATCH v7 3/4] perf annotate: LLVM-based disassembler
Message-ID: <ZlzYUjBJzlERP37P@google.com>
References: <20240526182212.544525-1-sesse@google.com>
 <20240526182212.544525-3-sesse@google.com>
 <CAM9d7cgyBGPc-HCC9nk_xNiVi3LZGM1-dE5OR4FxRvNWoFZFDA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7cgyBGPc-HCC9nk_xNiVi3LZGM1-dE5OR4FxRvNWoFZFDA@mail.gmail.com>

On Tue, May 28, 2024 at 09:06:24PM -0700, Namhyung Kim wrote:
>> +       struct symbol_lookup_storage *storage =
>> +               (struct symbol_lookup_storage *)disinfo;
> You don't need this in C. :)  Also we usually put a blank line
> after declaration (at least, at the beginning).

Done.

> We put the arguments at the same line and align them.
> Please do the same in other places.

Done, I believe.

>> +       LLVMDisasmDispose(disasm);
>> +       free(buf);
>> +       free(line_storage);
>> +       return 0;
> Often we just set a different return value here and share the
> error handling logic at the end.

Done.

/* Steinar */