Received-SPF: pass (google.com: domain of linux-kernel+bounces-198467-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 3 Jun 2024 00:59:38 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, 
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: samsung-sdi-battery: Constify struct
 power_supply_maintenance_charge_table
Message-ID: <dgkqcnvnrw3sxzojjsteqpudf4sfjhsd6ifvwzn7murxeajs4w@2qededvny4vy>
References: <cover.1717253900.git.christophe.jaillet@wanadoo.fr>
 <02c6ad69a3ace192c9d609b7336a681a8fc7ba94.1717253900.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3s5fgqs6cwwgl5ak"
Content-Disposition: inline
In-Reply-To: <02c6ad69a3ace192c9d609b7336a681a8fc7ba94.1717253900.git.christophe.jaillet@wanadoo.fr>


--3s5fgqs6cwwgl5ak
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sat, Jun 01, 2024 at 05:00:29PM +0200, Christophe JAILLET wrote:
> 'struct power_supply_maintenance_charge_table' is not modified in this
> driver.
>=20
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>=20
> In order to do it, some code also needs to be adjusted to this new const
> qualifier.
>=20
> On a x86_64, with allmodconfig:
> Before:
> =3D=3D=3D=3D=3D=3D
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text	   data	    bss	    dec	    hex	filename
>    4055	   4584	      0	   8639	   21bf	drivers/power/supply/samsung-sdi-=
battery.o
>=20
> After:
> =3D=3D=3D=3D=3D
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text	   data	    bss	    dec	    hex	filename
>    4087	   4552	      0	   8639	   21bf	drivers/power/supply/samsung-sdi-=
battery.o
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested-only
> ---

Looks like that compile testing did not include ab8500_chargalg :)
Fixing the error reported by the Intel bot should be trivial (i.e.
add another const). When you send a new version, please also Cc
Linus Walleij <linus.walleij@linaro.org>.

Thanks for your patches and greetings,

-- Sebastian

--3s5fgqs6cwwgl5ak
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZc+VMACgkQ2O7X88g7
+pqjYhAAhWSnuCwUT8O+ov/tnAB82dz8t+GhKdxleL0ha+zqLdnA5j21cbUVOULS
TRbokpnIOF5CHcoOYxsWCrKwM3vZvQ9ptLNCtCxe4+c7S13gfahv5UDYNzCyL2dF
Z+9Ta5Lf2okzv/qsw+FO4uAcVhrUz2PpZ72BDsWBYWqWlHjd/vCGrTZ5kjwknHIz
tbC2ql/YVQPcPau9ZAM5aOjeiDQqc+QL8e9D8aGAGokoWwx1LqW1AO7H+xUEb8XX
NM7v+pOercZXQdC4hoMHwFdkyotJYRAZQ4TdRtfMC9Itt83dPzERoMKirQWtDsIG
FuXfuQN4fAQH6S2vix1gkoaQjL3pHiVmay/ujUcLYA/iYVvC2u3nCwqcig/KDHFT
3zaLdrs7L3WVeLlMVVYxuJ9JPzR2HEk+cBQrkn3ijf82VI+JzpdnABpAN2eydEuH
uzOTZZXHDRoRL6rqLHEa+rFWY8Do3PiaHGWZSiWyCt1BahgDGd0jT3ElJ2IAJr8T
7YXNxqGB6UujJGiO6CEiY96u0cQMeAuDx4mtxSgihIiAOyiHD3nwk3jDCeXIqfsT
bHKdnCJg0IjgQE8l3F7ew69iZPT7vHp9vxeED4boWcCeqkCD4ARZF1jiNsLT7p8Q
KNhOHFVm93cOmENyRPKoRDFwThz+ZA5G9v4EECP9Bo0ayvcyPvA=
=z3Sd
-----END PGP SIGNATURE-----

--3s5fgqs6cwwgl5ak--