Received-SPF: pass (google.com: domain of linux-kernel+bounces-198511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 08:53:57 +0800
From: Ming Lei <ming.lei@redhat.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro
Message-ID: <Zl0UJZWx9fyZLzrm@fedora>
References: <20240602-md-block-ublk_drv-v1-1-995474cafff0@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240602-md-block-ublk_drv-v1-1-995474cafff0@quicinc.com>

On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/block/ublk_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 4e159948c912..59916895ee2e 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>  MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>  
>  MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
> +MODULE_DESCRIPTION("Userspace block device");
>  MODULE_LICENSE("GPL");

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming