Received-SPF: pass (google.com: domain of linux-kernel+bounces-198557-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Zhang, Lixu" <lixu.zhang@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>, "linux-input@vger.kernel.org"
	<linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
Thread-Topic: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
Thread-Index: AQHas3ei8UwVwp3NNUSh33LfV3FKILG1XGIA
Date: Mon, 3 Jun 2024 02:58:20 +0000
Message-ID: <DM4PR11MB599552C6835165C5FCD7F65793FF2@DM4PR11MB5995.namprd11.prod.outlook.com>
References: <20240531162836.157891-1-arnd@kernel.org>
In-Reply-To: <20240531162836.157891-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JfdYMoK9XZuHnkTrV104/1MJJhH1eOJMzwvsQB4dE9+jZ6vxRotRaye9HcfS?=
 =?us-ascii?Q?GypWNfJUMjb/wsYJ/Xv6t3JdlZ+U6+DvnBdFg2+ufq5spPgp6nprAfY19IgL?=
 =?us-ascii?Q?W84DGSarjdyRAnYAJGdKyq1I9KCJIty2bW5+Stcz8MZBR9GICLUfOuCbHFqr?=
 =?us-ascii?Q?e0ZW2VyXsWsbZ1bjJydEGZYYxhU/JJEWwrLpctxNkFZXI0IHACGbIyQUmZQw?=
 =?us-ascii?Q?MngykGoK0U8gaEWXaJngbVe5LrvULRBYaikCqAEKGyNEdb/B7qFr5pWo7Ap3?=
 =?us-ascii?Q?c4N1slo4iTSktRp/6T/Zopohg0plAgANvcyWt1SC1+d8a0ggVviRm8YirDWG?=
 =?us-ascii?Q?5RyE5MKHsB2Ge7mzDJEZ+wf8UNlAKf7d9mD52E/xTsbwlVq9doGdf9++Zh6P?=
 =?us-ascii?Q?UTj6t//5HlfJ9Z30HYS/fMsVuEuywczNeGSvWn9E5T9VcXXwbAeyD+Ch6T3m?=
 =?us-ascii?Q?3rIoGGbPojKJ4isVKgfA+ROdmEyUgRSAdjE3ATdGHd4HyI/GIttFZGFZzT4s?=
 =?us-ascii?Q?astczdPDVT/4c+XYfY04VPgQ4sIy8CQysBVBwU2GhCrHH9xpfDTYu8Nd2HVt?=
 =?us-ascii?Q?hpUY055fvSkjdn7vKyT3QPV+HIJ8DDbCTVjhYL88/3Z6i6ch+NBx46ISDqH1?=
 =?us-ascii?Q?ng4cYse9zZ4GCuQ6BCJOtIX74nUZWnITkQeEwEUEg+W2qOo9patHFfM39m/X?=
 =?us-ascii?Q?Sg+YYEBzYodi82+9dRxy2NuSPIdEN9kJZeNojVIt3y18bTc3Kpzy9qy7sJw4?=
 =?us-ascii?Q?P5EIaqLbm8Oc2q9ViMoQmsIMsid+lCFGO4i0AH11v1x4obiAAgMuj4RRnSPt?=
 =?us-ascii?Q?HnBUJsXCbZ4dofHcCI2jSNb3jwOQ2SyLm6zaX+28vWXoXYjp3GPLPEWxzk6V?=
 =?us-ascii?Q?1Win4jBrm5C2z59zB6KktztnOSWxtCLjwpg9OYJ8Nk6sG+F0bxo0Z1JUsQWX?=
 =?us-ascii?Q?Jd1unYyKP7yR1DKskToE+/d/RrUGItGIPq167W2UnD347OYR+FEzTpCBu2f9?=
 =?us-ascii?Q?FTOZ/TnSXg2gVMTHMfzveCOFbV/aJi4IOVgtswKi6lg+okNQ/E9InWvITu5y?=
 =?us-ascii?Q?yaXpskia+Ucg/qjpLv4UMPq9k3gkt7TZMX3mTrAjwo7+8D4vrMvVNXsbwx/W?=
 =?us-ascii?Q?lhdGHNH0svilLP2MUEAK7F6T202k7GlyOnCutRMBTWCIlvZxkMf4+ksh/gZK?=
 =?us-ascii?Q?3xwfB2yhHWBXXoFSPlUpCGYlXGF0+S4vhDo9QQI0FeG43rxm24PFP3w1xrrO?=
 =?us-ascii?Q?CjQg9qqPGf8Lmiva4d6UmICpnawzQFKRCv37uV9hcMcMu85IbWTPyUZYshK6?=
 =?us-ascii?Q?4ke4tz1MySJHgKJ/ka+/o971NULBTTwbeKBtGVFyeyX2P7KgwYA9tt1zz9k4?=
 =?us-ascii?Q?5/HCkoA/AyLyfyUpqlLj21JloeFzZr+28W1h/kAN/fZtbp6I0BRnbWPo2l6o?=
 =?us-ascii?Q?GkFxYDTa7/yyzLaxIyR1E/Uw0SKkCc6ctec638zIQipC5edWG/B7sI9VZD1N?=
 =?us-ascii?Q?5wC9lqe5IaJwUG1StypX+NdHIpg+hI9oEJ82QkHFyKdJc/CA+7DBvJCaaprX?=
 =?us-ascii?Q?S//d+XnBXpF93GhksMe8nDPMZS3Oxa5iIGRx9LL5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7027a166-ff9e-478f-bf8d-08dc837906b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 02:58:20.6555
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tiT0laPgRxZnKgDgCTQqugMBBONp+wsRBFdeSS/eoN2COPkMbmiXh8Rb/o+6Bw7w8lmSxxmCsFM7V2JhM5jdlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7087
X-OriginatorOrg: intel.com

>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Saturday, June 1, 2024 12:28 AM
>To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Jiri Kosina
><jikos@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>; Zhang, Lixu
><lixu.zhang@intel.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; linux-input@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
>
>From: Arnd Bergmann <arnd@arndb.de>
>
>The newly added file causes a ton of sparse warnings about the incorrect u=
se of
>__le32 and similar types:
>
>drivers/hid/intel-ish-hid/ishtp/loader.h:41:23: error: invalid bitfield sp=
ecifier for
>type restricted __le32.
>drivers/hid/intel-ish-hid/ishtp/loader.h:42:27: error: invalid bitfield sp=
ecifier for
>type restricted __le32.
>drivers/hid/intel-ish-hid/ishtp/loader.h:43:24: error: invalid bitfield sp=
ecifier for
>type restricted __le32.
>drivers/hid/intel-ish-hid/ishtp/loader.h:44:24: error: invalid bitfield sp=
ecifier for
>type restricted __le32.
>drivers/hid/intel-ish-hid/ishtp/loader.h:45:22: error: invalid bitfield sp=
ecifier for
>type restricted __le32.
>drivers/hid/intel-ish-hid/ishtp/loader.c:172:33: warning: restricted __le3=
2
>degrades to integer
>drivers/hid/intel-ish-hid/ishtp/loader.c:178:50: warning: incorrect type i=
n
>assignment (different base types)
>drivers/hid/intel-ish-hid/ishtp/loader.c:178:50:    expected restricted __=
le32
>[usertype] length
>drivers/hid/intel-ish-hid/ishtp/loader.c:178:50:    got unsigned long
>drivers/hid/intel-ish-hid/ishtp/loader.c:179:50: warning: incorrect type i=
n
>assignment (different base types)
>drivers/hid/intel-ish-hid/ishtp/loader.c:179:50:    expected restricted __=
le32
>[usertype] fw_off
>drivers/hid/intel-ish-hid/ishtp/loader.c:179:50:    got unsigned int [user=
type]
>offset
>drivers/hid/intel-ish-hid/ishtp/loader.c:180:17: warning: cast from restri=
cted
>__le32
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:24: warning: invalid assignme=
nt: +=3D
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:24:    left side has type uns=
igned int
>drivers/hid/intel-ish-hid/ishtp/loader.c:183:24:    right side has type re=
stricted
>__le32
>
>Add the necessary conversions and use temporary variables where appropriat=
e
>to avoid converting back.
>
>Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading firmware from
>host feature")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
>v2:
> - fix minor issues introduced in rebasing
> - rebase again on linux-next without the cache management patch
> - fix up changelog text
>---

Thanks for your patch. I have tested it on LNL platform, it works fine.

Please fix the build warning reported by kernel test robot. https://lore.ke=
rnel.org/oe-kbuild-all/202406011319.hk4MAysc-lkp@intel.com/

  drivers/hid/intel-ish-hid/ishtp/loader.c:170: warning: Function parameter=
 or struct member 'fragment_count' not described in 'prepare_dma_bufs'

After that, please add my name.
Reviewed-by: Zhang Lixu <lixu.zhang@intel.com>
Tested-by: Zhang Lixu <lixu.zhang@intel.com>

Thanks,
Lixu