Received-SPF: pass (google.com: domain of linux-kernel+bounces-198564-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Zhang, Lixu" <lixu.zhang@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@linux.intel.com>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>, "linux-input@vger.kernel.org"
	<linux-input@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
Thread-Topic: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
Thread-Index: AQHas3ei8UwVwp3NNUSh33LfV3FKILG1Xyzw
Date: Mon, 3 Jun 2024 03:10:30 +0000
Message-ID: <DM4PR11MB5995E948FEC165CC5A27488193FF2@DM4PR11MB5995.namprd11.prod.outlook.com>
References: <20240531162836.157891-1-arnd@kernel.org>
In-Reply-To: <20240531162836.157891-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5Qsqhu4hWpHK+5HmubwfiWansMydTvvdz3OEicmgFHG+5MpM8eEYbzdnh+YD?=
 =?us-ascii?Q?rxLoy29Kt96c2kFrsC+fP3KYislCCb6OFPQR4FcKl7nJul4EccJdC2rnU5MW?=
 =?us-ascii?Q?S0xnhWfESKt8WoUhEfk8Tpm9says2RaiWDr/aS9mQclg69hTnVd3TDWCQ4PT?=
 =?us-ascii?Q?OKSZT/WzijGky4U4WMk9QK+uP+PjSEwayRWEsClg7IPeUf+O+3p+sn26CJtH?=
 =?us-ascii?Q?xpy/3ItDvBUNpvCc9C/JJxXbzHi7zU+KEI1mIl8aWwU3CLur0KQTwRkQYG/q?=
 =?us-ascii?Q?xRq5cQdDrb6t6+BB8Lvx1rF4py1zetq3/OabOQIVRAwQ7nOPdBfeQIXZdAkf?=
 =?us-ascii?Q?aAiJUTd0QaR6xwFy9DTYOniuY0RNPo7+ZDYPwqHHMjpXlBrWDRSorzhEdlAx?=
 =?us-ascii?Q?ujnhRNZo2Jt5DiUx2OCqVe2uCYriHR478WwZNtht6gC6PdyaYdg3qItxUAqM?=
 =?us-ascii?Q?4z+5iOrL+TConqAw/N7Cob7786qJlkR7l4zH51ahWSALJKFO1d8KH5xDVR7D?=
 =?us-ascii?Q?ukGQiyI6MOKpAj93ql6sMAXSUVSt70I5AJso4TsRI1B4+44Duj4xOlgsstGv?=
 =?us-ascii?Q?+tH6OipjDR3oYoRtVbxvaSfTlZ7fOxV3YXSpdn6YG87/wvl/65Nvz6aHDr1K?=
 =?us-ascii?Q?kWRHBwIj6x2WHLArG/R/0LdUxvrGxqv9/0agyB1ZLblJePzyRxXrsY6dHbu+?=
 =?us-ascii?Q?gAafTER7/ZmkmXF76/dwPyc/WFKnWWgjLJFo6k6XDHTXfPRR/Mf3slH2NUdL?=
 =?us-ascii?Q?vJIHvqN3MD7RCXY7BnTpOLVW6Jq032Jrz+qZ8QQ5jwsrkHQfLBIrkZWW+Dfh?=
 =?us-ascii?Q?XpXHkZwPBJyPckeTKnbk7NeUyBuZvP1PFavlFQONzhSxOylrp2i7dtEN1cwl?=
 =?us-ascii?Q?nRvN1FaQt1K2uqVW446rVgcZqRR3S/nynySht0GoyJXrBazot5urREsSlRFB?=
 =?us-ascii?Q?lltp84zyQa28/wrL2SEt4le84NpfE7OFbG6QnTaYE2rkbpyafBOeWsXSTJ4e?=
 =?us-ascii?Q?7JJrhBdaNh4FIlDR9pJWPAc9gGnq2IgqZVyFMYxzzz+zuiO2sHgjiLUlOwTU?=
 =?us-ascii?Q?fhGGBvSnamTlsq62UaNCN7jvqyIwDIQkCU+Li4BeATNb/PC7xqzOm/zaNSgp?=
 =?us-ascii?Q?Ht71b5BKmK246lqrUxMmk6w6ZfHudgwAMVCHXrIcJNqA+HfcSlr8bIYJPIRj?=
 =?us-ascii?Q?u7Puqp896oTTobOxmzW06zmJPTy1qhhHQ71UdT8RHtrA3qP8E8lvgxr0cM+P?=
 =?us-ascii?Q?pjKvPrXO0n+1Oy691kQt3t/nJtrDzc+E10jM9JiyRASE1S0f/T5Rj1zz0ZFF?=
 =?us-ascii?Q?fFaMX+uFHwLnQFyPvwU5+jsQBQKMZClqV2nuy7qk8oILAxZbEkvAaEDBJPwO?=
 =?us-ascii?Q?qkrpHOZlAAw21w/MNULf5Vvakd42Sp2dsy4KFLe8FIWhQSUOckGXc9TeXsSt?=
 =?us-ascii?Q?4ZtYGWMP6EZSaAMOGc+upCLH1mGLg8JHWeJ0x+1H7+Ny6Q4pwwNPY6WqNt/M?=
 =?us-ascii?Q?S1XKqKEPz2HYUQOMHC1W6rT1dVrNYUCJJmSLEONHQtH70UVJQEMLWbiL4Q5A?=
 =?us-ascii?Q?WUdLaEIyhqWOVkmZLi24x00fHh0n8JZw7paJ5xSq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8caf70c5-8d43-4048-91ef-08dc837ab9ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 03:10:30.8091
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Kh99xFSPNXDC+QfZxjxVTA70bjhWuzUaj/d39IaWeAUi8nonkOm7RiPdFRAzcrKKERVbkhJAy1+DgFLIrJ1hEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7375
X-OriginatorOrg: intel.com

>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Saturday, June 1, 2024 12:28 AM
>To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Jiri Kosina
><jikos@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>; Zhang, Lixu
><lixu.zhang@intel.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; linux-input@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] [v2] HID: intel-ish-hid: fix endian-conversion
>
>@@ -228,23 +233,24 @@ void ishtp_loader_work(struct work_struct *work)
> 		return;
> 	}
>
>-	fragment->fragment.header.command =3D
>LOADER_CMD_XFER_FRAGMENT;
>-	fragment->fragment.xfer_mode =3D LOADER_XFER_MODE_DMA;
>-	fragment->fragment.is_last =3D 1;
>-	fragment->fragment.size =3D ish_fw->size;
>+	fragment->fragment.header =3D cpu_to_le32(fragment_hdr.val32);;
s/;;/;/

>+	fragment->fragment.xfer_mode =3D
>cpu_to_le32(LOADER_XFER_MODE_DMA);
>+	fragment->fragment.is_last =3D cpu_to_le32(1);
>+	fragment->fragment.size =3D cpu_to_le32(ish_fw->size);
> 	/* Calculate the size of a single DMA fragment */
> 	fragment_size =3D PFN_ALIGN(DIV_ROUND_UP(ish_fw->size,