Received-SPF: pass (google.com: domain of linux-kernel+bounces-198593-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: Leon Romanovsky <leon@kernel.org>, Bharat Bhushan <bbhushan2@marvell.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Geethasowjanya
 Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Jerin Jacob <jerinj@marvell.com>, Linu Cherian <lcherian@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: RE: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Topic: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline
 ipsec transmit offload
Thread-Index: AQHasQaTGOI655GPbkyOq/WYx7AM5rG0EIWAgAFrXoA=
Date: Mon, 3 Jun 2024 04:33:30 +0000
Message-ID: 
 <BY3PR18MB4737F1C148F2C230A4ABC49CC6FF2@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20240528135349.932669-1-bbhushan2@marvell.com>
 <20240528135349.932669-7-bbhushan2@marvell.com>
 <20240602065125.GH3884@unreal>
In-Reply-To: <20240602065125.GH3884@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?XcOdWirqd9fw+kmX0+P9aBYfNU3t+V4ZXyozWUS9jSRo9yB3RVRXsF8d7UUj?=
 =?us-ascii?Q?2j+aF+jj+yjiCIAhI4eRQb1Q38LNmlfRjNko+Bi/SQUm5f9OC5FdE0AYhUK0?=
 =?us-ascii?Q?HArFFN3bYeEA6W71+sHvgZ1CiN4dUMUDLtcMtAXW8WzMIa10lbEL6cNsDxBi?=
 =?us-ascii?Q?DXvBeCsWKBau4Vr9oEYy2F0lEi4di1dzYV9Q8hjBYS/LLZB+2aNtnAGRZ80K?=
 =?us-ascii?Q?jqMJCLRpZ2zZChLBL/1bnd69e8LasXsUM7DsIZIV7uK/FO/jIBSM0C4N8c32?=
 =?us-ascii?Q?luAAyvAW7k2PhzhCJMEHgp3x/aVWs7F3vpKz10Z68vv8d1llZQK7obhDO3Bt?=
 =?us-ascii?Q?zNOM6iu6EvkJ1aG3qO8WvKOeaCxzzSem/YRY+40YIot1dKTjBkubrxyfv8Zj?=
 =?us-ascii?Q?x03cmXBtIrOnywwdc0j6eStM845PuLwh80cbRubkkmFBDLwFvPGIfIZ7PSXl?=
 =?us-ascii?Q?iUWRC6e746gfwoZnIC5hBDcXc1ExWWjDntd/k9T/JaHCewAzfCuODJ0NZFyh?=
 =?us-ascii?Q?xUTXW5cGy3Y+63cNkYq/Pd5cxcy9zBDgYwEFUyIogkwVYZMIwsnLsWB48pdg?=
 =?us-ascii?Q?jNYR38q22BvSBFvqrf4L8TBx6Cv041r/Ws4xvUWRqHZmvumELHV/bGJ0gnBj?=
 =?us-ascii?Q?Rwakkg5FGJLW1f4BTm92zR2H3QVGlDQ1J7sEhJrA+qne57YBfgGH/MyzDVyX?=
 =?us-ascii?Q?7/DAA4WnfoGW0+WEZk2D5aljJmmAFtvTQ5nJoX4GnpjnlT5OXyduwDrsKgV8?=
 =?us-ascii?Q?bm0SyDOMUkAMKAOBlcQ6B46mmy8TMwScgP31lNFmveV8TD5yQuNsgEo3hP6x?=
 =?us-ascii?Q?BPkapCUIt4GdYWWBRjYeXTEMj4m2lP75lFbnjn1Zg3/xnGQkoHIfzDpRGmDJ?=
 =?us-ascii?Q?Yf0CmVKzr3ner+3YeY/IdJSjYfzQJtGB6q455v5nxgpWHLgUgfEQFh1LvnMd?=
 =?us-ascii?Q?jQyDVx6F+gKaGAPV3lp6+UjeFqa20BvvSdzTEmmnu1vnIsX3+Z0Npoxax7Di?=
 =?us-ascii?Q?OYBkgOaS/DGRjh4RwbibBTi62Dhcze2DYCf+objlJ/pyYUQg6qufm7lYkHK9?=
 =?us-ascii?Q?r3384LTGllkNYUCWNmz5RVLkZ0C7/4Vw6RBWNvqBrw0gyKUcaS6bAdamxGnx?=
 =?us-ascii?Q?vFPrEf5KO3BT1x71RE3jQ2v+AqzMW2x025v77N9QZNUzatbXFYv02vztkmZV?=
 =?us-ascii?Q?qIVlOlYkfyzXiDyXSTcrXJ1AeXdnelKU9OqKDHMpHb3uqNQiv/pvcR0LtYVu?=
 =?us-ascii?Q?43HuApIW7ooZYSFwFujrF9NSbXvnOH+H5k2rVdtIGjDWCQW8C7keK/5g27ZD?=
 =?us-ascii?Q?lwePnTpRT9cubYcgqdDjwe8xjsIi7M1IYHba6Bo5h8xb9xeQAvuxZdx3lsgJ?=
 =?us-ascii?Q?//uOjvMlRABX3JNlsix5/Eq4GdxuGOJRA+58NnxHRzdKEwktlFmJVUImYXU/?=
 =?us-ascii?Q?XJ+4T3RhMeLJnlxaWRrSKW+rgldzJomYf5YBDNt/5NvUiW0xhU1sysvd5f+O?=
 =?us-ascii?Q?30D4VsTAhndm5VhCOtKIh6TNdkQp745txoMhtoMV8MZ34vd3OT+wqtRryDoy?=
 =?us-ascii?Q?V/84dzkMgH/Mosbl9ktKYk43BYTis16WB/wzLcgJ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb4beb3-6d73-4902-3010-08dc83865259
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 04:33:30.9737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iz0jpL6p2y06I03qngaH6jT8zrlWdjZ+hvZKw8iiBelT0EYw9Ep0GlajchD+mbyjbsGZ7mUwTxoYgOaPj0xLEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB6200
X-Proofpoint-GUID: jE4dma4M42yd-JXu5hVcsSpGxGF7RkiT
X-Proofpoint-ORIG-GUID: jE4dma4M42yd-JXu5hVcsSpGxGF7RkiT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-02_15,2024-05-30_01,2024-05-17_01


>-----Original Message-----
>From: Leon Romanovsky <leon@kernel.org>
>Sent: Sunday, June 2, 2024 12:21 PM
>To: Bharat Bhushan <bbhushan2@marvell.com>
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
>Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Jerin Jacob
><jerinj@marvell.com>; Linu Cherian <lcherian@marvell.com>;
>richardcochran@gmail.com
>Subject: [EXTERNAL] Re: [net-next,v3 6/8] cn10k-ipsec: Process inline ipse=
c
>transmit offload
>
>Prioritize security for external emails: Confirm sender and content safety=
 before
>clicking links or opening attachments
>
>----------------------------------------------------------------------
>On Tue, May 28, 2024 at 07:23:47PM +0530, Bharat Bhushan wrote:
>> Prepare and submit crypto hardware (CPT) instruction for outbound
>> inline ipsec crypto mode offload. The CPT instruction have
>> authentication offset, IV offset and encapsulation offset in input
>> packet. Also provide SA context pointer which have details about algo,
>> keys, salt etc. Crypto hardware encrypt, authenticate and provide the
>> ESP packet to networking hardware.
>>
>> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
>> ---
>>  .../marvell/octeontx2/nic/cn10k_ipsec.c       | 224 ++++++++++++++++++
>>  .../marvell/octeontx2/nic/cn10k_ipsec.h       |  40 ++++
>>  .../marvell/octeontx2/nic/otx2_common.c       |  23 ++
>>  .../marvell/octeontx2/nic/otx2_common.h       |   3 +
>>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |   2 +
>>  .../marvell/octeontx2/nic/otx2_txrx.c         |  33 ++-
>>  .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +
>>  7 files changed, 325 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
>> index 136aebe2a007..1974fda2e0d3 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_ipsec.c
>> @@ -7,8 +7,11 @@
>>  #include <net/xfrm.h>
>>  #include <linux/netdevice.h>
>>  #include <linux/bitfield.h>
>> +#include <crypto/aead.h>
>> +#include <crypto/gcm.h>
>>
>>  #include "otx2_common.h"
>> +#include "otx2_struct.h"
>>  #include "cn10k_ipsec.h"
>>
>>  static bool is_dev_support_inline_ipsec(struct pci_dev *pdev) @@
>> -843,3 +846,224 @@ void cn10k_ipsec_clean(struct otx2_nic *pf)
>>  	cn10k_outb_cpt_clean(pf);
>>  }
>>  EXPORT_SYMBOL(cn10k_ipsec_clean);
>
><...>
>
>> +bool cn10k_ipsec_transmit(struct otx2_nic *pf, struct netdev_queue *txq=
,
>> +			  struct otx2_snd_queue *sq, struct sk_buff *skb,
>> +			  int num_segs, int size)
>> +{
>> +	struct cpt_ctx_info_s *sa_info;
>> +	struct cpt_inst_s inst;
>> +	struct cpt_res_s *res;
>> +	struct xfrm_state *x;
>> +	dma_addr_t dptr_iova;
>> +	struct sec_path *sp;
>> +	u8 encap_offset;
>> +	u8 auth_offset;
>> +	u8 gthr_size;
>> +	u8 iv_offset;
>> +	u16 dlen;
>> +
>> +	/* Check for Inline IPSEC enabled */
>> +	if (!(pf->flags & OTX2_FLAG_INLINE_IPSEC_ENABLED)) {
>> +		netdev_err(pf->netdev, "Ipsec not enabled, drop packet\n");
>
><...>
>
>> +		netdev_err(pf->netdev, "%s: no xfrm state len =3D %d\n",
>> +			   __func__, sp->len);
>
><...>
>
>> +		netdev_err(pf->netdev, "no xfrm_input_state()\n");
>
><...>
>
>> +		netdev_err(pf->netdev, "un supported offload mode %d\n",
>> +			   x->props.mode);
>
><...>
>
>> +		netdev_err(pf->netdev, "Invalid IP header, ip-length zero\n");
>
><...>
>
>> +		netdev_err(pf->netdev, "Invalid SA conext\n");
>
>All these prints are in datapath and can be triggered by network packets. =
These
>and RX prints need to be deleted.
>

Yes, all these error messages in datapath should be under netif_msg_tx_err(=
).

Thanks,
Sunil.