Received-SPF: pass (google.com: domain of linux-kernel+bounces-198672-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <1717146645-18829-1-git-send-email-zhiguo.niu@unisoc.com> <b0c9f3dc-417a-4891-bdf0-25b849828e3b@kernel.org>
In-Reply-To: <b0c9f3dc-417a-4891-bdf0-25b849828e3b@kernel.org>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Mon, 3 Jun 2024 14:52:16 +0800
Message-ID: <CAHJ8P3LFkk0YnF-vnsd7wVMHXyhJN43Gfqtq3EBqjxoqgd88mg@mail.gmail.com>
Subject: Re: [PATCH] f2fs: use new ioprio Macro to get ckpt thread ioprio data
To: Chao Yu <chao@kernel.org>
Cc: Zhiguo Niu <zhiguo.niu@unisoc.com>, jaegeuk@kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, 
	ke.wang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 3, 2024 at 2:39=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/5/31 17:10, Zhiguo Niu wrote:
> > Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio data(level),
> > it is more accurate and consisten with the way setting ckpt thread
> > ioprio(IOPRIO_PRIO_VALUE(class, data)).
> >
> > Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > ---
> >   fs/f2fs/sysfs.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 72676c5..55d46da 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -340,7 +340,7 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a,
> >       if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) {
> >               struct ckpt_req_control *cprc =3D &sbi->cprc_info;
> >               int class =3D IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio)=
;
> > -             int data =3D IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio);
> > +             int data =3D IOPRIO_PRIO_LEVEL(cprc->ckpt_thread_ioprio);
>
> So, can you please use 'level' to instead 'data' in f2fs_sbi_show() and
> __sbi_store()?
Hi Chao,

IOPRIO_PRIO_DATA in the new kernel version includes two parts: level and hi=
nt.
In __sbi_store, " IOPRIO_PRIO_VALUE(class, data)"  is used to set ckpt
iopriority,
and it will pass default hint value, we just need to keep class /level righ=
t.

 #define IOPRIO_PRIO_VALUE(prioclass, priolevel) \
   ioprio_value(prioclass, priolevel, IOPRIO_HINT_NONE)
so i think this part is not needed to modify.

thanks!
>
> Thanks,
>
> >
> >               if (class !=3D IOPRIO_CLASS_RT && class !=3D IOPRIO_CLASS=
_BE)
> >                       return -EINVAL;
>