Received-SPF: pass (google.com: domain of linux-kernel+bounces-198687-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 3 Jun 2024 09:03:27 +0200
From: Lukasz Majewski <lukma@denx.de>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org, Paolo Abeni
 <pabeni@redhat.com>, Eric Dumazet <edumazet@google.com>, Vladimir Oltean
 <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Oleksij
 Rempel <o.rempel@pengutronix.de>, Tristram.Ha@microchip.com, Sebastian
 Andrzej Siewior <bigeasy@linutronix.de>, Ravi Gunasekaran
 <r-gunasekaran@ti.com>, Simon Horman <horms@kernel.org>, Nikita
 Zhandarovich <n.zhandarovich@fintech.ru>, Murali Karicheri
 <m-karicheri2@ti.com>, Arvid Brodin <Arvid.Brodin@xdin.com>, Dan Carpenter
 <dan.carpenter@linaro.org>, "Ricardo B. Marliere" <ricardo@marliere.net>,
 Casper Andersson <casper.casan@gmail.com>, linux-kernel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Geliang Tang <tanggeliang@kylinos.cn>,
 Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: hsr: Extend the hsr_redbox.sh test to use
 fixed MAC addresses
Message-ID: <20240603090327.44d43f53@wsk>
In-Reply-To: <ZlfXmDN-W1dZRYQL@Laptop-X1>
References: <20240529142232.2625747-1-lukma@denx.de>
	<20240529142232.2625747-2-lukma@denx.de>
	<ZlfXmDN-W1dZRYQL@Laptop-X1>
Organization: denx.de
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/z8W=oEaNQY.U9rvg.vX2APw";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/z8W=oEaNQY.U9rvg.vX2APw
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Hangbin,

> On Wed, May 29, 2024 at 04:22:32PM +0200, Lukasz Majewski wrote:
> > Fixed MAC addresses help with debugging as last four bytes identify
> > the network namespace.
> >=20
> > Moreover, it allows to mimic the real life setup with for example
> > bridge having the same MAC address on each port.
> >=20
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  tools/testing/selftests/net/hsr/hsr_redbox.sh | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >=20
> > diff --git a/tools/testing/selftests/net/hsr/hsr_redbox.sh
> > b/tools/testing/selftests/net/hsr/hsr_redbox.sh index
> > 1f36785347c0..998103502d5d 100755 ---
> > a/tools/testing/selftests/net/hsr/hsr_redbox.sh +++
> > b/tools/testing/selftests/net/hsr/hsr_redbox.sh @@ -96,6 +96,21 @@
> > setup_hsr_interfaces() ip -n "${ns4}" link set ns4eth1 up
> >  	ip -n "${ns5}" link set ns5eth1 up
> > =20
> > +	ip -net "$ns1" link set address 00:11:22:00:01:01 dev
> > ns1eth1
> > +	ip -net "$ns1" link set address 00:11:22:00:01:02 dev
> > ns1eth2 +
> > +	ip -net "$ns2" link set address 00:11:22:00:02:01 dev
> > ns2eth1
> > +	ip -net "$ns2" link set address 00:11:22:00:02:02 dev
> > ns2eth2
> > +	ip -net "$ns2" link set address 00:11:22:00:02:03 dev
> > ns2eth3 +
> > +	ip -net "$ns3" link set address 00:11:22:00:03:11 dev
> > ns3eth1
> > +	ip -net "$ns3" link set address 00:11:22:00:03:11 dev
> > ns3eth2
> > +	ip -net "$ns3" link set address 00:11:22:00:03:11 dev
> > ns3eth3
> > +	ip -net "$ns3" link set address 00:11:22:00:03:11 dev
> > ns3br1 =20
>=20
> The ns3's mac addresses are same, is it a copy-paste error?
>=20

No, it is to mimic the switch behaviour.

> BTW, please add the target tree for the patch, e.g.
>=20
> [PATCH net-next]

Ok.

>=20
> Thanks
> Hangbin


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/z8W=oEaNQY.U9rvg.vX2APw
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmZdar8ACgkQAR8vZIA0
zr3YeAgAx49HYhwsbFX+W79el/XYDzgWltp7XpxTRGWmi5/Aed3UdY+Ym5KfoziB
HOMZWYInj0H8Gx+85e9kgObLHv/0bDQGbpu19uBzmsrk6Scv7H9vqgZaSQzzpPT+
041vngmHhdknG39xDN+AgT1OOZt95N7gAM7qZqD72bohRxhcJ6BSh7REdyG9kSv4
Ow1KkBky9aKQCnATC2RQBVxL5ex3QKINpiGIeMYbhiVIpTDINU7Rl3U+Fj0aOgW1
wtuD8a28UVBnmkXFs3aVB3N8DPBgVwmSKR/yJHGzCcTJEWLHjwrjX7u2F/ogZSmI
k4Gwyja4rojDvqrA84zQy8ol83z75g==
=iEHT
-----END PGP SIGNATURE-----

--Sig_/z8W=oEaNQY.U9rvg.vX2APw--