Received-SPF: pass (google.com: domain of linux-kernel+bounces-198736-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <10f4898f-0b8c-4503-8620-3bb566e9a163@kernel.org>
Date: Mon, 3 Jun 2024 15:50:03 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] f2fs: use new ioprio Macro to get ckpt thread ioprio data
To: Zhiguo Niu <niuzhiguo84@gmail.com>
Cc: Zhiguo Niu <zhiguo.niu@unisoc.com>, jaegeuk@kernel.org,
 linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
 ke.wang@unisoc.com
References: <1717146645-18829-1-git-send-email-zhiguo.niu@unisoc.com>
 <b0c9f3dc-417a-4891-bdf0-25b849828e3b@kernel.org>
 <CAHJ8P3LFkk0YnF-vnsd7wVMHXyhJN43Gfqtq3EBqjxoqgd88mg@mail.gmail.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <CAHJ8P3LFkk0YnF-vnsd7wVMHXyhJN43Gfqtq3EBqjxoqgd88mg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2024/6/3 14:52, Zhiguo Niu wrote:
> On Mon, Jun 3, 2024 at 2:39 PM Chao Yu <chao@kernel.org> wrote:
>>
>> On 2024/5/31 17:10, Zhiguo Niu wrote:
>>> Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio data(level),
>>> it is more accurate and consisten with the way setting ckpt thread
>>> ioprio(IOPRIO_PRIO_VALUE(class, data)).
>>>
>>> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
>>> ---
>>>    fs/f2fs/sysfs.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>>> index 72676c5..55d46da 100644
>>> --- a/fs/f2fs/sysfs.c
>>> +++ b/fs/f2fs/sysfs.c
>>> @@ -340,7 +340,7 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a,
>>>        if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) {
>>>                struct ckpt_req_control *cprc = &sbi->cprc_info;
>>>                int class = IOPRIO_PRIO_CLASS(cprc->ckpt_thread_ioprio);
>>> -             int data = IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio);
>>> +             int data = IOPRIO_PRIO_LEVEL(cprc->ckpt_thread_ioprio);
>>
>> So, can you please use 'level' to instead 'data' in f2fs_sbi_show() and
>> __sbi_store()?
> Hi Chao,
> 
> IOPRIO_PRIO_DATA in the new kernel version includes two parts: level and hint.
> In __sbi_store, " IOPRIO_PRIO_VALUE(class, data)"  is used to set ckpt
> iopriority,
> and it will pass default hint value, we just need to keep class /level right.

Zhiguo,

I think f2fs only support configuring priolevel rather than priolevel and
priohint of ckpt thread via ckpt_thread_ioprio sysfs interface, so it will
be more readable to use 'level' instead of 'data' in context of the interface,
thoughts?

Thanks,

> 
>   #define IOPRIO_PRIO_VALUE(prioclass, priolevel) \
>     ioprio_value(prioclass, priolevel, IOPRIO_HINT_NONE)
> so i think this part is not needed to modify.
> 
> thanks!
>>
>> Thanks,
>>
>>>
>>>                if (class != IOPRIO_CLASS_RT && class != IOPRIO_CLASS_BE)
>>>                        return -EINVAL;
>>