Received-SPF: pass (google.com: domain of linux-kernel+bounces-198763-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <1717146645-18829-1-git-send-email-zhiguo.niu@unisoc.com>
 <b0c9f3dc-417a-4891-bdf0-25b849828e3b@kernel.org> <CAHJ8P3LFkk0YnF-vnsd7wVMHXyhJN43Gfqtq3EBqjxoqgd88mg@mail.gmail.com>
 <10f4898f-0b8c-4503-8620-3bb566e9a163@kernel.org>
In-Reply-To: <10f4898f-0b8c-4503-8620-3bb566e9a163@kernel.org>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Mon, 3 Jun 2024 16:14:38 +0800
Message-ID: <CAHJ8P3LVadqmrFsZLcbCp_QdCo06F2YtpgfL0hrVrrp6fdyrnA@mail.gmail.com>
Subject: Re: [PATCH] f2fs: use new ioprio Macro to get ckpt thread ioprio data
To: Chao Yu <chao@kernel.org>
Cc: Zhiguo Niu <zhiguo.niu@unisoc.com>, jaegeuk@kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, 
	ke.wang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 3, 2024 at 3:50=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/6/3 14:52, Zhiguo Niu wrote:
> > On Mon, Jun 3, 2024 at 2:39=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
> >>
> >> On 2024/5/31 17:10, Zhiguo Niu wrote:
> >>> Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio data(level)=
,
> >>> it is more accurate and consisten with the way setting ckpt thread
> >>> ioprio(IOPRIO_PRIO_VALUE(class, data)).
> >>>
> >>> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> >>> ---
> >>>    fs/f2fs/sysfs.c | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> >>> index 72676c5..55d46da 100644
> >>> --- a/fs/f2fs/sysfs.c
> >>> +++ b/fs/f2fs/sysfs.c
> >>> @@ -340,7 +340,7 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a,
> >>>        if (!strcmp(a->attr.name, "ckpt_thread_ioprio")) {
> >>>                struct ckpt_req_control *cprc =3D &sbi->cprc_info;
> >>>                int class =3D IOPRIO_PRIO_CLASS(cprc->ckpt_thread_iopr=
io);
> >>> -             int data =3D IOPRIO_PRIO_DATA(cprc->ckpt_thread_ioprio)=
;
> >>> +             int data =3D IOPRIO_PRIO_LEVEL(cprc->ckpt_thread_ioprio=
);
> >>
> >> So, can you please use 'level' to instead 'data' in f2fs_sbi_show() an=
d
> >> __sbi_store()?
> > Hi Chao,
> >
> > IOPRIO_PRIO_DATA in the new kernel version includes two parts: level an=
d hint.
> > In __sbi_store, " IOPRIO_PRIO_VALUE(class, data)"  is used to set ckpt
> > iopriority,
> > and it will pass default hint value, we just need to keep class /level =
right.
>
> Zhiguo,
>
> I think f2fs only support configuring priolevel rather than priolevel and
> priohint of ckpt thread via ckpt_thread_ioprio sysfs interface, so it wil=
l
> be more readable to use 'level' instead of 'data' in context of the inter=
face,
> thoughts?
Hi  Chao,
I understand what you said and I agree with this. I will update it in
the next version.
Thanks!
>
> Thanks,
>
> >
> >   #define IOPRIO_PRIO_VALUE(prioclass, priolevel) \
> >     ioprio_value(prioclass, priolevel, IOPRIO_HINT_NONE)
> > so i think this part is not needed to modify.
> >
> > thanks!
> >>
> >> Thanks,
> >>
> >>>
> >>>                if (class !=3D IOPRIO_CLASS_RT && class !=3D IOPRIO_CL=
ASS_BE)
> >>>                        return -EINVAL;
> >>