Received-SPF: pass (google.com: domain of linux-kernel+bounces-198764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b4256b15-997d-4e10-a6a9-a1b41011c867@ti.com>
Date: Mon, 3 Jun 2024 13:44:54 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: "ERROR: modpost: "icssg_queue_pop" [...] undefined" on arm64
Content-Language: en-US
To: Thorsten Leemhuis <linux@leemhuis.info>,
        Dan Carpenter
	<dan.carpenter@linaro.org>,
        Jan Kiszka <jan.kiszka@siemens.com>, Simon Horman
	<horms@kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean
	<vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>, Diogo Ivo <diogo.ivo@siemens.com>,
        Roger Quadros <rogerq@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
	<edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>,
        Vignesh Raghavendra
	<vigneshr@ti.com>
References: <20240528113734.379422-1-danishanwar@ti.com>
 <20240528113734.379422-2-danishanwar@ti.com>
 <de980a49-b802-417a-a57e-2c47f67b08e4@leemhuis.info>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <de980a49-b802-417a-a57e-2c47f67b08e4@leemhuis.info>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Thorsten,

On 03/06/24 12:39 pm, Thorsten Leemhuis wrote:
> On 28.05.24 13:37, MD Danish Anwar wrote:
>> Introduce helper functions to configure firmware FDB tables, VLAN tables
>> and Port VLAN ID settings to aid adding Switch mode support.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> Hi! Since Friday I get a compile error in my -next builds for Fedora:
> 
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> 

Before posting the patches I had tested them with defconfig and I didn't
see any ERRORs.

I think in the config that you are using most probably
CONFIG_TI_ICSSG_PRUETH_SR1 is enabled. The patch adds APIs in
icssg_config.c which uses APIs added in icssg_qeueus.c.

Now CONFIG_TI_ICSSG_PRUETH_SR1 also uses icssg_config.c but
icssg_queues.c is not built for SR1 as a result this error is coming.

Fix for this will be to build icssg_queues as well for SR1 driver.

I will test the fix and post it to net-next soon.

> Looks like this problem was found and reported mid May by the kernel
> test robot already, which identified a earlier version of the patch I'm
> replying to to be the cause:
> https://lore.kernel.org/all/202405182038.ncf1mL7Z-lkp@intel.com/
> 
> That and the fact that the patch showed up in -next on Friday makes me
> assume that my problem is caused by this change as well as well. A build
> log can be found here:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-39-aarch64/07523690-next-next-all/builder-live.log.gz
> 
> I don't have the .config at hand, but can provide it when needed.
> 

Yes that would be helpful. If possible just check in the .config what
symbols are enabled related to ICSS. (`cat .config | grep ICSS`)

> Ciao, Thorsten
> 
>> ---
>>  drivers/net/ethernet/ti/icssg/icssg_config.c | 170 +++++++++++++++++++
>>  drivers/net/ethernet/ti/icssg/icssg_config.h |  19 +++
>>  drivers/net/ethernet/ti/icssg/icssg_prueth.h |  12 ++
>>  3 files changed, 201 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/ti/icssg/icssg_config.c b/drivers/net/ethernet/ti/icssg/icssg_config.c
>> index 15f2235bf90f..2213374d4d45 100644
>> --- a/drivers/net/ethernet/ti/icssg/icssg_config.c
>> +++ b/drivers/net/ethernet/ti/icssg/icssg_config.c
>> @@ -477,3 +477,173 @@ void icssg_config_set_speed(struct prueth_emac *emac)
>>  

[...]


-- 
Thanks and Regards,
Danish