Received-SPF: pass (google.com: domain of linux-kernel+bounces-198781-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: multipart/signed;
 boundary=d46e1a1054ac3317006112254d36d8e54f39007c7af5372dd6e3ff89531b;
 micalg=pgp-sha384; protocol="application/pgp-signature"
Date: Mon, 03 Jun 2024 10:25:44 +0200
Message-Id: <D1Q8LSUGXEIH.1N6HH5514YIJV@kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: macronix: workaround for device id re-use
Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>, "Pratyush Yadav"
 <pratyush@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>,
 "Richard Weinberger" <richard@nod.at>, "Vignesh Raghavendra"
 <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>,
 <linux-kernel@vger.kernel.org>, "Rasmus Villemoes"
 <rasmus.villemoes@prevas.dk>
From: "Michael Walle" <mwalle@kernel.org>
To: "Esben Haabendal" <esben@geanix.com>
References: <20240524-macronix-mx25l3205d-fixups-v1-1-ee152e56afb3@geanix.com> <D1Q7BU6PJ356.1CTXPUZE8U6XX@kernel.org> <87frtuigo3.fsf@geanix.com>
In-Reply-To: <87frtuigo3.fsf@geanix.com>
Precedence: bulk

--d46e1a1054ac3317006112254d36d8e54f39007c7af5372dd6e3ff89531b
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi,

> > In that case, I'd rather see a new flag in .no_sfdp_flags
> > to explicitly trigger the SFDP read. Then your new flash would only
> > need this flag and doesn't require the shenanigans with the fixup,
> > right?
>
> I fixup would still be required in order to enable 1-2-2 for MX25L3205D,
> as it will fail the SFDP read, but actually does support 1-2-2.

But you (probably) don't care and we also don't care for the
additional speed. So, I'd rather drop that code that is just there
for that ancient EoL flash.

-michael

--d46e1a1054ac3317006112254d36d8e54f39007c7af5372dd6e3ff89531b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZl1+CRIcbXdhbGxlQGtl
cm5lbC5vcmcACgkQEic87j4CH/jdKQF8DveA1osmeLfihnlbROPQphfmdPnklv7X
NaNjhbgJEmKxtS2zk+jZVwssNfPFUUnxAYDHBEZh9zqy67jhffWnmu8w9KS9vEI9
8kUa3IDDladbn6eU15rcwQXCHadZvM6CGQg=
=JZ4L
-----END PGP SIGNATURE-----

--d46e1a1054ac3317006112254d36d8e54f39007c7af5372dd6e3ff89531b--