Received-SPF: pass (google.com: domain of linux-kernel+bounces-198786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 3 Jun 2024 09:31:45 +0100
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: <linux@treblig.org>
CC: <yangyicong@hisilicon.com>, <peterz@infradead.org>, <mingo@redhat.com>,
	<jolsa@kernel.org>, <irogers@google.com>, <linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
Message-ID: <20240603093145.00001de9@Huawei.com>
In-Reply-To: <20240602000709.213116-1-linux@treblig.org>
References: <20240602000709.213116-1-linux@treblig.org>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Sun,  2 Jun 2024 01:07:09 +0100
linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
by which I mean I searched for it and indeed found only this definition.

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>  	u32 pmu_type;
>  };
>  
> -struct hisi_ptt_queue {
> -	struct hisi_ptt *ptt;
> -	struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
>  {
>  	uint32_t head = *(uint32_t *)buf;