Received-SPF: pass (google.com: domain of linux-kernel+bounces-198799-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 09:39:16 +0100
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: oleg@redhat.com, arnd@arndb.de, afd@ti.com, akpm@linux-foundation.org,
	linus.walleij@linaro.org, eric.devolder@oracle.com, robh@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Add HAVE_FUNCTION_ARG_ACCESS_API support
Message-ID: <Zl2BNCXzKRG+eTDv@shell.armlinux.org.uk>
References: <20240603073751.2282024-1-ruanjinjie@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240603073751.2282024-1-ruanjinjie@huawei.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Mon, Jun 03, 2024 at 03:37:51PM +0800, Jinjie Ruan wrote:
> Currently, kprobe on ARM32 can not use the '$argx' syntax available on
> other architecture. So implement regs_get_kernel_argument() and add
> HAVE_FUNCTION_ARG_ACCESS_API support.

This may work in the simple case, but it just doesn't work in the
general case, where a function accepts 64-bit arguments. For example,
for EABI and a function taking a 64-bit argument followed by a 32-bit
argument:

	R0/R1 = 64-bit argument
	R2 = 32-bit argument

Now consider 32-bit argument followed by 64-bit argument:

	R0 = 32-bit argument
	R1 = unused
	R2/R3 = 64-bit argument

Note that the mapping isn't argN = RN.

Also, given that "unsigned long" is 32-bit on 32-bit Arm, one can't
return a 64-bit argument through this interface. Even if one typed
the function as u64, it still wouldn't work because the caller
assigns the return value to an unsigned long. This seems to be an
issue throughout the kernel tracing - it isn't written to support
64-bit arguments on 32-bit architectures. See, for example,
fetch_store_raw(), where the unsigned long gets cast to a u64.
It'll still only have 32-bits of significant value.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!